[GitHub] cordova-plugin-camera issue #282: Fix camera permissions bug on video stream...

[filmaj]

Github user filmaj commented on the issue:

https://github.com/apache/cordova-plugin-camera/pull/282
  
The code you link to (step 4 of the guide) doesn't use 
cordova-plugin-camera's JS API. It uses:

```
navigator.getUserMedia = navigator.getUserMedia ||
navigator.webkitGetUserMedia || navigator.mozGetUserMedia;
```

So I don't see how this permission applies to the camera plugin 
specifically. Perhaps one requires the camera permission for that newer, more 
modern JS API, but if it's not related to the specific APIs provided by 
cordova-plugin-camera, I don't think this change belongs in this plugin.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera issue #282: Fix camera permissions bug on video stream...

[douglasmoraisdev]

Github user douglasmoraisdev commented on the issue:

https://github.com/apache/cordova-plugin-camera/pull/282
  
As I mentioned earlier, I am developing a WebRTC application based on 
Google WebRTC Codelabs. 
(https://codelabs.developers.google.com/codelabs/webrtc-web/).
If you try to follow the step 4 of this Codelab on a Ionic (v1) project, I 
guess you can reproduce the error.

I fixed the bug in my project by adding the PR code in plugins.xml OR by 
adding the same permissions in /platforms/android/AndroidManifest.xml manually 
(which is the same thing)

If this help, this is my package.json on my Ionic (v1) project:
'''
{
"name": "mobile",
"version": "0.0.1",
"description": "Real Time Comunicator",
"devDependencies": {
"@ionic/cli-plugin-cordova": "1.4.1",
"@ionic/cli-plugin-gulp": "1.0.2",
"@ionic/cli-plugin-ionic1": "2.0.1",
"gulp": "^3.9.1",
"gulp-clean-css": "^3.7.0",
"gulp-rename": "^1.2.0",
"gulp-sass": "^3.1.0"
},
"dependencies": {
"@ionic-native/camera": "^4.0.1",
"@ionic-native/diagnostic": "^4.0.1",
"clean": "^4.0.2",
"cordova-android": "^6.2.3",
"cordova-browser": "^4.1.0",
"cordova-plugin-android-permissions": 
"git+https://github.com/NeoLSN/cordova-plugin-android-permissions.git;,
"cordova-plugin-camera": 
"git+https://github.com/apache/cordova-plugin-camera.git;,
"cordova-plugin-compat": "^1.1.0",
"cordova-plugin-console": "^1.0.7",
"cordova-plugin-crosswalk-webview": 
"git+https://github.com/crosswalk-project/cordova-plugin-crosswalk-webview.git;,
"cordova-plugin-device": "^1.1.6",
"cordova-plugin-file": "^4.3.3",
"cordova-plugin-media-capture": 
"git+https://github.com/apache/cordova-plugin-media-capture.git;,
"cordova-plugin-microphone": 
"git+https://github.com/amitgur/cordova-plugin-microphone.git;,
"cordova-plugin-splashscreen": "^4.0.3",
"cordova-plugin-statusbar": "^2.2.3",
"cordova-plugin-whitelist": "^1.3.2",
"ionic-plugin-keyboard": "^2.2.1"
},
"cordova": {
"plugins": {
"cordova-plugin-console": {},
"cordova-plugin-device": {},
"cordova-plugin-splashscreen": {},
"cordova-plugin-statusbar": {},
"cordova-plugin-whitelist": {},
"ionic-plugin-keyboard": {},
"cordova-plugin-crosswalk-webview": {
"XWALK_VERSION": "23+",
"XWALK_LITEVERSION": "xwalk_core_library_canary:17+",
"XWALK_COMMANDLINE": "--disable-pull-to-refresh-effect",
"XWALK_MODE": "embedded",
"XWALK_MULTIPLEAPK": "true"
},
"cordova-plugin-camera": {},
"cordova-plugin-media-capture": {},
"cordova-plugin-android-permissions": {}
},
"platforms": [
"android",
"browser"
]
}
}
'''

If you still need more info, i will commit a simple code and tell you when 
to do it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera issue #282: Fix camera permissions bug on video stream...

[filmaj]

Github user filmaj commented on the issue:

https://github.com/apache/cordova-plugin-camera/pull/282
  
@douglasmoraisdev how can I test that this change is needed? Is there a 
particular camera API i need to access on API 24+ to see the failure? Just want 
to reproduce the failed / fixed scenarios. Thanks for any info.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #580: CB-12895 : Replaced jshint with eslint

[audreyso]

GitHub user audreyso opened a pull request:

https://github.com/apache/cordova-lib/pull/580

CB-12895 : Replaced jshint with eslint



### Platforms affected


### What does this PR do?

 Replaced jshint with eslint

### What testing has been done on this change?


### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/audreyso/cordova-lib CB-12895-2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/580.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #580


commit 4cb49cf58523d0ef8039cba6b2d3d6a7ebc260a9
Author: Audrey So 
Date:   2017-07-19T16:51:05Z

CB-12895 : set up eslint

commit 25c80f56f2697f6f359669eb8e150b208e2cd9f2
Author: Audrey So 
Date:   2017-07-19T16:54:49Z

CB-12895 : ran eslint --fix on cordova-lib

commit 55a3eccf913ac0cee11633718a11748a43e8cb88
Author: Audrey So 
Date:   2017-07-20T16:41:06Z

CB-12895 : updated integration tests with eslint




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android issue #396: CB-12677: (android) added option for explicitly ...

[infil00p]

Github user infil00p commented on the issue:

https://github.com/apache/cordova-android/pull/396
  
Did you see the fix @purplecabbage did to pull this info from the Windows 
registry for Windows users? We're probably going to go with that solution for 
Windows because of the whole PATH issue.  Mac OS and Linux users are able to 
install Gradle without a problem.  There are already other issues with using or 
requiring Android Studio as a dependency, such as the fact that some people 
don't ever use the IDE


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #579: CB-12361 : added tests for save.js

[audreyso]

GitHub user audreyso opened a pull request:

https://github.com/apache/cordova-lib/pull/579

CB-12361 : added tests for save.js



### Platforms affected


### What does this PR do?


### What testing has been done on this change?
added tests for save.js

### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/audreyso/cordova-lib CB-12361-11

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/579.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #579






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file pull request #211: CB-6938: (fix) on iOS, copyTo should ...

[VinceOPS]

GitHub user VinceOPS opened a pull request:

https://github.com/apache/cordova-plugin-file/pull/211

CB-6938: (fix) on iOS, copyTo should overwrite any existing file

https://issues.apache.org/jira/browse/CB-6938

### Platforms affected
iOS, all versions.

### What does this PR do?
It fixes CB-6938.
Instead of returning an error 12 (PATH_EXISTS_ERR), it tries to remove the 
existing file, then to copy the "new" one.

### What testing has been done on this change?
Simulator: iPhone 5 and iPhone 6 @ iOS 9, 10.
Real device: iPhone 5 @ iOS 10.

No unit test provided nor written.

### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/VinceOPS/cordova-plugin-file 
CB-6938cordova-plugin-file

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-file/pull/211.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #211


commit 064c7f33e8d9b5dcee4f520e80a385336c9fcbc5
Author: VinceOPS 
Date:   2017-07-20T13:00:42Z

iOS: (fix) copyTo should overwrite any existing file




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Nightly build #433 for cordova has failed

[Apache Jenkins Server]

Nightly build #433 for cordova has failed.

Please check failure details on build details page at 
https://builds.apache.org/job/cordova-nightly/433/
You can also take a look at build console: 
https://builds.apache.org/job/cordova-nightly/433/consoleFull

-
Jenkins for Apache Cordova

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android issue #396: CB-12677: (android) added option for explicitly ...

[russaa]

Github user russaa commented on the issue:

https://github.com/apache/cordova-android/pull/396
  
I have to say, I like the current solution better (using `gradle` from 
Android Studio):

 1. you are not required to install something, that you may already have 
installed
 2. if you are building/debugging the Cordova app with Android Studio, you 
can be sure that builds are same (as you are using the same version of `gradle`)
 3. users who prefer to install `gradle` separately still have this option

If you want to get rid of the automatic-detection (because it may become 
cumbersome to maintain) I would still like to have the option of using Android 
Studio's `gradle` by pointing to its place via the env variable.   
Its code should be fairly easy to maintain, since the user is responsible 
to specify the correct path, i.e. the detection routine only needs to look into 
the env variable and does not need to be adjusted to changing path structures 
etc. itself.  
Although the mechanism then should maybe be changed, so that the env 
variable needs to point the `gradle` directory directly, instead of the Android 
Studio directory (which it does now), e.g. change the env variable to something 
like `GRADLE_HOME` and the path would need to point, e.g. to the `gradle` 
sub-directory of the Android Studio directory.


As an additional reason:  
I assume the _"install `gradle` separately/as requirement"_ option also 
means, that you must have `gradle` in your PATH env variable.

On Windows, this is a concern for me, as the PATH variable has a maximum 
length -- which I, for instance, are always about to exceed. So I try to not 
have paths there, if I can avoid it.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org