[GitHub] cordova-docs issue #714: CB-12984: (docs) Add Android versions to "supported...
Github user filmaj commented on the issue: https://github.com/apache/cordova-docs/pull/714 One of the Cordova PMC members needs to build and update the website based on the latest docs. We should automate this ð --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Nightly build #448 for cordova has succeeded!
Nightly build #448 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/448/consoleFull - Jenkins for Apache Cordova - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs issue #713: CB-12980: (iOS) Improve instruction and add detail ...
Github user sudotamm commented on the issue: https://github.com/apache/cordova-docs/pull/713 Ok, I will close this pull request and create a new one for upper section change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request #713: CB-12980: (iOS) Improve instruction and add ...
Github user sudotamm closed the pull request at: https://github.com/apache/cordova-docs/pull/713 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs issue #718: CB-13159: Remove Intel XDK from homepage
Github user tony-- commented on the issue: https://github.com/apache/cordova-docs/pull/718 Thanks for the help and the sentiment Shaz! Much appreciated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs issue #713: CB-12980: (iOS) Improve instruction and add detail ...
Github user shazron commented on the issue: https://github.com/apache/cordova-docs/pull/713 @sudotamm agreed, the upper section can stay. perhaps change this PR to omit the second section, or create a new PR with just the first section. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request #718: CB-13159: Remove Intel XDK from homepage
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/718 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs issue #718: CB-13159: Remove Intel XDK from homepage
Github user shazron commented on the issue: https://github.com/apache/cordova-docs/pull/718 ð¢ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] shazron commented on issue #326: CB-12940: [IOS] Use deployment-target from config.xml for platform ve?
shazron commented on issue #326: CB-12940: [IOS] Use deployment-target from config.xml for platform ve? URL: https://github.com/apache/cordova-ios/pull/326#issuecomment-321110477 ``` Parsing C:\projects\cordova-ios\tests\spec\unit\fixtures\ios-config-xml\ios-config-xml\SampleApp\config.xml failed { Error: ENOENT: no such file or directory, open 'C:\projects\cordova-ios\tests\spec\unit\fixtures\ios-config-xml\ios-config-xml\SampleApp\config.xml' ``` Note that it is doubling up on the `ios-config-xml` in the path. I'll have to test in Windows to see what's up. Wait for Travis to finish testing to see if its a common error. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] shazron commented on issue #326: CB-12940: [IOS] Use deployment-target from config.xml for platform ve?
shazron commented on issue #326: CB-12940: [IOS] Use deployment-target from config.xml for platform ve? URL: https://github.com/apache/cordova-ios/pull/326#issuecomment-321110477 ``` Parsing C:\projects\cordova-ios\tests\spec\unit\fixtures\ios-config-xml\ios-config-xml\SampleApp\config.xml failed { Error: ENOENT: no such file or directory, open 'C:\projects\cordova-ios\tests\spec\unit\fixtures\ios-config-xml\ios-config-xml\SampleApp\config.xml' ``` Note that it is doubling up on the `ios-config-xml` in the path. I'll have to test in Windows to see what's up. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request #718: CB-13159: Remove Intel XDK from homepage
GitHub user tony-- opened a pull request: https://github.com/apache/cordova-docs/pull/718 CB-13159: Remove Intel XDK from homepage ### Platforms affected N/A ### What does this PR do? Remove Intel XDK from the tools section of the homepage. ### What testing has been done on this change? I built the site and ran it locally, verifying that the homepage was changed as expected. ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change (N/A) You can merge this pull request into a Git repository by running: $ git pull https://github.com/tony--/cordova-docs remove-tool-intel-xdk Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/718.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #718 commit 8392dc19051ffb49352eca9f43a2a725b9768ac4 Author: Tony HomerDate: 2017-08-08T22:00:24Z CB-13159: Remove Intel XDK from homepage --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: git commits being sent to dev
https://issues.apache.org/jira/browse/INFRA-14823 On Tue, Aug 8, 2017 at 3:41 PM, Shazronwrote: > Yeah, the last time was through JIRA -> Service Desk tab -> Create Service > Desk Request -> Apache Infrastructure -> Github Integration > > On Tue, Aug 8, 2017 at 3:26 PM, Steven Gill > wrote: > > > How do we get them to change it? File an issue with infra I guess? > > > > On Tue, Aug 8, 2017 at 11:18 AM, Shazron wrote: > > > > > They shouldn't be going to dev@, instead they should be going to > > commits@ > > > > > > On Tue, Aug 8, 2017 at 11:10 AM, Simon MacDonald < > > > simon.macdon...@gmail.com> > > > wrote: > > > > > > > I agree, don't send commit's do the dev list. > > > > > > > > Simon Mac Donald > > > > http://simonmacdonald.com > > > > > > > > On Tue, Aug 8, 2017 at 1:54 PM, Joe Bowser > wrote: > > > > > > > > > I'm already filtering all that stuff since I'm already getting it. > > In > > > > > fact, this is why I didn't see the Github invite. > > > > > > > > > > But yeah, we should not have the commit e-mails go to the dev > mailing > > > > list, > > > > > since it'll just spam everyone. It'd be good if more people would > > use > > > > the > > > > > list to talk about proposals, or at least link to the proposal on > > > GitHub, > > > > > since it's not the Apache way to do stuff outside of the mailing > > list. > > > > > > > > > > (Yeah, I'm being serious about the mailing list and the Apache way. > > We > > > > > should use the dev list for discussion more.) > > > > > > > > > > On Tue, Aug 8, 2017 at 10:39 AM, Steven Gill < > stevengil...@gmail.com > > > > > > > > wrote: > > > > > > > > > > > Hey! > > > > > > > > > > > > How do people feel about these git commit emails being sent to > dev > > > > > mailing > > > > > > list. This is only happening to repos that have fully switched > over > > > to > > > > > > github (gitbox setup). > > > > > > > > > > > > Personally, I am already watching the repos so I get the emails. > I > > > > don't > > > > > > need the emails to come to dev. I think it would be better people > > > just > > > > > > click watch on repos they want emails from, setup mail filters > and > > go > > > > > from > > > > > > there. No need for commit emails to be sent to dev. > > > > > > > > > > > > I could just as easily update my mail filters to move the git > > emails > > > > > being > > > > > > sent to dev into a different directory. > > > > > > > > > > > > Thoughts? > > > > > > > > > > > > > > > > > > > > >
[GitHub] shazron commented on issue #269: CB-12002 - Support LSApplicationQueriesSchemes
shazron commented on issue #269: CB-12002 - Support LSApplicationQueriesSchemes URL: https://github.com/apache/cordova-ios/pull/269#issuecomment-321104510 eslint errors. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: git commits being sent to dev
Yeah, the last time was through JIRA -> Service Desk tab -> Create Service Desk Request -> Apache Infrastructure -> Github Integration On Tue, Aug 8, 2017 at 3:26 PM, Steven Gillwrote: > How do we get them to change it? File an issue with infra I guess? > > On Tue, Aug 8, 2017 at 11:18 AM, Shazron wrote: > > > They shouldn't be going to dev@, instead they should be going to > commits@ > > > > On Tue, Aug 8, 2017 at 11:10 AM, Simon MacDonald < > > simon.macdon...@gmail.com> > > wrote: > > > > > I agree, don't send commit's do the dev list. > > > > > > Simon Mac Donald > > > http://simonmacdonald.com > > > > > > On Tue, Aug 8, 2017 at 1:54 PM, Joe Bowser wrote: > > > > > > > I'm already filtering all that stuff since I'm already getting it. > In > > > > fact, this is why I didn't see the Github invite. > > > > > > > > But yeah, we should not have the commit e-mails go to the dev mailing > > > list, > > > > since it'll just spam everyone. It'd be good if more people would > use > > > the > > > > list to talk about proposals, or at least link to the proposal on > > GitHub, > > > > since it's not the Apache way to do stuff outside of the mailing > list. > > > > > > > > (Yeah, I'm being serious about the mailing list and the Apache way. > We > > > > should use the dev list for discussion more.) > > > > > > > > On Tue, Aug 8, 2017 at 10:39 AM, Steven Gill > > > > > wrote: > > > > > > > > > Hey! > > > > > > > > > > How do people feel about these git commit emails being sent to dev > > > > mailing > > > > > list. This is only happening to repos that have fully switched over > > to > > > > > github (gitbox setup). > > > > > > > > > > Personally, I am already watching the repos so I get the emails. I > > > don't > > > > > need the emails to come to dev. I think it would be better people > > just > > > > > click watch on repos they want emails from, setup mail filters and > go > > > > from > > > > > there. No need for commit emails to be sent to dev. > > > > > > > > > > I could just as easily update my mail filters to move the git > emails > > > > being > > > > > sent to dev into a different directory. > > > > > > > > > > Thoughts? > > > > > > > > > > > > > > >
[GitHub] cordova-docs issue #714: CB-12984: (docs) Add Android versions to "supported...
Github user janpio commented on the issue: https://github.com/apache/cordova-docs/pull/714 Sure, thanks for taking care of it! How does deployment work, when will this be on https://cordova.apache.org/docs/en/dev/guide/platforms/android/index.html? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: git commits being sent to dev
How do we get them to change it? File an issue with infra I guess? On Tue, Aug 8, 2017 at 11:18 AM, Shazronwrote: > They shouldn't be going to dev@, instead they should be going to commits@ > > On Tue, Aug 8, 2017 at 11:10 AM, Simon MacDonald < > simon.macdon...@gmail.com> > wrote: > > > I agree, don't send commit's do the dev list. > > > > Simon Mac Donald > > http://simonmacdonald.com > > > > On Tue, Aug 8, 2017 at 1:54 PM, Joe Bowser wrote: > > > > > I'm already filtering all that stuff since I'm already getting it. In > > > fact, this is why I didn't see the Github invite. > > > > > > But yeah, we should not have the commit e-mails go to the dev mailing > > list, > > > since it'll just spam everyone. It'd be good if more people would use > > the > > > list to talk about proposals, or at least link to the proposal on > GitHub, > > > since it's not the Apache way to do stuff outside of the mailing list. > > > > > > (Yeah, I'm being serious about the mailing list and the Apache way. We > > > should use the dev list for discussion more.) > > > > > > On Tue, Aug 8, 2017 at 10:39 AM, Steven Gill > > > wrote: > > > > > > > Hey! > > > > > > > > How do people feel about these git commit emails being sent to dev > > > mailing > > > > list. This is only happening to repos that have fully switched over > to > > > > github (gitbox setup). > > > > > > > > Personally, I am already watching the repos so I get the emails. I > > don't > > > > need the emails to come to dev. I think it would be better people > just > > > > click watch on repos they want emails from, setup mail filters and go > > > from > > > > there. No need for commit emails to be sent to dev. > > > > > > > > I could just as easily update my mail filters to move the git emails > > > being > > > > sent to dev into a different directory. > > > > > > > > Thoughts? > > > > > > > > > >
[GitHub] cordova-docs pull request #714: CB-12984: (docs) Add Android versions to "su...
Github user janpio closed the pull request at: https://github.com/apache/cordova-docs/pull/714 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] shazron closed pull request #328: CB-13093: (iOS) Infinite looping when stressing navigation
shazron closed pull request #328: CB-13093: (iOS) Infinite looping when stressing navigation URL: https://github.com/apache/cordova-ios/pull/328 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request #575: CB-13020: (plugman) install filters out nohoo...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/575 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs issue #714: CB-12984: (docs) Add Android versions to "supported...
Github user filmaj commented on the issue: https://github.com/apache/cordova-docs/pull/714 I've merged this in in 9f31ce77b --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[DISCUSS] [Play Services Version]
Hi all! There is a proposal to offer an alternative solution for CB-13145: https://issues.apache.org/jira/browse/CB-13145. Please review the proposal below: https://github.com/cordova/cordova-discuss/pull/74/files We would appreciate any feedback, advice, comments, and questions you have on this proposal. Looking forward to hearing any thoughts. Thanks so much! Audrey
[DISCUSS][Proposal to migrate from Jira to Github]
Hi everyone, We are considering migrating our issues from Jira to Github and would appreciate any feedback, advice, comments, and questions you have on this proposal: https://github.com/cordova/cordova-discuss/pull/75/files. Looking forward to hearing any thoughts. Thanks so much! Audrey
Re: git commits being sent to dev
They shouldn't be going to dev@, instead they should be going to commits@ On Tue, Aug 8, 2017 at 11:10 AM, Simon MacDonaldwrote: > I agree, don't send commit's do the dev list. > > Simon Mac Donald > http://simonmacdonald.com > > On Tue, Aug 8, 2017 at 1:54 PM, Joe Bowser wrote: > > > I'm already filtering all that stuff since I'm already getting it. In > > fact, this is why I didn't see the Github invite. > > > > But yeah, we should not have the commit e-mails go to the dev mailing > list, > > since it'll just spam everyone. It'd be good if more people would use > the > > list to talk about proposals, or at least link to the proposal on GitHub, > > since it's not the Apache way to do stuff outside of the mailing list. > > > > (Yeah, I'm being serious about the mailing list and the Apache way. We > > should use the dev list for discussion more.) > > > > On Tue, Aug 8, 2017 at 10:39 AM, Steven Gill > > wrote: > > > > > Hey! > > > > > > How do people feel about these git commit emails being sent to dev > > mailing > > > list. This is only happening to repos that have fully switched over to > > > github (gitbox setup). > > > > > > Personally, I am already watching the repos so I get the emails. I > don't > > > need the emails to come to dev. I think it would be better people just > > > click watch on repos they want emails from, setup mail filters and go > > from > > > there. No need for commit emails to be sent to dev. > > > > > > I could just as easily update my mail filters to move the git emails > > being > > > sent to dev into a different directory. > > > > > > Thoughts? > > > > > >
Re: git commits being sent to dev
I agree, don't send commit's do the dev list. Simon Mac Donald http://simonmacdonald.com On Tue, Aug 8, 2017 at 1:54 PM, Joe Bowserwrote: > I'm already filtering all that stuff since I'm already getting it. In > fact, this is why I didn't see the Github invite. > > But yeah, we should not have the commit e-mails go to the dev mailing list, > since it'll just spam everyone. It'd be good if more people would use the > list to talk about proposals, or at least link to the proposal on GitHub, > since it's not the Apache way to do stuff outside of the mailing list. > > (Yeah, I'm being serious about the mailing list and the Apache way. We > should use the dev list for discussion more.) > > On Tue, Aug 8, 2017 at 10:39 AM, Steven Gill > wrote: > > > Hey! > > > > How do people feel about these git commit emails being sent to dev > mailing > > list. This is only happening to repos that have fully switched over to > > github (gitbox setup). > > > > Personally, I am already watching the repos so I get the emails. I don't > > need the emails to come to dev. I think it would be better people just > > click watch on repos they want emails from, setup mail filters and go > from > > there. No need for commit emails to be sent to dev. > > > > I could just as easily update my mail filters to move the git emails > being > > sent to dev into a different directory. > > > > Thoughts? > > >
Re: git commits being sent to dev
I'm already filtering all that stuff since I'm already getting it. In fact, this is why I didn't see the Github invite. But yeah, we should not have the commit e-mails go to the dev mailing list, since it'll just spam everyone. It'd be good if more people would use the list to talk about proposals, or at least link to the proposal on GitHub, since it's not the Apache way to do stuff outside of the mailing list. (Yeah, I'm being serious about the mailing list and the Apache way. We should use the dev list for discussion more.) On Tue, Aug 8, 2017 at 10:39 AM, Steven Gillwrote: > Hey! > > How do people feel about these git commit emails being sent to dev mailing > list. This is only happening to repos that have fully switched over to > github (gitbox setup). > > Personally, I am already watching the repos so I get the emails. I don't > need the emails to come to dev. I think it would be better people just > click watch on repos they want emails from, setup mail filters and go from > there. No need for commit emails to be sent to dev. > > I could just as easily update my mail filters to move the git emails being > sent to dev into a different directory. > > Thoughts? >
git commits being sent to dev
Hey! How do people feel about these git commit emails being sent to dev mailing list. This is only happening to repos that have fully switched over to github (gitbox setup). Personally, I am already watching the repos so I get the emails. I don't need the emails to come to dev. I think it would be better people just click watch on repos they want emails from, setup mail filters and go from there. No need for commit emails to be sent to dev. I could just as easily update my mail filters to move the git emails being sent to dev into a different directory. Thoughts?
[GitHub] codecov-io commented on issue #329: CB-13112 - should not create a new file reference on each "cordova prepare"
codecov-io commented on issue #329: CB-13112 - should not create a new file reference on each "cordova prepare" URL: https://github.com/apache/cordova-ios/pull/329#issuecomment-320880876 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/329?src=pr=h1) Report > Merging [#329](https://codecov.io/gh/apache/cordova-ios/pull/329?src=pr=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/8edd13aaee16d6996a4560a74d17798437b42c6f?src=pr=desc) will **decrease** coverage by `0.02%`. > The diff coverage is `100%`. [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-ios/pull/329/graphs/tree.svg?height=150=650=WomDD5jInz=pr)](https://codecov.io/gh/apache/cordova-ios/pull/329?src=pr=tree) ```diff @@Coverage Diff @@ ## master #329 +/- ## == - Coverage 63.97% 63.95% -0.03% == Files 14 14 Lines1674 1673 -1 Branches 277 277 == - Hits 1071 1070 -1 Misses603 603 ``` | [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/329?src=pr=tree) | Coverage ? | | |---|---|---| | [bin/templates/scripts/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-ios/pull/329?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3ByZXBhcmUuanM=) | `84.63% <100%> (-0.04%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/329?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/329?src=pr=footer). Last update [8edd13a...01fcaa4](https://codecov.io/gh/apache/cordova-ios/pull/329?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] codecov-io commented on issue #329: CB-13112 - should not create a new file reference on each "cordova prepare"
codecov-io commented on issue #329: CB-13112 - should not create a new file reference on each "cordova prepare" URL: https://github.com/apache/cordova-ios/pull/329#issuecomment-320880876 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/329?src=pr=h1) Report > Merging [#329](https://codecov.io/gh/apache/cordova-ios/pull/329?src=pr=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/8edd13aaee16d6996a4560a74d17798437b42c6f?src=pr=desc) will **decrease** coverage by `0.02%`. > The diff coverage is `100%`. [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-ios/pull/329/graphs/tree.svg?width=650=150=pr=WomDD5jInz)](https://codecov.io/gh/apache/cordova-ios/pull/329?src=pr=tree) ```diff @@Coverage Diff @@ ## master #329 +/- ## == - Coverage 63.97% 63.95% -0.03% == Files 14 14 Lines1674 1673 -1 Branches 277 277 == - Hits 1071 1070 -1 Misses603 603 ``` | [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/329?src=pr=tree) | Coverage ? | | |---|---|---| | [bin/templates/scripts/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-ios/pull/329?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3ByZXBhcmUuanM=) | `84.63% <100%> (-0.04%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/329?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/329?src=pr=footer). Last update [8edd13a...01fcaa4](https://codecov.io/gh/apache/cordova-ios/pull/329?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] shazron opened a new pull request #329: CB-13112 - should not create a new file reference on each "cordova prepare"
shazron opened a new pull request #329: CB-13112 - should not create a new file reference on each "cordova prepare" URL: https://github.com/apache/cordova-ios/pull/329 Added new ios-config-xml project fixture based off cordova-ios@4.4.0 template. The old one doesn't reflect current project structure. prepare.spec.js Added failing test for multiple adds of the same tag Fixed failing test in prepare.js pluginHandlers.spec.js Fix failing test due to new ios-config-xml project template in addPlugin Don't need to prefix 'Resources' and 'Plugins' to the files that are from those groups. The file reference 'sourceTree' relies on its parent group, in the new template structure. ### Platforms affected self ### What does this PR do? Fix multiple file references added for a tag. This creates "cordova build" failures. ### What testing has been done on this change? npm run unit-tests npm test ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org