[GitHub] cordova-js issue #146: CB-13163: fix using relative paths in calls to requir...

[stevengill]

Github user stevengill commented on the issue:

https://github.com/apache/cordova-js/pull/146
  
I had to revert this as it broke all of our plugins that use local require 
syntax (ex. cordova device-motion at 
https://github.com/apache/cordova-plugin-device-motion/blob/master/www/accelerometer.js#L29)

cordova's require handles local require very differently than node's local 
require.

Cordova require would convert `require('./Acceleration')` into 
`cordova-plugin-device-motion.Acceleration`. Then is uses some sort of mapping 
to grab and include the code (I haven't dug into it)

This PR wants `require(./logger)` to become 
`require('cordova/plugin/ios/logger')` instead of 
`cordova-plugin-console.logger`. (Once again, I haven't dug into why the 
mapping isn't working now that the plugin is local. I think it is because the 
console plugin code is baked into cordova.js instead of being included during 
runtime like plugin js code).

Instead of this PR, I'm going to fix the require call at 
https://github.com/apache/cordova-ios/blob/master/cordova-js-src/plugin/ios/console.js#L24.

It will change from `require('./logger')` into 
`require('cordova/plugin/ios/logger')`. Now the local require is working for 
logger and cordova's local require continues working as it has been for the 
last few years.

Ultimately, cordova.js & how we load plugins needs to rethought and 
refactored. 






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-osx pull request #40: Update project.pbxproj

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-osx/pull/40


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-js issue #146: CB-13163: fix using relative paths in calls to requir...

[purplecabbage]

Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-js/pull/146
  
This broke other stuff :(
cordova-browser cannot install cordova-plugin-device-motion fails, for 
example.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen issue #125: CB-12626: (android) Fix crash on Sam...

[uj]

Github user uj commented on the issue:

https://github.com/apache/cordova-plugin-splashscreen/pull/125
  
@Lazza Ok, i just tried your fix, and it crashes less often, but not 100% 
crash-free.  However, this mostly happens when using the back-button to "exit" 
the program.  There is a separate Android bug on some devices where exiting 
with the back button causes the app to relaunch instead of sleep/resume even 
though the app is still running, and that *might* be part of the crashing 
problem, I don't know.  Note that when I do not use either of the splashscreen 
plugins at all, it NEVER crashes no matter what.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen issue #125: CB-12626: (android) Fix crash on Sam...

[Lazza]

Github user Lazza commented on the issue:

https://github.com/apache/cordova-plugin-splashscreen/pull/125
  
@uj does my fix work on that device as well?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen issue #125: CB-12626: (android) Fix crash on Sam...

[uj]

Github user uj commented on the issue:

https://github.com/apache/cordova-plugin-splashscreen/pull/125
  
Will this fix be added to the official apache version?  I can confirm that 
cordova-plugin-splashscreen crashes Morotola X Gen 3, Android 6, not just 
Samsung devices.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] cordova-ios 4.1.1 Release

[Shazron]

Issues on the board have been completed, the PRs need review:

Board:
https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=173

Pull requests:
1. https://github.com/apache/cordova-ios/pull/326
2. https://github.com/apache/cordova-ios/pull/331
3. https://github.com/apache/cordova-ios/pull/332


On Tue, Aug 22, 2017 at 6:00 PM, Shazron  wrote:

> Renamed board to 4.5.0, left Fil's issue and another that has a PR that is
> almost done review:
> https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=173
>
> On Tue, Aug 22, 2017 at 11:47 AM, Shazron  wrote:
>
>> I'll get that in as the lone issue on the board.
>> I'm also thinking this should be 4.5.0 instead of 4.4.1 because there is
>> a new feature in there.
>>
>> On Tue, Aug 22, 2017 at 9:20 AM, Filip Maj  wrote:
>>
>>> CB-12830 [1] is something that I think we should sneak in to the
>>> release, time permitting.
>>>
>>> [1] https://issues.apache.org/jira/browse/CB-12830
>>>
>>> On Sat, Aug 12, 2017 at 4:05 AM, Shazron  wrote:
>>> >  I do! yes 4.4.1
>>> >
>>> > On Aug 11, 2017 at 5:40 PM, julio cesar sanchez <
>>> jcesarmob...@gmail.com>
>>> > wrote:
>>> >
>>> >
>>> > You probably mean 4.4.1
>>> >
>>> > El 11 ago. 2017 3:37 p. m., "Steven Gill" 
>>> escribió:
>>> >
>>> > Yay!
>>> >
>>> > On Aug 11, 2017 12:19 PM, "Shazron"  wrote:
>>> >
>>> > Long overdue.
>>> >
>>> > The board is here:
>>> > https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=173
>>> >
>>> > Any issues in the left column that absolutely need to go in? If not I
>>> >
>>> > will
>>> >
>>> > punt them to the next release.
>>>
>>> -
>>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>>> For additional commands, e-mail: dev-h...@cordova.apache.org
>>>
>>>
>>
>

[GitHub] cordova-plugin-wkwebview-engine issue #15: Ionic changes to WKWebView (For C...

[timbru31]

Github user timbru31 commented on the issue:

https://github.com/apache/cordova-plugin-wkwebview-engine/pull/15
  
Sorry for the revive/bump but has there been any dialogue recently to merge 
the Ionic changes back into the upstream Apache project? They are drifting more 
and more apart...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[DISCUSS] Cordova-serve@2 release

[Steven Gill]

This release is needed for the browser platform release.

Some notable changes:
* Removed Q dependency in favor of native javascript promises.
* Changed default behavior of which browser is launched during serve. Now
the serve command will use the system default browser instead of opening a
new instance of chrome. You can still pass in a specific target (like
chrome) though [1].

I'm doing this release alongside the browser@5 release.

Release Issue: https://issues.apache.org/jira/browse/CB-13214

[1] https://github.com/apache/cordova-serve#launchbrowser

[GitHub] cordova-lib pull request #590: CB-13145: Create playservices version prefere...

[audreyso]

GitHub user audreyso opened a pull request:

https://github.com/apache/cordova-lib/pull/590

CB-13145: Create playservices version preference in config.xml  

Still need to add in tests


### Platforms affected


### What does this PR do?
CB-13145: Create playservices version preference in config.xml

### What testing has been done on this change?


### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/audreyso/cordova-lib CB-13145-Steve

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/590.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #590


commit 315e6a80b95a425a07a0a32e53e24ce10e1ef89c
Author: Steve Gill 
Date:   2017-08-23T04:39:24Z

CB-13145: pass full options to plugman uninstall

commit faa48e255fc02dd42f2bcc7eaa43f816967305cb
Author: Audrey So 
Date:   2017-08-23T20:27:45Z

CB-13145 : added variable-merge.js to deal with plugin.xml variables for 
uninstall




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-osx pull request #40: Update project.pbxproj

[bookrides]

GitHub user bookrides opened a pull request:

https://github.com/apache/cordova-osx/pull/40

Update project.pbxproj

Xcode 7.2: In “Archive”: Getting the issue: 
“Cordova/CDVViewController.h’ file not found ”. While there is no such 
issues in building the app. Adding this line fixes it



### Platforms affected
OSX

### What does this PR do?
Fixes it

### What testing has been done on this change?
Only my own testing

### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bookrides/cordova-osx patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-osx/pull/40.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #40


commit 49bc673b47f0b4d08cfa7efc79565ce5c59603ed
Author: bookrides 
Date:   2017-08-24T15:24:11Z

Update project.pbxproj

Xcode 7.2: In “Archive”: Getting the issue: 
“Cordova/CDVViewController.h’ file not found ”. While there is no such 
issues in building the app. Adding this line fixes it




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org