Nightly build #486 for cordova has succeeded!

[Apache Jenkins Server]

Nightly build #486 for cordova has succeeded!
The latest nightly has been published and you can try it out with 'npm i -g 
cordova@nightly'

For details check build console at 
https://builds.apache.org/job/cordova-nightly/486/consoleFull

-
Jenkins for Apache Cordova

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Cordova iOS 4.5.1 release

[Simon MacDonald]

Nope because compat only has Android code.


Simon Mac Donald
http://simonmacdonald.com

On Fri, Sep 15, 2017 at 7:55 PM, Joe Bowser  wrote:

> Is the iOS release blocked by the plugin release that is currently blocking
> Android?
>
> On Fri, Sep 15, 2017 at 4:54 PM, Mike Hartington  >
> wrote:
>
> > Regarding the Viewport and iPhoneX notch, I sent this earlier today.
> >
> > https://github.com/apache/cordova-plugin-statusbar/pull/85 <
> > https://github.com/apache/cordova-plugin-statusbar/pull/85>
> >
> >
> > > On Sep 15, 2017, at 7:36 PM, Shazron  wrote:
> > >
> > > We need a 4.5.1 release soon to address iOS 11 issues.
> > >
> > > Here’s the things that are pending or have been fixed:
> > >
> > > - cordova-ios@4.5.0 has been released which fixes a bunch of things.
> > Now of
> > > course, we need to have a cordova-ios@4.5.1 release because of the
> other
> > > points below…
> > >
> > > - ios-sim is broken, it doesn’t list the new 2017 iPhones. Apple
> released
> > > Xcode 9 with a buggy listing of devices using `xcrun simctl` (i.e.
> > listing
> > > iPhone 8 as iPhone2017-A for example) so we can’t list them properly. I
> > > have fixed this with a workaround:
> > > https://github.com/phonegap/ios-sim/issues/218 and
> > > https://github.com/phonegap/ios-sim/issues/219 - This new ios-sim when
> > > released needs to go in a new cordova-ios release asap
> > >
> > > - simctl is broken, it doesn’t launch the Simulator (so `cordova
> emulate
> > > ios` is affected). I have filed issues:
> > > https://github.com/phonegap/ios-sim/issues/209 and
> > > https://github.com/phonegap/simctl/issues/14 . Of course I will have
> to
> > > work on those, and no surprise Apple changed things again… This will go
> > in
> > > the new ios-sim which in turn will go in the new cordova-ios
> > >
> > > - Viewport and iPhone X notch issues – with the help of the community.
> > Need
> > > to be addressed properly (blog post only?). Summarized by Darryl Pogue:
> > >- status bar plugin -- Has a PR to use the safeArea height instead
> of
> > > 20px
> > >- iPhone X letterboxing -- Requires the use of LaunchStoryboards,
> not
> > > really a "bug"
> > >- viewport-fit stuff -- Up to the HTML author, not really a "bug",
> and
> > > a few blogs posts about it
> > >
> > > - ios-deploy couldn’t compile under Xcode 9. Apple either prevents or
> > had a
> > > bug where it couldn’t link to Private Frameworks. Workaround added:
> > > https://github.com/phonegap/ios-deploy/issues/308 . This should have
> > been
> > > in 4.5.0 already
> >
> >
>

Re: [DISCUSS] Cordova iOS 4.5.1 release

[Joe Bowser]

Is the iOS release blocked by the plugin release that is currently blocking
Android?

On Fri, Sep 15, 2017 at 4:54 PM, Mike Hartington 
wrote:

> Regarding the Viewport and iPhoneX notch, I sent this earlier today.
>
> https://github.com/apache/cordova-plugin-statusbar/pull/85 <
> https://github.com/apache/cordova-plugin-statusbar/pull/85>
>
>
> > On Sep 15, 2017, at 7:36 PM, Shazron  wrote:
> >
> > We need a 4.5.1 release soon to address iOS 11 issues.
> >
> > Here’s the things that are pending or have been fixed:
> >
> > - cordova-ios@4.5.0 has been released which fixes a bunch of things.
> Now of
> > course, we need to have a cordova-ios@4.5.1 release because of the other
> > points below…
> >
> > - ios-sim is broken, it doesn’t list the new 2017 iPhones. Apple released
> > Xcode 9 with a buggy listing of devices using `xcrun simctl` (i.e.
> listing
> > iPhone 8 as iPhone2017-A for example) so we can’t list them properly. I
> > have fixed this with a workaround:
> > https://github.com/phonegap/ios-sim/issues/218 and
> > https://github.com/phonegap/ios-sim/issues/219 - This new ios-sim when
> > released needs to go in a new cordova-ios release asap
> >
> > - simctl is broken, it doesn’t launch the Simulator (so `cordova emulate
> > ios` is affected). I have filed issues:
> > https://github.com/phonegap/ios-sim/issues/209 and
> > https://github.com/phonegap/simctl/issues/14 . Of course I will have to
> > work on those, and no surprise Apple changed things again… This will go
> in
> > the new ios-sim which in turn will go in the new cordova-ios
> >
> > - Viewport and iPhone X notch issues – with the help of the community.
> Need
> > to be addressed properly (blog post only?). Summarized by Darryl Pogue:
> >- status bar plugin -- Has a PR to use the safeArea height instead of
> > 20px
> >- iPhone X letterboxing -- Requires the use of LaunchStoryboards, not
> > really a "bug"
> >- viewport-fit stuff -- Up to the HTML author, not really a "bug", and
> > a few blogs posts about it
> >
> > - ios-deploy couldn’t compile under Xcode 9. Apple either prevents or
> had a
> > bug where it couldn’t link to Private Frameworks. Workaround added:
> > https://github.com/phonegap/ios-deploy/issues/308 . This should have
> been
> > in 4.5.0 already
>
>

Re: [DISCUSS] Cordova iOS 4.5.1 release

[Mike Hartington]

Regarding the Viewport and iPhoneX notch, I sent this earlier today.

https://github.com/apache/cordova-plugin-statusbar/pull/85 



> On Sep 15, 2017, at 7:36 PM, Shazron  wrote:
> 
> We need a 4.5.1 release soon to address iOS 11 issues.
> 
> Here’s the things that are pending or have been fixed:
> 
> - cordova-ios@4.5.0 has been released which fixes a bunch of things. Now of
> course, we need to have a cordova-ios@4.5.1 release because of the other
> points below…
> 
> - ios-sim is broken, it doesn’t list the new 2017 iPhones. Apple released
> Xcode 9 with a buggy listing of devices using `xcrun simctl` (i.e. listing
> iPhone 8 as iPhone2017-A for example) so we can’t list them properly. I
> have fixed this with a workaround:
> https://github.com/phonegap/ios-sim/issues/218 and
> https://github.com/phonegap/ios-sim/issues/219 - This new ios-sim when
> released needs to go in a new cordova-ios release asap
> 
> - simctl is broken, it doesn’t launch the Simulator (so `cordova emulate
> ios` is affected). I have filed issues:
> https://github.com/phonegap/ios-sim/issues/209 and
> https://github.com/phonegap/simctl/issues/14 . Of course I will have to
> work on those, and no surprise Apple changed things again… This will go in
> the new ios-sim which in turn will go in the new cordova-ios
> 
> - Viewport and iPhone X notch issues – with the help of the community. Need
> to be addressed properly (blog post only?). Summarized by Darryl Pogue:
>- status bar plugin -- Has a PR to use the safeArea height instead of
> 20px
>- iPhone X letterboxing -- Requires the use of LaunchStoryboards, not
> really a "bug"
>- viewport-fit stuff -- Up to the HTML author, not really a "bug", and
> a few blogs posts about it
> 
> - ios-deploy couldn’t compile under Xcode 9. Apple either prevents or had a
> bug where it couldn’t link to Private Frameworks. Workaround added:
> https://github.com/phonegap/ios-deploy/issues/308 . This should have been
> in 4.5.0 already

[GitHub] cordova-plugin-console pull request #25: CB-13170 - final changes and releas...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-console/pull/25


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-console issue #25: CB-13170 - final changes and release of po...

[shazron]

Github user shazron commented on the issue:

https://github.com/apache/cordova-plugin-console/pull/25
  
thanks @alsorokin !


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[DISCUSS] Cordova iOS 4.5.1 release

[Shazron]

We need a 4.5.1 release soon to address iOS 11 issues.

Here’s the things that are pending or have been fixed:

- cordova-ios@4.5.0 has been released which fixes a bunch of things. Now of
course, we need to have a cordova-ios@4.5.1 release because of the other
points below…

- ios-sim is broken, it doesn’t list the new 2017 iPhones. Apple released
Xcode 9 with a buggy listing of devices using `xcrun simctl` (i.e. listing
iPhone 8 as iPhone2017-A for example) so we can’t list them properly. I
have fixed this with a workaround:
https://github.com/phonegap/ios-sim/issues/218 and
https://github.com/phonegap/ios-sim/issues/219 - This new ios-sim when
released needs to go in a new cordova-ios release asap

- simctl is broken, it doesn’t launch the Simulator (so `cordova emulate
ios` is affected). I have filed issues:
https://github.com/phonegap/ios-sim/issues/209 and
https://github.com/phonegap/simctl/issues/14 . Of course I will have to
work on those, and no surprise Apple changed things again… This will go in
the new ios-sim which in turn will go in the new cordova-ios

- Viewport and iPhone X notch issues – with the help of the community. Need
to be addressed properly (blog post only?). Summarized by Darryl Pogue:
- status bar plugin -- Has a PR to use the safeArea height instead of
20px
- iPhone X letterboxing -- Requires the use of LaunchStoryboards, not
really a "bug"
- viewport-fit stuff -- Up to the HTML author, not really a "bug", and
a few blogs posts about it

- ios-deploy couldn’t compile under Xcode 9. Apple either prevents or had a
bug where it couldn’t link to Private Frameworks. Workaround added:
https://github.com/phonegap/ios-deploy/issues/308 . This should have been
in 4.5.0 already

[GitHub] cordova-lib pull request #594: CB-13288 : updated index.js and test to fix c...

[audreyso]

GitHub user audreyso opened a pull request:

https://github.com/apache/cordova-lib/pull/594

CB-13288 : updated index.js and test to fix cordova plugin search



### Platforms affected


### What does this PR do?

Updated index.js and test to fix cordova plugin search

### What testing has been done on this change?


### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/audreyso/cordova-lib CB-13288

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/594.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #594


commit e50c9b60e45cdc033d68bce62a2af894da0e1b61
Author: Audrey So 
Date:   2017-09-15T20:34:44Z

CB-13288 : updated index.js and test to fix cordova plugin search




---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #592: CB-12361 : added some unit tests for plugman

[audreyso]

Github user audreyso closed the pull request at:

https://github.com/apache/cordova-lib/pull/592


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #593: CB-12361 : added plugin unit tests for plugin...

[audreyso]

GitHub user audreyso opened a pull request:

https://github.com/apache/cordova-lib/pull/593

CB-12361 : added plugin unit tests for plugin list



### Platforms affected


### What does this PR do?
Added plugin unit tests for plugin list

### What testing has been done on this change?


### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/audreyso/cordova-lib CB-12361-list_spec

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/593.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #593


commit e956fe7c8d0cbd8c7663bed4e66d5b1f78411e68
Author: Audrey So 
Date:   2017-09-15T16:32:55Z

CB-12361 : added plugin tests for plugin list




---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-statusbar pull request #85: CB-13273: fix statusbar spacing w...

[mhartington]

GitHub user mhartington opened a pull request:

https://github.com/apache/cordova-plugin-statusbar/pull/85

CB-13273: fix statusbar spacing with new iphoneX


### Platforms affected
iOS

### What does this PR do?
Adds additional check for iOS11/iPhone X and the new statusbar size

### What testing has been done on this change?
Manual testing on devices and simulators.


Note: I messed on the commit message format, tagged the wrong jira issue.
But there is an issue for this.
https://issues.apache.org/jira/browse/CB-13273

### Checklist
- [ x] [Reported an 
issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [ x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mhartington/cordova-plugin-statusbar 
CB-12886cordova-plugin-statusbar

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-statusbar/pull/85.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #85


commit f4dbcc2d61c01c2766afdc5e40d1c47226a04f5d
Author: mhartington 
Date:   2017-09-15T13:50:42Z

CB-12886: fix statusbar spacing with new iphoneX




---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org