Re: Cordova roadmap - native UI

2017-10-25 Thread Shazron
Hi Nick,
Unfortunately including native UI is incongruent to our project philosophy
of creating "mobile apps with HTML, CSS & JS". We try to follow web
standards when possible and not resort to native ui unless we need to fix
some deficiencies that can't be avoided (statusbar for example).

Even if we wanted to (as plugins), we can't, because we don't have the
resources.



On Tue, Oct 24, 2017 at 6:51 PM, Nick de la Hunt 
wrote:

> Hi there,
>
> Apologies, I'm not sure if this is the correct address to send this query.
>
> I'd like to know if you guys are planning on enabling a capability to
> include native UI in Corova projects, such as the Microsoft Project Ace
> plugin  for example. I feel that if you guys include such a plugin that
> allows us to build with either a native UI, or a web view, or both (such as
> Ace), you'd be leaps and bounds ahead of projects such as Nativescript and
> React Native, given your already-wide list of native capabilities, as well
> as the fact that you have users constantly building your ecosystem so much
> wider! :)
>
> I love building with Cordova and would be very sad to move away, but I have
> the need these days to include some native UI (tabs and drawers and buttons
> and controls etc...) in my apps, just to give the native feel, without
> updating CSS all the time. I would love it if you guys would include
> something like that, even if they are just plugins, but I would want them
> built by you as the native UI plugins currently out there developed by
> third parties are not really any good, and Project Ace has been
> discontinued, sadly. I would hope for something similar to Ace, but not
> using XAML which requires Visual Studio compilation before phonegap build
> or Cordova CLI creation - makes building for both iOS and Windows and
> Android very difficult from one machine.
>
> I know I may be shooting in the dark here or pushing my luck, but please
> would you mind looking into it? I know there are MANY other devs out there
> wishing for the same thing - just look at the amounts of queries regarding
> Native UI for Cordova on Stack Overflow, Ace's git repo etc...
>
> Really hoping for favourable (yes, that's how we spell it in South Africa
> :-D) response :)
>
> Cheers!
>
> Nick
>
>
>
> --
> Regards,
>
> Nick de la Hunt
> 082 388 1831
> nick.delah...@gmail.com
>


[GitHub] cordova-lib pull request #602: CB-12774 : Don't munge scoped plugin IDs anym...

2017-10-25 Thread audreyso
Github user audreyso commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/602#discussion_r147014589
  
--- Diff: src/cordova/util.js ---
@@ -255,11 +255,20 @@ function findPlugins (pluginDir) {
 var plugins = [];
 
 if (fs.existsSync(pluginDir)) {
-plugins = fs.readdirSync(pluginDir).filter(function (fileName) {
-var pluginPath = path.join(pluginDir, fileName);
-var isPlugin = isDirectory(pluginPath) || 
isSymbolicLink(pluginPath);
-return fileName !== '.svn' && fileName !== 'CVS' && isPlugin;
-});
+plugins = fs.readdirSync(pluginDir)
+.reduce(function (plugins, pluginOrScope) {
+if (pluginOrScope[0] === '@') {
+plugins.push(...fs.readdirSync(path.join(pluginDir, 
pluginOrScope)).map(s => path.join(pluginOrScope, s)));
--- End diff --

Thanks for your question! We are sticking to the current style for now. We 
need to have a discussion on our mailing list about starting to use es2015 
features/ which ones to use and get some consensus.


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-lib pull request #602: CB-12774 : Don't munge scoped plugin IDs anym...

2017-10-25 Thread akdor1154
Github user akdor1154 commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/602#discussion_r147012928
  
--- Diff: src/cordova/util.js ---
@@ -255,11 +255,20 @@ function findPlugins (pluginDir) {
 var plugins = [];
 
 if (fs.existsSync(pluginDir)) {
-plugins = fs.readdirSync(pluginDir).filter(function (fileName) {
-var pluginPath = path.join(pluginDir, fileName);
-var isPlugin = isDirectory(pluginPath) || 
isSymbolicLink(pluginPath);
-return fileName !== '.svn' && fileName !== 'CVS' && isPlugin;
-});
+plugins = fs.readdirSync(pluginDir)
+.reduce(function (plugins, pluginOrScope) {
+if (pluginOrScope[0] === '@') {
+plugins.push(...fs.readdirSync(path.join(pluginDir, 
pluginOrScope)).map(s => path.join(pluginOrScope, s)));
--- End diff --

yup just started looking at the failed test :) While you're here and kind 
of related, I noticed most of the Cordova codebase avoids `() => arrow 
functions`. Is this just historical? I have used full `function () { }` when 
I've paid attention just to match code style, but is this necessary?


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-lib pull request #602: CB-12774 : Don't munge scoped plugin IDs anym...

2017-10-25 Thread audreyso
Github user audreyso commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/602#discussion_r147012615
  
--- Diff: src/cordova/util.js ---
@@ -255,11 +255,20 @@ function findPlugins (pluginDir) {
 var plugins = [];
 
 if (fs.existsSync(pluginDir)) {
-plugins = fs.readdirSync(pluginDir).filter(function (fileName) {
-var pluginPath = path.join(pluginDir, fileName);
-var isPlugin = isDirectory(pluginPath) || 
isSymbolicLink(pluginPath);
-return fileName !== '.svn' && fileName !== 'CVS' && isPlugin;
-});
+plugins = fs.readdirSync(pluginDir)
+.reduce(function (plugins, pluginOrScope) {
+if (pluginOrScope[0] === '@') {
+plugins.push(...fs.readdirSync(path.join(pluginDir, 
pluginOrScope)).map(s => path.join(pluginOrScope, s)));
--- End diff --

Hi! This line will need to be changed as it will not work with Node 4, 
which is still currently supported. 
http://node.green/#ES2015-syntax-spread---operator-with-generic-iterables--in-calls


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[VOTE] 4.5.3 iOS Release

2017-10-25 Thread Suraj Pindoria
Please review and vote on this 4.5.3 iOS Release by replying to this email
(and keep discussion on the DISCUSS thread)

Release issue: https://issues.apache.org/jira/browse/CB-13493

The archive has been published to dist/dev:
https://dist.apache.org/repos/dist/dev/cordova/CB-13493

The package was published from its corresponding git tag:
 cordova-ios: 4.5.3 (ce2ab968e7)

Note that you can test it out via:

 cordova platform add https://github.com/apache/cordova-ios#4.5.3

Upon a successful vote I will upload the archive to dist/, publish it to
npm, and post the blog post.

Voting guidelines:
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers
* Ran coho check-license
* Ensured continuous build was green when repo was tagged
* Created and tested against mobilespec
* Created helloworld using CLI and build scripts, deployed to
device/emulator


[GitHub] cordova-lib pull request #599: CB-13463 : prevent package.json update with -...

2017-10-25 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/599


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-lib issue #599: CB-13463 : prevent package.json update with --nosave...

2017-10-25 Thread stevengill
Github user stevengill commented on the issue:

https://github.com/apache/cordova-lib/pull/599
  
merge!


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-lib issue #599: CB-13463 : prevent package.json update with --nosave...

2017-10-25 Thread audreyso
Github user audreyso commented on the issue:

https://github.com/apache/cordova-lib/pull/599
  
@stevengill CI is passing now. Let me know if I should merge it in!


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org