Re: [DISCUSS] Splashscreen Plugin Release 5.0.4

2020-06-03 Thread Norman Breau
We probably should resolve the travis issue, just to be sure it isn't 
hiding some other error.


ld: warning: ignoring file /tmp/libCordova.a, file was built for archive 
which is not the architecture being linked (i386): /tmp/libCordova.a

658Undefined symbols for architecture i386:
659"_OBJC_CLASS_$_CDVPlugin", referenced from:
660_OBJC_CLASS_$_CDVSplashScreen in 
libCDVSplashScreenLib.a(CDVSplashScreen.o)

661"_CDVPageDidLoadNotification", referenced from:
662-[CDVSplashScreen pluginInitialize] in 
libCDVSplashScreenLib.a(CDVSplashScreen.o)

663"_OBJC_METACLASS_$_CDVPlugin", referenced from:
664_OBJC_METACLASS_$_CDVSplashScreen in 
libCDVSplashScreenLib.a(CDVSplashScreen.o)

665ld: symbol(s) not found for architecture i386
666clang: error: linker command failed with exit code 1 (use -v to see 
invocation)




Unfortunately I'm not very well knowledgeable on iOS development, but it 
does seem some kind of configuration issue.


On 2020-06-03 2:28 p.m., Niklas Merz wrote:

Seems like we are good to go for this plugin. I will start the release now!

Am 02.06.20 um 20:39 schrieb Niklas Merz:

Hi all,

Since cordova-ios 6.0, which includes a splashscreen implementation, was 
released recently, we should release a patch version of the splashscreen plugin 
which sets the version requirements correctly [1].

Does anyone have any reason to delay this patch release?
Any outstanding patches to land?

If not, I will start the release tomorrow.

After this patch release we will introduce some some breaking changes including 
the removal of iOS code in a major release after that. The PRs are already open.

[1] https://github.com/apache/cordova-plugin-splashscreen/pull/261

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: Strongly deprecating the FileTransfer plugin

2020-06-03 Thread julio cesar sanchez
I think people knew they were leaving the project and voted to deprecate
plugins to leave less things to maintain to the few remaining people.

Since there are new committers now that didn’t vote, maybe we can
reconsider/re vote.



El miércoles, 3 de junio de 2020, Darryl Pogue 
escribió:

> Not that we want to outright endorse 3rd party plugins without due
> diligence, but there are other options than the FileTransfer plugin, such
> as https://www.npmjs.com/package/cordova-plugin-advanced-http
>
> On Wed, Jun 3, 2020 at 1:46 PM Tim Brust  wrote:
>
> > While I agree that we should somehow archive old code, I'm still -1 on a
> > deprecation of this plugin. (We've had some discussion about it here,
> too:
> > https://github.com/apache/cordova/issues/185)
> > XHR is not reliable and causes OOM errors when handling large data.
> >
> >
> >
> > On Wed, Jun 3, 2020 at 7:29 PM Norman Breau 
> > wrote:
> >
> > > +1 on archiving/adding  [DEPRECATED] text in the description.
> > >
> > > On 2020-06-03 4:25 p.m., julio cesar sanchez wrote:
> > > > This happens with all the deprecated plugins we have, people keeps
> > > > reporting issues on them.
> > > > I proposed long ago to archive them, but some people was against it,
> > but
> > > I
> > > > think archiving is the way to go when something is deprecated.
> > > >
> > > >
> > > > El miércoles, 3 de junio de 2020, Jesse 
> > > escribió:
> > > >
> > > >> +1 The deprecation notice needs to be prominent, I missed it myself
> > on a
> > > >> quick scroll.
> > > >> Some of that readme is in a specific format to support appearance in
> > > >> docs.cordova.io ( similar to
> > > >> https://cordova.apache.org/docs/en/latest/reference/
> > > >> cordova-plugin-file/index.html
> > > >>   )
> > > >> This is no longer a requirement, so we can go prominent.
> > > >> We should also ask INFRA to put the text [DEPRECATED] in the
> > > description,
> > > >> and possibly even archive the repo.
> > > >>
> > > >>
> > > >> On Wed, Jun 3, 2020 at 12:02 PM Norman Breau <
> nor...@normanbreau.com>
> > > >> wrote:
> > > >>
> > > >>> I'm sure you're not the only one who misses it, considering the
> repo
> > is
> > > >>> still pretty active in terms of new issues being reported.
> > > >>>
> > > >>> On 2020-06-03 3:59 p.m., Darryl Pogue wrote:
> > >  Correction: There is in fact a deprecation notice, part-way down
> the
> > >  README, but it's not especially attention grabbing and I missed it
> > the
> > >  first 2 times I skimmed the file.
> > > 
> > >  On Wed, Jun 3, 2020 at 11:55 AM Darryl Pogue 
> > > wrote:
> > > 
> > > > Hey folks,
> > > >
> > > > The File Transfer plugin has been officially deprecated since
> 2017:
> > > >
> > > >>> https://cordova.apache.org/blog/2017/10/18/from-
> > > >> filetransfer-to-xhr2.html
> > > > However, the repo and npm have no link to that page or any sort
> of
> > > > indication that it is not maintained.
> > > >
> > > > With the release of cordova-ios 6, the FileTransfer plugin no
> > longer
> > > > compiles on iOS:
> > > > https://github.com/apache/cordova-plugin-file-transfer/
> issues/258
> > > >
> > > > I want to reply to that issue saying that it's deprecated and not
> > > > maintained, but I feel like we haven't made that very clear.
> > > >
> > > > I would like to propose that we update the README for File
> Transfer
> > > >>> with a
> > > > clear deprecation notice which links to the blog post from 2017,
> > and
> > > >>> that
> > > > we ask ASF Infra to mark the repo as archived.
> > > >
> > > > Any objections?
> > > >
> > > > ~Darryl
> > > >
> > > >>> 
> -
> > > >>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > > >>> For additional commands, e-mail: dev-h...@cordova.apache.org
> > > >>>
> > > >>>
> > >
> > > -
> > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > > For additional commands, e-mail: dev-h...@cordova.apache.org
> > >
> > >
> >
> > --
> > Tim Brust
> > timbrust3...@gmail.com
> >
> > M: +49 160 9757 3632 <+4916097573632>
> >
>


Re: Strongly deprecating the FileTransfer plugin

2020-06-03 Thread Darryl Pogue
Not that we want to outright endorse 3rd party plugins without due
diligence, but there are other options than the FileTransfer plugin, such
as https://www.npmjs.com/package/cordova-plugin-advanced-http

On Wed, Jun 3, 2020 at 1:46 PM Tim Brust  wrote:

> While I agree that we should somehow archive old code, I'm still -1 on a
> deprecation of this plugin. (We've had some discussion about it here, too:
> https://github.com/apache/cordova/issues/185)
> XHR is not reliable and causes OOM errors when handling large data.
>
>
>
> On Wed, Jun 3, 2020 at 7:29 PM Norman Breau 
> wrote:
>
> > +1 on archiving/adding  [DEPRECATED] text in the description.
> >
> > On 2020-06-03 4:25 p.m., julio cesar sanchez wrote:
> > > This happens with all the deprecated plugins we have, people keeps
> > > reporting issues on them.
> > > I proposed long ago to archive them, but some people was against it,
> but
> > I
> > > think archiving is the way to go when something is deprecated.
> > >
> > >
> > > El miércoles, 3 de junio de 2020, Jesse 
> > escribió:
> > >
> > >> +1 The deprecation notice needs to be prominent, I missed it myself
> on a
> > >> quick scroll.
> > >> Some of that readme is in a specific format to support appearance in
> > >> docs.cordova.io ( similar to
> > >> https://cordova.apache.org/docs/en/latest/reference/
> > >> cordova-plugin-file/index.html
> > >>   )
> > >> This is no longer a requirement, so we can go prominent.
> > >> We should also ask INFRA to put the text [DEPRECATED] in the
> > description,
> > >> and possibly even archive the repo.
> > >>
> > >>
> > >> On Wed, Jun 3, 2020 at 12:02 PM Norman Breau 
> > >> wrote:
> > >>
> > >>> I'm sure you're not the only one who misses it, considering the repo
> is
> > >>> still pretty active in terms of new issues being reported.
> > >>>
> > >>> On 2020-06-03 3:59 p.m., Darryl Pogue wrote:
> >  Correction: There is in fact a deprecation notice, part-way down the
> >  README, but it's not especially attention grabbing and I missed it
> the
> >  first 2 times I skimmed the file.
> > 
> >  On Wed, Jun 3, 2020 at 11:55 AM Darryl Pogue 
> > wrote:
> > 
> > > Hey folks,
> > >
> > > The File Transfer plugin has been officially deprecated since 2017:
> > >
> > >>> https://cordova.apache.org/blog/2017/10/18/from-
> > >> filetransfer-to-xhr2.html
> > > However, the repo and npm have no link to that page or any sort of
> > > indication that it is not maintained.
> > >
> > > With the release of cordova-ios 6, the FileTransfer plugin no
> longer
> > > compiles on iOS:
> > > https://github.com/apache/cordova-plugin-file-transfer/issues/258
> > >
> > > I want to reply to that issue saying that it's deprecated and not
> > > maintained, but I feel like we haven't made that very clear.
> > >
> > > I would like to propose that we update the README for File Transfer
> > >>> with a
> > > clear deprecation notice which links to the blog post from 2017,
> and
> > >>> that
> > > we ask ASF Infra to mark the repo as archived.
> > >
> > > Any objections?
> > >
> > > ~Darryl
> > >
> > >>> -
> > >>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > >>> For additional commands, e-mail: dev-h...@cordova.apache.org
> > >>>
> > >>>
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
> >
>
> --
> Tim Brust
> timbrust3...@gmail.com
>
> M: +49 160 9757 3632 <+4916097573632>
>


Re: Strongly deprecating the FileTransfer plugin

2020-06-03 Thread Tim Brust
While I agree that we should somehow archive old code, I'm still -1 on a
deprecation of this plugin. (We've had some discussion about it here, too:
https://github.com/apache/cordova/issues/185)
XHR is not reliable and causes OOM errors when handling large data.



On Wed, Jun 3, 2020 at 7:29 PM Norman Breau  wrote:

> +1 on archiving/adding  [DEPRECATED] text in the description.
>
> On 2020-06-03 4:25 p.m., julio cesar sanchez wrote:
> > This happens with all the deprecated plugins we have, people keeps
> > reporting issues on them.
> > I proposed long ago to archive them, but some people was against it, but
> I
> > think archiving is the way to go when something is deprecated.
> >
> >
> > El miércoles, 3 de junio de 2020, Jesse 
> escribió:
> >
> >> +1 The deprecation notice needs to be prominent, I missed it myself on a
> >> quick scroll.
> >> Some of that readme is in a specific format to support appearance in
> >> docs.cordova.io ( similar to
> >> https://cordova.apache.org/docs/en/latest/reference/
> >> cordova-plugin-file/index.html
> >>   )
> >> This is no longer a requirement, so we can go prominent.
> >> We should also ask INFRA to put the text [DEPRECATED] in the
> description,
> >> and possibly even archive the repo.
> >>
> >>
> >> On Wed, Jun 3, 2020 at 12:02 PM Norman Breau 
> >> wrote:
> >>
> >>> I'm sure you're not the only one who misses it, considering the repo is
> >>> still pretty active in terms of new issues being reported.
> >>>
> >>> On 2020-06-03 3:59 p.m., Darryl Pogue wrote:
>  Correction: There is in fact a deprecation notice, part-way down the
>  README, but it's not especially attention grabbing and I missed it the
>  first 2 times I skimmed the file.
> 
>  On Wed, Jun 3, 2020 at 11:55 AM Darryl Pogue 
> wrote:
> 
> > Hey folks,
> >
> > The File Transfer plugin has been officially deprecated since 2017:
> >
> >>> https://cordova.apache.org/blog/2017/10/18/from-
> >> filetransfer-to-xhr2.html
> > However, the repo and npm have no link to that page or any sort of
> > indication that it is not maintained.
> >
> > With the release of cordova-ios 6, the FileTransfer plugin no longer
> > compiles on iOS:
> > https://github.com/apache/cordova-plugin-file-transfer/issues/258
> >
> > I want to reply to that issue saying that it's deprecated and not
> > maintained, but I feel like we haven't made that very clear.
> >
> > I would like to propose that we update the README for File Transfer
> >>> with a
> > clear deprecation notice which links to the blog post from 2017, and
> >>> that
> > we ask ASF Infra to mark the repo as archived.
> >
> > Any objections?
> >
> > ~Darryl
> >
> >>> -
> >>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> >>> For additional commands, e-mail: dev-h...@cordova.apache.org
> >>>
> >>>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

-- 
Tim Brust
timbrust3...@gmail.com

M: +49 160 9757 3632 <+4916097573632>


Re: Strongly deprecating the FileTransfer plugin

2020-06-03 Thread Norman Breau

+1 on archiving/adding  [DEPRECATED] text in the description.

On 2020-06-03 4:25 p.m., julio cesar sanchez wrote:

This happens with all the deprecated plugins we have, people keeps
reporting issues on them.
I proposed long ago to archive them, but some people was against it, but I
think archiving is the way to go when something is deprecated.


El miércoles, 3 de junio de 2020, Jesse  escribió:


+1 The deprecation notice needs to be prominent, I missed it myself on a
quick scroll.
Some of that readme is in a specific format to support appearance in
docs.cordova.io ( similar to
https://cordova.apache.org/docs/en/latest/reference/
cordova-plugin-file/index.html
  )
This is no longer a requirement, so we can go prominent.
We should also ask INFRA to put the text [DEPRECATED] in the description,
and possibly even archive the repo.


On Wed, Jun 3, 2020 at 12:02 PM Norman Breau 
wrote:


I'm sure you're not the only one who misses it, considering the repo is
still pretty active in terms of new issues being reported.

On 2020-06-03 3:59 p.m., Darryl Pogue wrote:

Correction: There is in fact a deprecation notice, part-way down the
README, but it's not especially attention grabbing and I missed it the
first 2 times I skimmed the file.

On Wed, Jun 3, 2020 at 11:55 AM Darryl Pogue  wrote:


Hey folks,

The File Transfer plugin has been officially deprecated since 2017:


https://cordova.apache.org/blog/2017/10/18/from-

filetransfer-to-xhr2.html

However, the repo and npm have no link to that page or any sort of
indication that it is not maintained.

With the release of cordova-ios 6, the FileTransfer plugin no longer
compiles on iOS:
https://github.com/apache/cordova-plugin-file-transfer/issues/258

I want to reply to that issue saying that it's deprecated and not
maintained, but I feel like we haven't made that very clear.

I would like to propose that we update the README for File Transfer

with a

clear deprecation notice which links to the blog post from 2017, and

that

we ask ASF Infra to mark the repo as archived.

Any objections?

~Darryl


-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org




-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: Strongly deprecating the FileTransfer plugin

2020-06-03 Thread julio cesar sanchez
This happens with all the deprecated plugins we have, people keeps
reporting issues on them.
I proposed long ago to archive them, but some people was against it, but I
think archiving is the way to go when something is deprecated.


El miércoles, 3 de junio de 2020, Jesse  escribió:

> +1 The deprecation notice needs to be prominent, I missed it myself on a
> quick scroll.
> Some of that readme is in a specific format to support appearance in
> docs.cordova.io ( similar to
> https://cordova.apache.org/docs/en/latest/reference/
> cordova-plugin-file/index.html
>  )
> This is no longer a requirement, so we can go prominent.
> We should also ask INFRA to put the text [DEPRECATED] in the description,
> and possibly even archive the repo.
>
>
> On Wed, Jun 3, 2020 at 12:02 PM Norman Breau 
> wrote:
>
> > I'm sure you're not the only one who misses it, considering the repo is
> > still pretty active in terms of new issues being reported.
> >
> > On 2020-06-03 3:59 p.m., Darryl Pogue wrote:
> > > Correction: There is in fact a deprecation notice, part-way down the
> > > README, but it's not especially attention grabbing and I missed it the
> > > first 2 times I skimmed the file.
> > >
> > > On Wed, Jun 3, 2020 at 11:55 AM Darryl Pogue  wrote:
> > >
> > >> Hey folks,
> > >>
> > >> The File Transfer plugin has been officially deprecated since 2017:
> > >>
> > https://cordova.apache.org/blog/2017/10/18/from-
> filetransfer-to-xhr2.html
> > >>
> > >> However, the repo and npm have no link to that page or any sort of
> > >> indication that it is not maintained.
> > >>
> > >> With the release of cordova-ios 6, the FileTransfer plugin no longer
> > >> compiles on iOS:
> > >> https://github.com/apache/cordova-plugin-file-transfer/issues/258
> > >>
> > >> I want to reply to that issue saying that it's deprecated and not
> > >> maintained, but I feel like we haven't made that very clear.
> > >>
> > >> I would like to propose that we update the README for File Transfer
> > with a
> > >> clear deprecation notice which links to the blog post from 2017, and
> > that
> > >> we ask ASF Infra to mark the repo as archived.
> > >>
> > >> Any objections?
> > >>
> > >> ~Darryl
> > >>
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
> >
>


Re: Strongly deprecating the FileTransfer plugin

2020-06-03 Thread Jesse
+1 The deprecation notice needs to be prominent, I missed it myself on a
quick scroll.
Some of that readme is in a specific format to support appearance in
docs.cordova.io ( similar to
https://cordova.apache.org/docs/en/latest/reference/cordova-plugin-file/index.html
 )
This is no longer a requirement, so we can go prominent.
We should also ask INFRA to put the text [DEPRECATED] in the description,
and possibly even archive the repo.


On Wed, Jun 3, 2020 at 12:02 PM Norman Breau  wrote:

> I'm sure you're not the only one who misses it, considering the repo is
> still pretty active in terms of new issues being reported.
>
> On 2020-06-03 3:59 p.m., Darryl Pogue wrote:
> > Correction: There is in fact a deprecation notice, part-way down the
> > README, but it's not especially attention grabbing and I missed it the
> > first 2 times I skimmed the file.
> >
> > On Wed, Jun 3, 2020 at 11:55 AM Darryl Pogue  wrote:
> >
> >> Hey folks,
> >>
> >> The File Transfer plugin has been officially deprecated since 2017:
> >>
> https://cordova.apache.org/blog/2017/10/18/from-filetransfer-to-xhr2.html
> >>
> >> However, the repo and npm have no link to that page or any sort of
> >> indication that it is not maintained.
> >>
> >> With the release of cordova-ios 6, the FileTransfer plugin no longer
> >> compiles on iOS:
> >> https://github.com/apache/cordova-plugin-file-transfer/issues/258
> >>
> >> I want to reply to that issue saying that it's deprecated and not
> >> maintained, but I feel like we haven't made that very clear.
> >>
> >> I would like to propose that we update the README for File Transfer
> with a
> >> clear deprecation notice which links to the blog post from 2017, and
> that
> >> we ask ASF Infra to mark the repo as archived.
> >>
> >> Any objections?
> >>
> >> ~Darryl
> >>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>


Re: Strongly deprecating the FileTransfer plugin

2020-06-03 Thread Norman Breau
I'm sure you're not the only one who misses it, considering the repo is 
still pretty active in terms of new issues being reported.


On 2020-06-03 3:59 p.m., Darryl Pogue wrote:

Correction: There is in fact a deprecation notice, part-way down the
README, but it's not especially attention grabbing and I missed it the
first 2 times I skimmed the file.

On Wed, Jun 3, 2020 at 11:55 AM Darryl Pogue  wrote:


Hey folks,

The File Transfer plugin has been officially deprecated since 2017:
https://cordova.apache.org/blog/2017/10/18/from-filetransfer-to-xhr2.html

However, the repo and npm have no link to that page or any sort of
indication that it is not maintained.

With the release of cordova-ios 6, the FileTransfer plugin no longer
compiles on iOS:
https://github.com/apache/cordova-plugin-file-transfer/issues/258

I want to reply to that issue saying that it's deprecated and not
maintained, but I feel like we haven't made that very clear.

I would like to propose that we update the README for File Transfer with a
clear deprecation notice which links to the blog post from 2017, and that
we ask ASF Infra to mark the repo as archived.

Any objections?

~Darryl



-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: Strongly deprecating the FileTransfer plugin

2020-06-03 Thread Darryl Pogue
Correction: There is in fact a deprecation notice, part-way down the
README, but it's not especially attention grabbing and I missed it the
first 2 times I skimmed the file.

On Wed, Jun 3, 2020 at 11:55 AM Darryl Pogue  wrote:

> Hey folks,
>
> The File Transfer plugin has been officially deprecated since 2017:
> https://cordova.apache.org/blog/2017/10/18/from-filetransfer-to-xhr2.html
>
> However, the repo and npm have no link to that page or any sort of
> indication that it is not maintained.
>
> With the release of cordova-ios 6, the FileTransfer plugin no longer
> compiles on iOS:
> https://github.com/apache/cordova-plugin-file-transfer/issues/258
>
> I want to reply to that issue saying that it's deprecated and not
> maintained, but I feel like we haven't made that very clear.
>
> I would like to propose that we update the README for File Transfer with a
> clear deprecation notice which links to the blog post from 2017, and that
> we ask ASF Infra to mark the repo as archived.
>
> Any objections?
>
> ~Darryl
>


Strongly deprecating the FileTransfer plugin

2020-06-03 Thread Darryl Pogue
Hey folks,

The File Transfer plugin has been officially deprecated since 2017:
https://cordova.apache.org/blog/2017/10/18/from-filetransfer-to-xhr2.html

However, the repo and npm have no link to that page or any sort of
indication that it is not maintained.

With the release of cordova-ios 6, the FileTransfer plugin no longer
compiles on iOS:
https://github.com/apache/cordova-plugin-file-transfer/issues/258

I want to reply to that issue saying that it's deprecated and not
maintained, but I feel like we haven't made that very clear.

I would like to propose that we update the README for File Transfer with a
clear deprecation notice which links to the blog post from 2017, and that
we ask ASF Infra to mark the repo as archived.

Any objections?

~Darryl


[VOTE] Splashscreen Plugin Release 5.0.4

2020-06-03 Thread Niklas Merz
(sending again because previous email was attached to discuss thread)

Please review and vote on the release of this plugins release
by replying to this email (and keep discussion on the DISCUSS thread)

The plugins have been published to dist/dev:
https://dist.apache.org/repos/dist/dev/cordova/cordova-plugin-splaschreen-5.0.4/

The packages were published from their corresponding git tags:
cordova-plugin-splashscreen: 5.0.4 (5bc7d0d63f)

Upon a successful vote I will upload the archives to dist/, upload them
to npm, and post the corresponding blog post.

Voting guidelines:
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
How to vote on a plugins release at
https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md#voting

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and subdependencies
have Apache-compatible licenses
* Did the tests with Xcode like instructed

Please note some CI test could fail but I think the test setup is
faulty. Works locally in Xcode for me. Let me know in DISCUSS.

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[VOTE] Splashscreen Plugin Release 5.0.4

2020-06-03 Thread Niklas Merz
Please review and vote on the release of this plugins release
by replying to this email (and keep discussion on the DISCUSS thread)

The plugins have been published to dist/dev:
https://dist.apache.org/repos/dist/dev/cordova/cordova-plugin-splaschreen-5.0.4/

The packages were published from their corresponding git tags:
cordova-plugin-splashscreen: 5.0.4 (5bc7d0d63f)

Upon a successful vote I will upload the archives to dist/, upload them
to npm, and post the corresponding blog post.

Voting guidelines:
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
How to vote on a plugins release at
https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md#voting

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and subdependencies
have Apache-compatible licenses
* Did the tests with Xcode like instructed

Please note some CI test could fail but I think the test setup is
faulty. Works locally in Xcode for me. Let me know in DISCUSS.

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: [DISCUSS] Splashscreen Plugin Release 5.0.4

2020-06-03 Thread Niklas Merz
Seems like we are good to go for this plugin. I will start the release now!

Am 02.06.20 um 20:39 schrieb Niklas Merz:
> Hi all,
> 
> Since cordova-ios 6.0, which includes a splashscreen implementation, was 
> released recently, we should release a patch version of the splashscreen 
> plugin which sets the version requirements correctly [1].
> 
> Does anyone have any reason to delay this patch release?
> Any outstanding patches to land?
> 
> If not, I will start the release tomorrow.
> 
> After this patch release we will introduce some some breaking changes 
> including the removal of iOS code in a major release after that. The PRs are 
> already open.
> 
> [1] https://github.com/apache/cordova-plugin-splashscreen/pull/261
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
> 

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org