GitHub user bso-intel opened a pull request:
https://github.com/apache/cordova-cli/pull/230
CB-8455 added --nohooks option
implemented --nohooks option described in CB-8455
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bso
GitHub user bso-intel opened a pull request:
https://github.com/apache/cordova-lib/pull/353
CB-8455 added --nohooks option
implemented --nohooks noption as described in CB-8455
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bso
Github user bso-intel commented on the pull request:
https://github.com/apache/cordova-lib/pull/353#issuecomment-163090076
Hi Jesse,
The CI failures actually were caused by not checking the existence of the
opts parameter.
In the spec unit tests, update_project() was
Github user bso-intel commented on the pull request:
https://github.com/apache/cordova-lib/pull/353#issuecomment-163324816
Hi Vladmir,
Exactly.
The pre-package hooks on for the windows* platforms run when LIB prepares
for the source.
To suppress this hook, HookRunner
GitHub user bso-intel opened a pull request:
https://github.com/apache/cordova-lib/pull/355
Cb 7183
CB-7183 security check for the scriptSrc property of the engine tag.
The other src and target-dir path escape checks are already implemented in
cordova-lib/src/plugman
Github user bso-intel commented on the pull request:
https://github.com/apache/cordova-lib/pull/353#issuecomment-165619803
HI Jesse and Vladimir,
If there is no more comment, could you pull my branch CB-8455 so the next
Cordova release contains this feature?
Thanks.
---
If
Github user bso-intel commented on the pull request:
https://github.com/apache/cordova-lib/pull/355#issuecomment-165621005
Hi Shazron,
Could you review this CB-7183?
As we discussed we need some security check for plugins accessing outside
the plugins directory.
Please
Github user bso-intel commented on the pull request:
https://github.com/apache/cordova-cli/pull/230#issuecomment-165622485
Hi Jesse and Vladimir,
Could you review this together with my pull request in
https://github.com/apache/cordova-lib/pull/353
for cordova-lib
Github user bso-intel commented on the pull request:
https://github.com/apache/cordova-lib/pull/353#issuecomment-165950086
Hi Vladimir,
Thank you very much for reviewing.
I addressed your feedback and added several unit tests in LIB and CLI.
---
If your project is set up
Github user bso-intel commented on the pull request:
https://github.com/apache/cordova-cli/pull/230#issuecomment-165950153
Hi Vladimir,
Thank you for reviewing.
I addressed your feedback, and updated the help doc, and created one unit
test.
---
If your project is set up
Github user bso-intel commented on the pull request:
https://github.com/apache/cordova-lib/pull/353#issuecomment-166358228
Thank you very much for merging, Vladimir.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user bso-intel commented on the pull request:
https://github.com/apache/cordova-cli/pull/230#issuecomment-166358430
Thank you very much for merging, Vladimir.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user bso-intel commented on the pull request:
https://github.com/apache/cordova-lib/pull/355#issuecomment-166404691
Hi Sharon,
Thanks for reviewing.
I don't see any failures for the test.
{quote}
[cordova-lib] node_modules/jasmine-node/bin/jasmine-node
Github user bso-intel commented on the pull request:
https://github.com/apache/cordova-lib/pull/355#issuecomment-166405427
Got it. Sorry.
I will add a unit test that detects the path escaping issue, and let you
know.
---
If your project is set up for it, you can reply to this
Github user bso-intel commented on the pull request:
https://github.com/apache/cordova-lib/pull/355#issuecomment-166441171
Hi Shazron,
I added a unit test that detects the security violation.
---
If your project is set up for it, you can reply to this email and have your
Github user bso-intel commented on the pull request:
https://github.com/apache/cordova-lib/pull/355#issuecomment-166444947
Thanks for merging, Shazron!!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user bso-intel opened a pull request:
https://github.com/apache/cordova-windows/pull/140
CB-10381 fix the bug when removing a plugin with a tag
I fixed a simple bug that caused an exception EISDIR when removing a plugin
that includes a tag.
PluginHandler.js should have
Github user bso-intel commented on the pull request:
https://github.com/apache/cordova-windows/pull/140#issuecomment-172667498
Hi @vladimir-kotikov
Could you review this pull request?
Thanks.
---
If your project is set up for it, you can reply to this email and have your
Github user bso-intel commented on the pull request:
https://github.com/apache/cordova-windows/pull/140#issuecomment-172675243
Hi @purplecabbage,
Here is how you can reproduce the issue:
1. cordova platform add windows
2. cordova plugin add cordova-sqlite-storage
3
Github user bso-intel commented on the pull request:
https://github.com/apache/cordova-windows/pull/140#issuecomment-173474167
Hi @purplecabbage,
Would you review this pull request?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
GitHub user bso-intel opened a pull request:
https://github.com/apache/cordova-lib/pull/387
CB-10550 Fixed the issue of plugin id mapper not enforced when a versâ¦
â¦ion is specified
The issue is described in https://issues.apache.org/jira/browse/CB-10550
The fix is
GitHub user bso-intel opened a pull request:
https://github.com/apache/cordova-lib/pull/388
CB-10611 fixed the before_plugin_install hook not disabled with --nohâ¦
â¦ooks
The fix is to pass the command line option to the plugman when adding a
plugin.
You can merge this
Github user bso-intel commented on the pull request:
https://github.com/apache/cordova-lib/pull/387#issuecomment-184998947
Hi @TimBarham
Thanks for reviewing this pull request.
I updated the comment as you requested.
---
If your project is set up for it, you can reply to
Github user bso-intel commented on the pull request:
https://github.com/apache/cordova-lib/pull/388#issuecomment-184999128
Thank you very much, Tim.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user bso-intel closed the pull request at:
https://github.com/apache/cordova-lib/pull/387
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user bso-intel commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/395#discussion_r53545185
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -79,148 +79,156 @@ function addHelper(cmd, hooksRunner, projectRoot,
targets, opts
Github user bso-intel commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/395#discussion_r53545199
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -79,148 +79,156 @@ function addHelper(cmd, hooksRunner, projectRoot,
targets, opts
Github user bso-intel commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/395#discussion_r53545261
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -79,148 +79,156 @@ function addHelper(cmd, hooksRunner, projectRoot,
targets, opts
Github user bso-intel commented on the pull request:
https://github.com/apache/cordova-lib/pull/395#issuecomment-186517246
It looks great assuming that before_platform_add and after_platform_add
hooks could be platform specific.
My understanding about the current convention is a
GitHub user bso-intel opened a pull request:
https://github.com/apache/cordova-lib/pull/396
CB-10314 avoid fetching plugins when oldId is already fetched
implement the fix to the issue in CB-10314.
Before start fetching the plugin, first check if the plugin with alias id
is
GitHub user bso-intel opened a pull request:
https://github.com/apache/cordova-ios/pull/195
CB-10659 changed project name to fix the platform add failure
The project name "Hello Cordova" does not match with template project
"HelloCordova", and it causes fail
GitHub user bso-intel opened a pull request:
https://github.com/apache/cordova-android/pull/261
CB-10660 fixed the exception when removing a non-existing directory
It is ALWAYS safer to check if the directory exists before it tires to
remove the directory.
The uninstallation of
Github user bso-intel commented on the pull request:
https://github.com/apache/cordova-ios/pull/195#issuecomment-189121892
Hi @nikhilkh
Thanks for testing.
Could you merge this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user bso-intel commented on the pull request:
https://github.com/apache/cordova-android/pull/261#issuecomment-189122310
@vladimir-kotikov ,
Could you review this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user bso-intel commented on the pull request:
https://github.com/apache/cordova-lib/pull/396#issuecomment-189123404
@vladimir-kotikov
Could you review this?
Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user bso-intel commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/396#discussion_r54328698
--- Diff: cordova-lib/src/plugman/fetch.js ---
@@ -135,13 +135,32 @@ function fetchPlugin(plugin_src, plugins_dir,
options) {
var
Github user bso-intel commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/396#discussion_r54328707
--- Diff: cordova-lib/src/plugman/install.js ---
@@ -79,21 +79,36 @@ module.exports = function installPlugin(platform,
project_dir, id, plugins_dir
Github user bso-intel commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/396#discussion_r54328731
--- Diff: cordova-lib/src/plugman/install.js ---
@@ -79,21 +79,36 @@ module.exports = function installPlugin(platform,
project_dir, id, plugins_dir
Github user bso-intel commented on the pull request:
https://github.com/apache/cordova-lib/pull/396#issuecomment-189578539
Hi Vladimir,
I updated the code to accommodate your comments.
Thanks.
---
If your project is set up for it, you can reply to this email and have your
Github user bso-intel commented on the pull request:
https://github.com/apache/cordova-android/pull/261#issuecomment-189579252
Thanks for merging, Vladimir.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user bso-intel commented on the pull request:
https://github.com/apache/cordova-lib/pull/396#issuecomment-189672357
Yes, please merge this for me.
I don't have committer privilege, which I wish to get. :)
Thanks, Vladimir.
---
If your project is set up for it, yo
Github user bso-intel commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/396#discussion_r54334968
--- Diff: cordova-lib/src/plugman/fetch.js ---
@@ -135,13 +135,32 @@ function fetchPlugin(plugin_src, plugins_dir,
options) {
var
GitHub user bso-intel opened a pull request:
https://github.com/apache/cordova-ios/pull/199
CB-10673 fixed conflicting plugin install issue with overlapped tag
The problem is that copyNewFile is too strict for tag.
You will never know which two plugins will write the library to
GitHub user bso-intel opened a pull request:
https://github.com/apache/cordova-android/pull/264
CB-10673 fixed conflicting plugin install issue with overlapped tag
The problem is that copyNewFile is too strict for tag.
You will never know which two plugins will write the
GitHub user bso-intel opened a pull request:
https://github.com/apache/cordova-windows/pull/154
CB-10673 CB-10673 fixed conflicting plugin install issue with overlapped
The problem is that copyNewFile is too strict for tag.
You will never know which two plugins will write the
GitHub user bso-intel opened a pull request:
https://github.com/apache/cordova-lib/pull/402
CB-10328 set top-level property of plugins when adding new platforms
The problem is caused by not setting the top-level property of plugins from
cordova/platform.js
Github user bso-intel commented on the pull request:
https://github.com/apache/cordova-android/pull/264#issuecomment-190778940
@vladimir-kotikov,
This is just one example of the conflicting plugins.
There could be so many plugins out there that requires the same library
files
Github user bso-intel commented on the pull request:
https://github.com/apache/cordova-android/pull/264#issuecomment-190937260
Hi nikhill,
I am not a plugin writer so I don't know whether the plugin write can use
other tags for their purposes.
This issue was reported
Github user bso-intel commented on the pull request:
https://github.com/apache/cordova-android/pull/264#issuecomment-190952289
Right. I agree that silently passing is not good.
So, I said that we should print the warning message to the user "Warning:
in the already e
Github user bso-intel commented on the pull request:
https://github.com/apache/cordova-android/pull/264#issuecomment-191319864
I am working on adding a command-line option --force-copying-src to allow
the Cordova user to try overwriting the conflicting file.
I hope this gives some
Github user bso-intel commented on the pull request:
https://github.com/apache/cordova-lib/pull/402#issuecomment-191536082
@vladimir-kotikov
Could you review this pull request?
Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user bso-intel opened a pull request:
https://github.com/apache/cordova-cli/pull/236
CB-10673 added --force-copying-src option
This option is need to rescue some Cordova users who has trouble installing
two conflicting plugins that use the same source-file target.
You can
GitHub user bso-intel opened a pull request:
https://github.com/apache/cordova-lib/pull/404
CB-10673 added --force-copying-src option
This option is need to rescue some Cordova users who has trouble installing
two conflicting plugins that use the same source-file target.
You can
Github user bso-intel commented on the pull request:
https://github.com/apache/cordova-android/pull/264#issuecomment-191616111
Since now I created the --force-copying-src option, the current behavior of
throwing exception is preserved.
To get around this issue, the user can use
Github user bso-intel commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/402#discussion_r54902889
--- Diff: cordova-lib/src/plugman/install.js ---
@@ -71,7 +71,8 @@ module.exports = function installPlugin(platform,
project_dir, id, plugins_dir
Github user bso-intel commented on the pull request:
https://github.com/apache/cordova-cli/pull/236#issuecomment-192151135
Hi @nikhilkh
Thanks for reviewing.
I changed all 5 pull requests (CLI, LIB, android, ios, windows) to
accommodate your comments using --force.
---
If
Github user bso-intel commented on the pull request:
https://github.com/apache/cordova-lib/pull/404#issuecomment-192389465
@nikhilkh,
Could you review this?
Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user bso-intel commented on the pull request:
https://github.com/apache/cordova-ios/pull/199#issuecomment-192389706
@nikhilkh,
Could you review this?
Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user bso-intel commented on the pull request:
https://github.com/apache/cordova-windows/pull/154#issuecomment-192389824
@nikhilkh,
Could you review this?
Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user bso-intel commented on the pull request:
https://github.com/apache/cordova-lib/pull/402#issuecomment-19288
@vladimir-kotikov ,
I added an e2e test that is described in CB-10328.
The test fails without my fix, and passes with my fix.
Could you merge this pull
Github user bso-intel commented on the pull request:
https://github.com/apache/cordova-lib/pull/396#issuecomment-192567709
@vladimir-kotikov ,
Just a friendly reminder. This is still not merged.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user bso-intel commented on the pull request:
https://github.com/apache/cordova-lib/pull/396#issuecomment-192706090
Thank you for merging, @vladimir-kotikov
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user bso-intel commented on the pull request:
https://github.com/apache/cordova-lib/pull/402#issuecomment-192706126
Thanks for merging, @vladimir-kotikov
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user bso-intel commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/236#discussion_r55312985
--- Diff: doc/readme.md ---
@@ -315,6 +315,7 @@ cordova {plugin | plugins} [
| |--link | When installing from a local path
64 matches
Mail list logo
