[GitHub] cordova-android pull request: Allow subdomains flag in Whitelist x...

2014-03-19 Thread clelland
Github user clelland commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/95#discussion_r10768516 --- Diff: framework/src/org/apache/cordova/Whitelist.java --- @@ -136,6 +136,14 @@ public void addWhiteListEntry(String origin, boolean subdomains

[GitHub] cordova-android pull request: Allow subdomains flag in Whitelist x...

2014-03-19 Thread clelland
Github user clelland commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/95#discussion_r10768518 --- Diff: framework/src/org/apache/cordova/Whitelist.java --- @@ -136,6 +136,14 @@ public void addWhiteListEntry(String origin, boolean subdomains

[GitHub] cordova-plugin-file-transfer pull request: Fixed - Xcode erros. CD...

2014-03-21 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/18#issuecomment-38279222 I still don't quite understand how you're getting errors in XCode from the default settings (I see the issue as a warning if I use

[GitHub] cordova-plugin-file-transfer pull request: Fixed - Xcode erros. CD...

2014-03-21 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/18#issuecomment-38286028 I see the error in your project, without any changes. Still no idea why it shows up in one but not the other. Possibly something to do with the

[GitHub] cordova-plugin-file-transfer pull request: Fixed - Xcode erros. CD...

2014-03-21 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/18#issuecomment-38298403 Can you test the code on the dev branch, and close the pull request if it's all good now? --- If your project is set up for it, you can rep

[GitHub] cordova-plugin-file-transfer pull request: Update CDVFileTransfer....

2014-03-26 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/24#issuecomment-38704767 This looks like it should be part of the work for [CB-5175](https://issues.apache.org/jira/browse/CB-5175). Thanks for the patch, Jorge

[GitHub] cordova-plugin-file pull request: fixed setMetadata() to use the f...

2014-03-27 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/33#issuecomment-38797238 See [CB-6351](https://issues.apache.org/jira/browse/CB-6351) as well -- this was also reported on JIRA while still on the dev branch. --- If your project

[GitHub] cordova-plugin-file-transfer pull request: Update CDVFileTransfer....

2014-03-27 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/24#issuecomment-38811807 I've incorporated your code into my local repository, but it looks like FileTransfer.abort() is no longer working correctly. There are

[GitHub] cordova-plugin-file-transfer pull request: Update CDVFileTransfer....

2014-03-27 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/24#issuecomment-38819465 We run all of the automated tests from the [Mobile Spec application](https://github.com/apache/cordova-mobile-spec/) -- it's a Cordova app

[GitHub] cordova-plugin-file-transfer pull request: Update CDVFileTransfer....

2014-03-27 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/24#issuecomment-38820556 That last patch looks like it did the trick -- there is still one test failing (filetransfer.spec.9), but it appears to have been failing for a

[GitHub] cordova-plugin-file-transfer pull request: Update CDVFileTransfer....

2014-03-27 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/24#issuecomment-38834100 I've squashed the two commits together, and merged that into the dev branch now -- feel free to close this pull request if GitHub doesn&#x

[GitHub] cordova-plugin-camera pull request: Update index.md

2014-03-31 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/21#issuecomment-39111334 Square brackets are a pretty common notation for optional arguments -- I haven't checked to see whether we're using them that way consisten

[GitHub] cordova-plugin-camera pull request: Update index.md

2014-03-31 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/21#issuecomment-39117406 Not just shell commands; other languages with optional parameters use this notation as well. When describing a function, I've seldom seen s

[GitHub] cordova-plugin-camera pull request: Update index.md

2014-03-31 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/21#issuecomment-39117755 (BTW, please show me that I'm wrong here -- I feel much more strongly about clarity than about, say, a UNIX tradition. I'm happy to stan

[GitHub] cordova-plugin-inappbrowser pull request: [CB-6389] add clearsessi...

2014-04-03 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/34#issuecomment-39527128 Umm... you're absolutely right there. And I'm not sure quite how I missed that. I'll reopen the original issue (CB-361

[GitHub] cordova-plugin-geolocation pull request: Update GPSListener.java

2014-04-07 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/15#issuecomment-39731767 Perhaps this kind of setting should be configurable? I don't see any compelling reason why distance-based update is objectively "better&q

[GitHub] cordova-plugin-inappbrowser pull request: [CB-6389] add clearsessi...

2014-04-07 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/34#issuecomment-39748760 Okay, so: 1. Android docs say that `clearcache` and `clearsessioncache` apply to the *cookie* store. 2. Android code actually *does

[GitHub] cordova-plugin-file pull request: fix the Windows 8 implementation...

2014-04-08 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/36#issuecomment-39853542 Looks like https://issues.apache.org/jira/browse/CB-6017 (and possibly also https://issues.apache.org/jira/browse/CB-6053) --- If your project is set up

[GitHub] cordova-windows pull request: CB-6435 ./VERSION & /template/VERSIO...

2014-04-14 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-windows/pull/25#issuecomment-40361496 It seems odd that this wasn't taken care of automatically by coho when 3.3.0 was released (and when 3.4.0 was released); if it's still not happening

[GitHub] cordova-windows pull request: CB-6435 ./VERSION & /template/VERSIO...

2014-04-15 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-windows/pull/25#issuecomment-40526123 I think that we should change version to 3.5.0-dev, like the other platforms (since 3.4.0 is released already, development should now be on 3.5.0-dev), and then

[GitHub] cordova-docs pull request: CB-6680 Clarify instructions for instal...

2014-05-22 Thread clelland
Github user clelland commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/205#discussion_r12952956 --- Diff: docs/en/edge/guide/cli/index.md --- @@ -73,22 +74,41 @@ To install the `cordova` command-line tool, follow these steps: the CLI does

[GitHub] cordova-js pull request: Update README.md

2014-05-23 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-js/pull/69#issuecomment-44007969 This should really be two separate commits -- the addition to .gitignore is way out of scope for CB-6741. Also, is the pattern `*sublime*` really as tight as

[GitHub] cordova-js pull request: Update README.md

2014-05-23 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-js/pull/69#issuecomment-44032565 Let's just remove those for this commit; make another issue for the subversion files, I think. --- If your project is set up for it, you can reply to this emai

[GitHub] cordova-plugin-file pull request: Fixed toURL() vs. toInternalURL(...

2014-05-23 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/46#issuecomment-44052989 I committed this (with a couple of small tweaks) -- you can close this now :) --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-plugin-file pull request: Update index.md

2014-05-23 Thread clelland
Github user clelland commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/41#discussion_r13016951 --- Diff: doc/index.md --- @@ -24,6 +24,20 @@ to HTML5 Rocks' [FileSystem article](http://www.html5rocks.com/en/tutorials/file o

[GitHub] cordova-plugin-file pull request: Update Metadata.js

2014-05-23 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/39#issuecomment-44056947 It looks like the mobilespec test for this just checked that `metadata.modificationTime instanceof Date` was true. Unfortunately, new Date

[GitHub] cordova-plugin-file pull request: Update Metadata.js

2014-06-11 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/39#issuecomment-45775108 I've created [CB-6922](https://issues.apache.org/jira/browse/CB-6922) for this -- it was certainly a problem in Android. The trouble, as

[GitHub] cordova-plugin-network-information pull request: fix NullPointerEx...

2014-06-11 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-network-information/pull/10#issuecomment-45822792 Hi Dozer, I just found this as well -- I filed [CB-6907](https://issues.apache.org/jira/browse/CB-6907) and fixed it yesterday

[GitHub] cordova-app-harness pull request: [CB6947] move app directory by d...

2014-06-16 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-app-harness/pull/1#issuecomment-46182293 Is that literally '`xx`', or is that a placeholder for some other value? --- If your project is set up for it, you can reply to this email and

[GitHub] cordova-plugin-network-information pull request: fix NullPointerEx...

2014-06-18 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-network-information/pull/10#issuecomment-46433863 No, it hasn't been pushed to the plugin repository. That will go out with the next plugin release. (Hopefully next week or the following

[GitHub] cordova-plugin-file pull request: Update index.md

2014-06-19 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/41#issuecomment-46578802 I think that the point of this doc change, which was to document how to use `window.resolveLocalFileSystemURL` to use all of the new paths, has been covered

[GitHub] cordova-plugin-file pull request: Update Metadata.js

2014-06-19 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/39#issuecomment-46579029 This fix has been committed, and the tests are ensuring that the correct keys appear in the callbacks. You can close this pull request, I think. --- If

[GitHub] cordova-plugin-file-transfer pull request: [CB-5059] Remove the de...

2014-06-19 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/8#issuecomment-46603710 Junmin, can you comment any more on this? I'm not sure what the root issue is? Does the current filetransfer plugin cause a crash with the cros

[GitHub] cordova-plugin-file-transfer pull request: FileTransfer did not ab...

2014-06-19 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/19#issuecomment-46604018 This was fixed, I think, in 0f8467bd -- can you close this pull request? --- If your project is set up for it, you can reply to this email and

[GitHub] cordova-plugin-network-information pull request: fix NullPointerEx...

2014-06-20 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-network-information/pull/10#issuecomment-46683835 If you want to use this right now, you can install from github directly: cordova plugin add https://github.com/apache/cordova

[GitHub] cordova-plugin-file-transfer pull request: CB-6503 allow file uplo...

2014-06-27 Thread clelland
Github user clelland commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/27#discussion_r14322193 --- Diff: src/amazon/FileTransfer.java --- @@ -315,8 +315,12 @@ public void run() { // Use a post method

[GitHub] cordova-plugin-file-transfer pull request: CB-6503 allow file uplo...

2014-06-27 Thread clelland
Github user clelland commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/27#discussion_r14322195 --- Diff: src/android/FileTransfer.java --- @@ -315,8 +315,13 @@ public void run() { // Use a post

[GitHub] cordova-plugin-file-transfer pull request: CB-6503 allow file uplo...

2014-06-27 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/27#issuecomment-47416739 @machenmusik, do you have an ICLA on file with the Apache foundation? I've reviewed this, and it looks good (other than a couple of

[GitHub] cordova-plugin-contacts pull request: fixes CB-7003 navigator.cont...

2014-07-02 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/32#issuecomment-47789413 This is merged now; you can close this (I forgot to auto-close by mentioning the PR# in the commit) --- If your project is set up for it, you can

[GitHub] cordova-plugin-file-transfer pull request: CB-6928: Implements NOT...

2014-07-04 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/32#issuecomment-48051234 It's on my list; I'm going to try to get to it either today or on the weekend. --- If your project is set up for it, you can reply to

[GitHub] cordova-plugin-camera pull request: added allowEdit support for an...

2014-07-10 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/12#issuecomment-48634777 @woozzel, it looks like this was merged in just after v0.2.9 was released, and the code is present in the v0.3.0 release, which is available now from

[GitHub] cordova-plugin-camera pull request: added allowEdit support for an...

2014-07-10 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/12#issuecomment-48635041 @confile, you can file issues on our JIRA issue tracker [here](https://issues.apache.org/jira/browse/CB/) You'll have to create a (free) ac

[GitHub] cordova-plugin-file pull request: CB-7093 Ported automated File te...

2014-07-14 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/60#issuecomment-48936357 Wow, thanks for taking that on; it's a lot of work! (I had previously done most of this last year, on https://github.com/apache/cordova-plugin

[GitHub] cordova-plugin-file pull request: CB-7093 Ported automated File te...

2014-07-14 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/60#issuecomment-48985942 Yeah, the URL/URI messages have been there a long time; I just figured I'd take the opportunity to clean them up now, especially as the console log is

[GitHub] cordova-plugin-file-transfer pull request: CB-6503 allow file uplo...

2014-07-25 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/27#issuecomment-50159977 Bump! @machenmusik -- we just need an ICLA filed, and we can pull this code in. Thanks --- If your project is set up for it, you can

[GitHub] cordova-lib pull request: Allow plugin modules to be .json files

2014-08-08 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-lib/pull/71#issuecomment-51634361 This seems like it could be a cool feature; do you have a use case for it? We should probably open a [JIRA](https://issues.apache.org/jira/browse/CB) issue

[GitHub] cordova-android pull request: Update tests.java

2014-08-11 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-android/pull/112#issuecomment-51783715 Is this just noise? Please close this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-plugin-device pull request: adds new property 'manufacture...

2014-08-11 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-device/pull/20#issuecomment-51784352 I've linked this to https://issues.apache.org/jira/browse/CB-7285 for discussion. I'd like to see WP, FireOS (all Amazon?) FFOS chime in on thi

[GitHub] cordova-docs pull request: Fix getting-started image references fo...

2014-08-15 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-docs/pull/225#issuecomment-52349536 Looks good; I haven't checked that they're all there, but we can pick up any stragglers afterwards if we see them. It'll require a `ra

[GitHub] cordova-cli pull request: CB-7345 improve cli documentation

2014-08-20 Thread clelland
Github user clelland commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/188#discussion_r16494980 --- Diff: doc/build.txt --- @@ -1,8 +1,26 @@ Synopsis -cordova-cli build [PLATFORM..] [-- [platformopts]] +cordova-cli build

[GitHub] cordova-cli pull request: CB-7345 improve cli documentation

2014-08-20 Thread clelland
Github user clelland commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/188#discussion_r16498478 --- Diff: doc/cordova.txt --- @@ -16,11 +16,15 @@ Project Commands prepare Copy files into platform(s) for

[GitHub] cordova-cli pull request: CB-7345 improve cli documentation

2014-08-20 Thread clelland
Github user clelland commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/188#discussion_r16498522 --- Diff: doc/cordova.txt --- @@ -16,11 +16,15 @@ Project Commands prepare Copy files into platform(s) for

[GitHub] cordova-plugin-file pull request: CB-7487 [Android] Broadcast file...

2014-09-17 Thread clelland
Github user clelland commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/81#discussion_r17667021 --- Diff: src/android/LocalFilesystem.java --- @@ -589,6 +593,32 @@ public long writeToFileAtURL(LocalFilesystemURL inputURL, String data

[GitHub] cordova-plugin-file pull request: CB-7487 [Android] Broadcast file...

2014-09-17 Thread clelland
Github user clelland commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/81#discussion_r17667256 --- Diff: src/android/LocalFilesystem.java --- @@ -579,6 +582,7 @@ public long writeToFileAtURL(LocalFilesystemURL inputURL, String data

[GitHub] cordova-plugin-splashscreen pull request: Added support for iPhone...

2014-09-17 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/26#issuecomment-55928732 And [this document](https://developer.apple.com/library/prerelease/ios/documentation/UserExperience/Conceptual/MobileHIG/LaunchImages.html) linked

[GitHub] cordova-plugin-device pull request: Few changes in Spanish Transla...

2014-10-06 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-device/pull/17#issuecomment-58071614 I'm not sure what happened to this pull request, or the repo that it came from -- I can't merge it as the source doesn't seem to exist!

[GitHub] cordova-plugin-file pull request: Evo: Document the iosExtraFilesy...

2014-10-06 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/82#issuecomment-58092692 I don't think that recommending `window.requestFileSystem(3,...)` is the right way to go here. Off the top of my head, I can think of two better wa

[GitHub] cordova-plugin-file pull request: CB-7487 [Android] Broadcast file...

2014-10-06 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/81#issuecomment-58098186 Merged! You can close this PR any time. (I squashed the two commits together, and rebased against the current head, so github won't automati

[GitHub] cordova-plugin-file pull request: Possible fix for CB-7415: Implem...

2014-10-06 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/71#issuecomment-58102341 On iOS 6 & 7 (haven't tried 8 yet), I get an error in mobilespec with this patch: TypeError: Attempting to change access mechani

[GitHub] cordova-lib pull request: CB-7721 - cordova-lib tests fail (on old...

2014-10-07 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-lib/pull/101#issuecomment-58192634 LGTM; Merged into master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-plugin-file pull request: CB-6994 - Windows 8 does not sav...

2014-10-23 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/54#issuecomment-60296900 Probably not the same issue, @shenzhuxi -- Android hasn't used that technique for binary data in at least a year. (Not saying that you don

[GitHub] cordova-android pull request: Unplug whitelist

2014-10-29 Thread clelland
Github user clelland commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/132#discussion_r19540972 --- Diff: framework/src/org/apache/cordova/CordovaPlugin.java --- @@ -162,19 +162,53 @@ public Object onMessage(String id, Object data

[GitHub] cordova-android pull request: Unplug whitelist

2014-10-29 Thread clelland
Github user clelland commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/132#discussion_r19541080 --- Diff: framework/src/org/apache/cordova/CordovaPlugin.java --- @@ -162,19 +162,53 @@ public Object onMessage(String id, Object data

[GitHub] cordova-android pull request: Unplug whitelist

2014-10-29 Thread clelland
Github user clelland commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/132#discussion_r19540735 --- Diff: framework/src/org/apache/cordova/AndroidWebView.java --- @@ -429,7 +426,7 @@ public void showWebPage(String url, boolean openExternal

[GitHub] cordova-android pull request: Unplug whitelist

2014-10-29 Thread clelland
Github user clelland commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/132#discussion_r19542061 --- Diff: framework/src/org/apache/cordova/PluginManager.java --- @@ -254,6 +254,110 @@ public void onNewIntent(Intent intent

[GitHub] cordova-ios pull request: Unplug whitelist - review

2014-10-29 Thread clelland
Github user clelland commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/116#discussion_r19543890 --- Diff: CordovaLib/Classes/CDVViewController.m --- @@ -714,24 +712,44 @@ - (BOOL)webView:(UIWebView*)theWebView shouldStartLoadWithRequest

[GitHub] cordova-android pull request: Unplug whitelist

2014-10-29 Thread clelland
Github user clelland commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/132#discussion_r19553788 --- Diff: framework/src/org/apache/cordova/AndroidWebView.java --- @@ -354,7 +349,9 @@ private void loadUrlNow(String url) { if

[GitHub] cordova-ios pull request: Unplug whitelist - review

2014-10-30 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-ios/pull/116#issuecomment-61135482 That's a terrible error, btw :) EX_DATAERR (65) The input data was incorrect in some way. This should only be used for user's da

[GitHub] cordova-ios pull request: Unplug whitelist - review

2014-10-30 Thread clelland
Github user clelland commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/116#discussion_r19623071 --- Diff: CordovaLib/Classes/CDVViewController.m --- @@ -714,24 +712,44 @@ - (BOOL)webView:(UIWebView*)theWebView shouldStartLoadWithRequest

[GitHub] cordova-lib pull request: Add a type named "gradleReference" in fr...

2014-11-06 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-lib/pull/111#issuecomment-62004988 Sorry, Junwei -- I meant to take a look at this when you first posted it. This looks good; I'm going to test it out with the Crosswalk AAR, and I'

[GitHub] cordova-lib pull request: Add a type named "gradleReference" in fr...

2014-11-06 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-lib/pull/111#issuecomment-62033701 What happens on upgrade, if a project already has a `platforms/android/build.gradle` file? Do we need to put some code in to either replace build.gradle or add the

[GitHub] cordova-lib pull request: Add a type named "gradleReference" in fr...

2014-11-06 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-lib/pull/111#issuecomment-62037845 Tests should be updated with this as well (although they were failing on the branch before this PR) --- If your project is set up for it, you can reply to this

[GitHub] cordova-lib pull request: Add a type named "gradleReference" in fr...

2014-11-06 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-lib/pull/111#issuecomment-62037534 I've rebased this against master now, and pushed it up on a feature branch (`CB-3445-2`, to not conflict with the previous branch) --- If your project is s

[GitHub] cordova-lib pull request: Add a type named "gradleReference" in fr...

2014-11-06 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-lib/pull/111#issuecomment-62038387 Pushed to apache/cordova-android as well, on a new CB-3445 branch. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-plugin-file pull request: CB-7917 Fixed tests file.spec.11...

2014-11-13 Thread clelland
Github user clelland commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/88#discussion_r20315283 --- Diff: tests/tests.js --- @@ -1,4 +1,4 @@ -/* +/* --- End diff -- This line has a non-visible BOM (U+FEFF) -- can you

[GitHub] cordova-lib pull request: Add a type named "gradleReference" in fr...

2014-11-14 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-lib/pull/119#issuecomment-63091257 Finally had the chance to review and test this. Looks good; tests fine; I'm merging it in to master. --- If your project is set up for it, you can reply to

[GitHub] cordova-android pull request: Typo in android gitignore (ant-built...

2014-11-17 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-android/pull/129#issuecomment-63414867 The change in this file was already made; it was merged in three weeks ago as the fix for #131, which was also tracked as [CB-7726](https://issues.apache.org

[GitHub] cordova-android pull request: Add a section for plugin extensions

2014-11-18 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-android/pull/133#issuecomment-63485178 Note: This is related to apache/cordova-lib#119, which was merged in a few days ago. It provides the same lines in the default template that would be added by

[GitHub] cordova-plugin-file pull request: fixed setMetadata() to use the f...

2014-11-20 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/33#issuecomment-63851664 It's not included, because the master branch ended up evolving slightly differently. The patch for [CB-6393](https://issues.apache.org/jira/browse/CB

[GitHub] cordova-plugin-file pull request: Get rid of thread block error in...

2014-11-27 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/87#issuecomment-64823918 Hi -- Sorry that it's taken a while to get around to this. I think that (CB-5175)[https://issues.apache.org/jira/browse/CB-5175] is the main

[GitHub] cordova-plugin-camera pull request: When scaling the image, do not...

2014-11-27 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/48#issuecomment-64829588 This PR can be closed, I think. @ktsour, can you do that? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-plugin-geolocation pull request: BugFix Android installati...

2014-11-28 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/24#issuecomment-64895842 I don't think this is a bug -- see [CB-5977](https://issues.apache.org/jira/browse/CB-5977) for the discussion about removing the An

[GitHub] cordova-plugin-inappbrowser pull request: Send 'Activity not found...

2014-11-28 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/62#issuecomment-64897545 Thanks for this! I'm sorry that we can't pull this in as-is, because of all of the other commits on top of it. I might be able to cherrypi

[GitHub] cordova-plugin-media pull request: set on Error Listener for the m...

2014-11-28 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/38#issuecomment-64907907 Looks like a bug in the Android code -- thanks for the patch! Is there a JIRA issue for this at https://issues.apache.org/jira ? --- If your project is

[GitHub] cordova-plugin-media pull request: Add seekCompleteCallback to see...

2014-11-28 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/37#issuecomment-64910259 Certainly seems like a useful feature -- is there a JIRA issue for it yet? --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-plugin-media pull request: Fixed the problem with multiple...

2014-11-28 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/33#issuecomment-64910845 Is there a way to make this behaviour configurable? It looks like the original behaviour was deliberate, and there may be people whose apps depend on it

[GitHub] cordova-plugin-media pull request: Added fp.exists () false negati...

2014-11-28 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/27#issuecomment-64911566 It may have been a bug; I like the way that you've done it, though, regardless. Do you have an ICLA on file with Apache? I can't te

[GitHub] cordova-plugin-media pull request: Added parameter for additional ...

2014-11-28 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/24#issuecomment-64912553 Thanks for this, it looks like a useful feature -- can you file a feature request in JIRA? (https://issues.apache.org/jira) I'd love to be able to

[GitHub] cordova-plugin-media pull request: Progress report for Media plugi...

2014-11-28 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/22#issuecomment-64912841 That's great, @emilsedgh -- do you have an ICLA on file with Apache? I can't find your name on the list there, and we usually ask fo

[GitHub] cordova-plugin-media-capture pull request: CB-5202 fix from lubogo...

2014-11-28 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-media-capture/pull/13#issuecomment-64928561 This was committed some time ago: 0c7941fb. @mbillau, can you close this PR? --- If your project is set up for it, you can reply to this email and

[GitHub] cordova-plugin-media-capture pull request: CB-5202 fix from lubogo...

2014-11-28 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-media-capture/pull/13#issuecomment-64928592 The AVI issue is partially dealt with by #28, BTW. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-plugins pull request: Fix Keyboard Shrink View without Acc...

2014-12-01 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugins/pull/14#issuecomment-65078123 This looks good (although I'd like to see a test case at least, so I can verify that it works). Sorry for leaving it untouched for so long. Can you

[GitHub] cordova-plugin-geolocation pull request: [CB-5753] Do not stop upd...

2014-12-02 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/29#issuecomment-65302711 @tiff - Thanks for the fix! Do you have an ICLA on file with Apache? It's probably not necessary for something this size, but we generally re

[GitHub] cordova-android pull request: Add a section for plugin extensions

2014-12-08 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-android/pull/133#issuecomment-66168405 Sorry @fujunwei, I didn't realize this was blocking anything else. (I thought that the apache/cordova-lib#119 change would take care of most of the use

[GitHub] cordova-plugin-inappbrowser pull request: Added editablelocation o...

2014-12-11 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/73#issuecomment-66627952 Is there a JIRA issue for this? I'm not sure immediately if it's a new feature request, or if it's bringing Android in line with a

[GitHub] cordova-plugin-inappbrowser pull request: Added editablelocation o...

2014-12-11 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/73#issuecomment-66639516 Thanks :) It's certainly worth bringing up in JIRA. If people are interested in the feature, then we should add it (and try to get su

[GitHub] cordova-android pull request: Fix compile error when build multipl...

2014-12-15 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-android/pull/138#issuecomment-66997451 @fujunwei, what version of Gradle and the Android plugin are you using? (There are some compatibility issues between certain versions, and I want to make sure

[GitHub] cordova-android pull request: Fix compile error when build multipl...

2014-12-15 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-android/pull/138#issuecomment-66997624 @zhuangperola, the best place to report a problem is on JIRA, at https://issues.apache.org/jira/browse/CB You can create an account there and file a

[GitHub] cordova-android pull request: Fix compile error when build multipl...

2014-12-22 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-android/pull/138#issuecomment-67855743 I can reproduce it, if I set `ext.multiarch=true` inside of a Gradle build file, and don't use the `BUILD_MULTIPLE_APKS` environment variable. --- If

[GitHub] cordova-android pull request: Fix compile error when build multipl...

2014-12-22 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-android/pull/138#issuecomment-67862056 I think for now I'm just going to remove the lines in `build.js` which disable the lint steps -- eventually we should be moving the logic that defines

  1   2   3   4   5   6   7   8   >