[GitHub] cordova-ios pull request #324: CB-12966: (ios) Fix bug by escaping project n...

2017-06-28 Thread joshdholtz
GitHub user joshdholtz opened a pull request: https://github.com/apache/cordova-ios/pull/324 CB-12966: (ios) Fix bug by escaping project name in podfile template ### Platforms affected - iOS ### What does this PR do? - Fixes a bug when the project name has a single

[GitHub] cordova-ios issue #324: CB-12966: (ios) Fix bug by escaping project name in ...

2017-06-30 Thread joshdholtz
Github user joshdholtz commented on the issue: https://github.com/apache/cordova-ios/pull/324 @renatoalencar I have no idea why the tests are not passing. It seems like other tests aren't passing either. You can use this by doing something like... ``` ionic platfor

[GitHub] cordova-ios issue #324: CB-12966: (ios) Fix bug by escaping project name in ...

2017-07-11 Thread joshdholtz
Github user joshdholtz commented on the issue: https://github.com/apache/cordova-ios/pull/324 @shazron Rebased from master so that the tests and linter actually run and pass now. Also separated out the escaping of single quotes into its own function for better testing and added a

[GitHub] cordova-ios issue #324: CB-12966: (ios) Fix bug by escaping project name in ...

2017-07-17 Thread joshdholtz
Github user joshdholtz commented on the issue: https://github.com/apache/cordova-ios/pull/324 @shazron Rebased and updated coding styles 👌 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have