Re: [VOTE] Cordova-Electron 1.0.0 Release

2019-02-26 Thread Gearóid M
+1 * added to existing app, builds and runs * npm test * npm audit On Tue, 26 Feb 2019, at 01:44, Jesse wrote: > +1 > * coho verify-archive > * CI green > * npm test > * npm audit > * coho check-license > > @purplecabbage > risingj.com > > > On Sun, Feb 24, 2019 at 11:37 PM Bryan Ellis wrote:

Re: Nomination for a new chair for Apache Cordova

2018-12-07 Thread Gearóid M
+1 Thanks for your hard work steering Cordova. I think Jesse will do a great job continuing this role too. On Fri, 7 Dec 2018, at 17:31, kerrisho...@gmail.com wrote: > +1 > > Thanks for everything you’ve done for Cordova. Jesse will do an amazing > job, I have no doubt! > > Best, > ~ Kerri

Re: [dev] Introduce ES6 classes or not?

2018-11-30 Thread Gearóid M
I'm definitely in favour of using classes. Personally I find them easier to read and write. We are already using them in at least one place, the ProjectBuilder in cordova-android.[1] This came about from a refactor I did a few months ago, and since we dropped support for Node 6, it made sense

Re: Contributing to Cordova open source

2018-11-12 Thread Gearóid M
Hi Kalana, Welcome! It's always great to have new contributors to Cordova. If you're not sure where to get started, take a look at the Contributor Guide at https://cordova.apache.org/contribute/. There are also plenty of issues on GitHub which you could get started with. I'm looking forward to

Re: [VOTE] Cordova Android 7.1.2 Release

2018-11-06 Thread Gearóid M
+1 - created new project from Github tag, ran as expected - tests passing on 7.1.2 branch on Travis CI On Tue, 6 Nov 2018, at 06:43, Jesse wrote: > +1 > > - coho verify-archive > - CI green > - created a project, added cordova-android@7.1.2 ( via tagged repo ), ran > without issue > > > > >

Re: [proposal] Remove tool generated docs from camera plugin?

2018-10-30 Thread Gearóid M
+1 for simplicity and consistency with other readme files On Wed, 31 Oct 2018, at 09:40, Jesse wrote: > +1 to a hand written readme! > > @purplecabbage > risingj.com > > > On Tue, Oct 30, 2018 at 5:18 PM julio cesar sanchez > wrote: > > > Bumping this old thread again as I accidentally

Re: [DISCUSS] Supported iOS Versions

2018-08-31 Thread Gearóid M
, at 15:47, julio cesar sanchez wrote: > Ah, sorry, it was in 4.4.0 > > https://cordova.apache.org/announcements/2017/04/26/ios-release.html > > El El vie, 31 ago 2018 a las 1:21, Gearóid M > escribió:>> Ah I see, so the versioning is more of a documentation issue > then. I

[DISCUSS] Supported iOS Versions

2018-08-29 Thread Gearóid M
The topic of supported iOS version came up in a docs PR recently [1]. I was surprised to find that we still support iOS 8. I imagine if someone came along with an issue on iOS 8, we wouldn't bother fixing it. In the Android docs, we say "As a general rule, Android versions become unsupported

Re: [DISCUSS] [Github Issues] Support questions in GitHub issues

2018-08-11 Thread Gearóid M
I agree, Github issues should only be for bug reports and feature requests. For Onsen UI, we have an issue template [1], which specifically explains where to go for support. Additionally, the template is geared towards bug reporting, which further discourages people from asking for support. Of

Re: Dealing with deprecated repos

2018-08-07 Thread Gearóid M
+1 on archiving deprecated repos, it's an easy way to make it very clear that it is no longer maintained On Wed, 8 Aug 2018, at 01:37, Chris Brody wrote: > +1 > On Tue, Aug 7, 2018 at 11:32 AM julio cesar sanchez > wrote: > > > > Archived repos are read only. > > > > People can still clone

Re: Reviving Face-to-Face video meetings?

2018-07-18 Thread Gearóid M
Great idea, I'd like to get to know the Cordova contributors. I probably will not be available in the next few weeks, but I would like to join in in the future if it becomes a regular occurrence. On 2018/07/18 3:59, raphine...@gmail.com wrote: Definitely! Chris Brody schrieb am Di., 17.

Contributor Introduction

2018-05-18 Thread Gearóid M
Hi all, My name is Gearóid. I've been building apps with Cordova for many years, and am hoping to now start contributing to the project. I am currently working at Monaca, and I am also the maintainer of the Onsen UI framework. I have a lot of experience with Javascript, HTML and CSS, as well