Tizen

2014-07-24 Thread Schulhof, Gabriel
Hey! I've gotten my two remaining tizen-related PRs[0,1] up to par wrt. the CI. Awesome that there's a CI now! Could somebody please take the time to have a look at them? I've manually tested the workflow in terms of getting a cordova project to launch on the Tizen emulator, and, well, as they

Re: Tizen

2014-07-24 Thread Schulhof, Gabriel
Hey! Oops! Forgot to include the actual references *facepalm* :) https://github.com/apache/cordova-lib/pull/16 https://github.com/apache/cordova-lib/pull/17 Thanks for the heads-up! Gabriel

Re: Tizen update

2014-06-10 Thread Schulhof, Gabriel
Hey! Awesome! Thanks for letting me know! Gabriel

Tizen update

2014-06-09 Thread Schulhof, Gabriel
Hi, all! I've signed the ICLA and I've updated the PRs for the CLI and for plugman, so now they are against cordova-lib. https://github.com/apache/cordova-lib/pull/16 https://github.com/apache/cordova-lib/pull/17 Could someone please review them? TIA for your help, Gabriel

Re: Patches for Tizen support as gitHub PRs

2014-04-23 Thread Schulhof, Gabriel
Hey! On Thu, Apr 17, 2014 at 3:49 PM, Ian Clelland iclell...@chromium.org wrote: As far as I understand it, if the contributions are yours (and Salvatore's), as they appear to be from the commits, then you'll need to sign the ICLA. I've asked our legal folks whether it's OK for Salvatore and

Re: Patches for Tizen support as gitHub PRs

2014-04-17 Thread Schulhof, Gabriel
Hi! Salvatore and I both work at Intel. We already have a Cordova contributor: Paul Plaquette, who also works at Intel. He is the maintainer of cordova-tizen[0] for cordova-2.x. Unfortunately, his bandwidth towards Cordova has recently declined sharply, which is why he's asked Salvatore and me to

Tizen support in cordova-cli

2014-04-07 Thread Schulhof, Gabriel
Hi! I have an ongoing PR[0] to add Tizen support to cordova-cli. It is currently in a state where I believe I have addressed the reviewers' comments, and it should be good to land. Could someone please review it again? TIA for your help, Gabriel [0]

source-file, header-file, library, resource-file, and framework handler for platform

2014-04-01 Thread Schulhof, Gabriel
Hi! In [0] Anis explains that each platform has to provide a handler for installing/uninstalling at least files of the type source-file, even if they do nothing. Now, AIUI, source-file refers to adding platform-specific source code which ends up as native code (C#, java, objective C ,etc.). I

Tizen support

2014-03-17 Thread Schulhof, Gabriel
Hi! I've been talking with Anis Kadri and Steve Gill about adding Tizen support to Cordova. I've submitted some PRs to that effect. There's an interesting interplay of dependencies. Support for Tizen has to be present in a released version of cordova-plugman before Tizen support for cordova-cli

WP7 and WP8 x-wmapp URL scheme special casing

2014-03-17 Thread Schulhof, Gabriel
Hi! In jQuery Mobile we've encountered a bug[0] in the way Cordova parses these URLs. In fact, when XHRLOCAL notification handler receives an absolute URL such as, for instance, x-wmapp0://www/filename.html, it passes the path to the file reader incorrectly. The resulting path cannot be found,

Re: WP7 and WP8 x-wmapp URL scheme special casing

2014-03-17 Thread Schulhof, Gabriel
Hey! I've updated the patch a little, to make it work both on WP7 and WP8[0]. HTH, Gabriel [0] https://github.com/jquery/jquery-mobile/issues/6574#issuecomment-37879404