I vote +1
- created a project with the latest cordova and added cordova-windows#6.0.1 and
built and ran on desktop.
- checked the branch out and ran npm test.
On 10/4/18, 4:58 PM, "Jesse" wrote:
I vote +1
- ran coho verify-archive on release artifacts
- checked out the branch and ran `npm test`
- continuous build was green when repo was tagged
- created a project with latest released cordova tooling, added
cordova-windows#6.0.1, ran on desktop and phone
```
npm i -g cordova
cordova create ~/cb14226
cordova platform add
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-windows%236.0.1data=02%7C01%7Cvismishr%40adobe.com%7Cd3ba165dd9a5435915c708d62a5540f9%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636742942986049569sdata=%2F57Z038r7MzjFQDeWl6I9e5kmQcFJ%2BQeqHXphB5rLKM%3Dreserved=0
```
On Sun, Sep 16, 2018 at 2:33 PM Chris Brody wrote:
> Is there any way we can get a couple review votes on this patch
> release that I made in August?
> On Wed, Aug 1, 2018 at 2:56 AM Chris Brody wrote:
> >
> > Can I get a couple reviews on this one, cordova-osx@4.0.2, and
> > cordova-browser@5.0.4 in their respective [VOTE] threads?
> >
> > On Sun, Jul 29, 2018 at 10:56 PM Chris Brody
> wrote:
> > >
> > > Please review and vote on this 6.0.1 Windows patch release by replying
> > > to this email (and keep discussion on the DISCUSS thread).
> > >
> > > Release issue:
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FCB-14226data=02%7C01%7Cvismishr%40adobe.com%7Cd3ba165dd9a5435915c708d62a5540f9%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636742942986049569sdata=hr6Qka%2BbhwFyuXEMXX2UZ3VG30nzOpu1uHRMF1tnB%2FM%3Dreserved=0
> > >
> > > The archive has been published to dist/dev:
> > >
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Fcordova%2FCB-14226%2Fdata=02%7C01%7Cvismishr%40adobe.com%7Cd3ba165dd9a5435915c708d62a5540f9%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636742942986049569sdata=mJukQtwvyvynHFFMcn%2BdgXK3uniM6PwqTZ6LSU8qQuM%3Dreserved=0
> > >
> > > The package was published from its corresponding git tag:
> > >
> > > cordova-windows: 6.0.1 (cc4733ef64)
> > >
> > > Note that you can test it out via:
> > >
> > > cordova platform add
>
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-windows%236.0.1data=02%7C01%7Cvismishr%40adobe.com%7Cd3ba165dd9a5435915c708d62a5540f9%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636742942986049569sdata=%2F57Z038r7MzjFQDeWl6I9e5kmQcFJ%2BQeqHXphB5rLKM%3Dreserved=0
> > >
> > > Upon a successful vote I will upload the archive to dist/, publish it
> > > to npm, and post the blog post.
> > >
> > > Voting guidelines:
> > >
>
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-coho%2Fblob%2Fmaster%2Fdocs%2Frelease-voting.mddata=02%7C01%7Cvismishr%40adobe.com%7Cd3ba165dd9a5435915c708d62a5540f9%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636742942986049569sdata=j%2BmNrdEUbjatOBJIDqPY7UZ8KIBuZERaeaQ5JQrciVY%3Dreserved=0
> > >
> > > Voting will go on for a minimum of 48 hours.
> > >
> > > I vote +1:
> > > * Ran coho audit-license-headers over the relevant repos
> > > * Ran coho check-license to ensure all dependencies and
> > > subdependencies have Apache-compatible licenses
> > > * Ensured continuous build was green when repo was tagged
> > > * tested with cordova-sqlite-storage plugin using npm@2.15.11
> > > (packaged with node@4.9.1) and npm@5.6.0 (packaged with node@8.11.3) -
> > > more details in:
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-windows%2Fpull%2F287data=02%7C01%7Cvismishr%40adobe.com%7Cd3ba165dd9a5435915c708d62a5540f9%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636742942986049569sdata=aD01LPpxoBUT6dI4XJRhZKG6wjrdUmEUQ3%2FwcJMh8vo%3Dreserved=0
> > >
> > > Proposed blog post in:
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-docs%2Fpull%2F854data=02%7C01%7Cvismishr%40adobe.com%7Cd3ba165dd9a5435915c708d62a5540f9%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636742942986049569sdata=KuKKgiYxYwjZzpbqkvvITHpfat4%2BuHdiYOXkOb%2FfDJU%3Dreserved=0
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
