[GitHub] cordova-ios issue #265: CB-11952 - Introduce buildFlag option

2016-10-10 Thread adzellman
Github user adzellman commented on the issue: https://github.com/apache/cordova-ios/pull/265 @shazron All checks have passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-ios pull request #265: CB-11952 - Introduce buildFlag option

2016-10-10 Thread adzellman
GitHub user adzellman reopened a pull request: https://github.com/apache/cordova-ios/pull/265 CB-11952 - Introduce buildFlag option ### Platforms affected iOS ### What does this PR do? - adds buildFlag option for passing args to xcodebuild - There can

[GitHub] cordova-ios pull request #265: CB-11952 - Introduce buildFlag option

2016-10-10 Thread adzellman
Github user adzellman closed the pull request at: https://github.com/apache/cordova-ios/pull/265 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-ios issue #265: CB-11952 - Introduce buildFlag option

2016-10-07 Thread adzellman
Github user adzellman commented on the issue: https://github.com/apache/cordova-ios/pull/265 I'm not sure why Travis would fail to run `n stable`. I just tried it locally and it installed v6.6.0 just fine. Can we re-trigger Travis? --- If your project is set up for it, you can reply

[GitHub] cordova-ios pull request #265: CB-11952 - Introduce buildFlag option

2016-10-07 Thread adzellman
Github user adzellman commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/265#discussion_r82491459 --- Diff: bin/templates/scripts/cordova/lib/build.js --- @@ -199,33 +219,52 @@ module.exports.findXCodeProjectIn = findXCodeProjectIn; * @param

[GitHub] cordova-ios issue #265: CB-11952 - Introduce buildFlag option

2016-10-07 Thread adzellman
Github user adzellman commented on the issue: https://github.com/apache/cordova-ios/pull/265 @shazron Review comments addressed. Please re-review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-ios pull request #265: CB-11952 - Introduce buildFlag option

2016-10-06 Thread adzellman
GitHub user adzellman opened a pull request: https://github.com/apache/cordova-ios/pull/265 CB-11952 - Introduce buildFlag option ### Platforms affected iOS ### What does this PR do? - adds buildFlag option for passing args to xcodebuild - There can

[GitHub] cordova-ios issue #263: CB-11952 - Introduce buildFlag option

2016-10-06 Thread adzellman
Github user adzellman commented on the issue: https://github.com/apache/cordova-ios/pull/263 I'm going to clean this up and submit a new PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-ios pull request #263: CB-11952 - Introduce buildFlag option

2016-10-06 Thread adzellman
Github user adzellman closed the pull request at: https://github.com/apache/cordova-ios/pull/263 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-ios issue #263: CB-11952 - Introduce buildFlag option

2016-10-05 Thread adzellman
Github user adzellman commented on the issue: https://github.com/apache/cordova-ios/pull/263 Let me see if I can add some tests here. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-ios pull request #263: CB-11952 - Introduce buildFlag option

2016-10-05 Thread adzellman
GitHub user adzellman opened a pull request: https://github.com/apache/cordova-ios/pull/263 CB-11952 - Introduce buildFlag option ### Platforms affected iOS ### What does this PR do? - Add buildFlag option for passing args to xcodebuild - There can be multiple

[GitHub] cordova-plugin-dialogs pull request: CB-11218 Convert button list ...

2016-05-06 Thread adzellman
GitHub user adzellman opened a pull request: https://github.com/apache/cordova-plugin-dialogs/pull/76 CB-11218 Convert button list to appropriate type - If the buttons are passed in as a comma-separated string, then create an array with those values. JIRA: https

[GitHub] cordova-plugin-dialogs pull request: CB-11218 iOS: Handle single b...

2016-05-06 Thread adzellman
Github user adzellman closed the pull request at: https://github.com/apache/cordova-plugin-dialogs/pull/75 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-dialogs pull request: CB-11218 iOS: Handle single b...

2016-05-06 Thread adzellman
GitHub user adzellman opened a pull request: https://github.com/apache/cordova-plugin-dialogs/pull/75 CB-11218 iOS: Handle single button passed as string - If the buttons are passed in as a string, then create an array with that string as the only value. JIRA

[GitHub] cordova-plugin-media-capture pull request: CB-11212 iOS: Explicitl...

2016-05-05 Thread adzellman
GitHub user adzellman opened a pull request: https://github.com/apache/cordova-plugin-media-capture/pull/61 CB-11212 iOS: Explicitly set the bundle for images - set the bundle to the CDVCapture's bundle instead of assuming application bundle. You can merge this pull request