[GitHub] cordova-plugin-inappbrowser issue #219: [CB-9148] (android) add setType() me...
Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/219 Agree with @jcesarmobile, this should have a new JIRA associated with this issue. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #221: CB-12834: (android) Fix bug when ope...
Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/221 CRAP, this was a typo. @RafaelKr can you re-open this one? I meant to close #201 --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #185: iOS friendlier UI
Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/185 Can you create JIRA issue to correspond to this PR? That's one of the things that is holding up this PR. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #173: Add property enablepictureinpicture ...
Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/173 Can you add a JIRA issue to this PR? Thanks! --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #172: [CB-5758] (android/iOS) Possibility ...
Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/172 Please re-do this PR, and please don't change the plugin.xml to be based on your repository. There are too much history dragged in from the repo to accept this PR as-is. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #166: Fix for - Stretched tool-bar icons
Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/166 Agreed, this does look weird, but should we be hard coding this, or is there a better solution for this? (i.e. resizing the buttons) --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #165: Enable thirdparty cookies on >=Andro...
Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/165 This needs a JIRA issue attached to it. I don't see any conflicts, however. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #159: Adding more configuration options fo...
Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/159 There's no proposal in the cordova repo, nor is there a JIRA issue regarding this feature addition. There needs to be these things before we can add this API change to the plugin. That, and the conflicts with README due to the docs being updated are what's holding this PR back. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #156: send back loaderror when "show" fail...
Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/156 Closing this issue, since it should be sending the error as a plugin result on the Callback instead of sending a random JSON object. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #122: Added Android cookie sharing functio...
Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/122 So, is this functionality not working? It would help if there was a JIRA issue attached to this PR. I don't see XWalk functionality being a huge issue since XWalk is no longer being maintained. Because of that, it's more likely this will get pulled in. However, it'd be helpful if someone could tell me if this actually works before I get around to testing it. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #116: Added support for file:/// access
Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/116 Closing this PR as abandoned, since it's been over a year since @shazron last checked in on this. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #115: Support for passing request headers ...
Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/115 This is an API change and should be discussed on the list, or at the very least have a JIRA issue attached to it. Also, the conflicts are definitely going to prevent this from getting merged as-is. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #111: give the ability to trust a certific...
Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/111 This has the following wrong with it: 1. You changed the package.json 2. You don't have a JIRA issue attached to this 3. There are other conflicts with the current InAppBrowser code. If you are still interested in contributing, please fix these issues, and we can then take a look at this. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #99: inAppBrowser custom application schem...
Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/99 The code changes in iOS are delaying this. That being said, I don't know if blindly adding Application URIs in an InAppBrowser is a good idea in this case. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #88: CB-3750: Add loading spinner for andr...
Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/88 This still needs to merge cleanly to be added. Please fix all the conflicts to add this code if you are still interested in adding this PR. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #87: CB-8552 Add toolbar option for androi...
Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/87 @cjpearson Are you still interested in contributing this? Can you fix the merge conflicts in this PR? Thanks --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #77: Android enhancements
Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/77 You can't change the name of the plugin. This code is also old and conflicts with the repo, so this PR will be closed. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #73: Added editablelocation option for and...
Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/73 This is a Won't Fix because you aren't supposed to be able to change the URI on the Address Bar of the InAppBrowser. Closing because this is a "Won't Fix" and because this has conflicts and is old. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #62: Send 'Activity not found' as an error...
Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/62 Closing this PR since it's got too many random commits on it as @clelland has mentioned earlier. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #399: CB-12730: Compat - INTEGRATE
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/399 @filmaj Another being this article https://medium.com/exploring-android/handling-android-runtime-permissions-in-ui-tests-981f9dc11a4e --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #399: CB-12730: Compat - INTEGRATE
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/399 We should add some instrumentation native tests for this, but I have no idea how that would work, and would have to do more research into this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen issue #130: CB-13094: (android) Don't show splas...
Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/130 Going to about:blank is done as a garbage collection technique before closing out the WebView entirely so that the memory is freed. There's a hilarious TODO here saying that it shouldn't destroy the WebView until about:blank is done loading. But yeah, I agree with the fix. The Splashscreen shouldn't try to attach a UI element to the Activity while the Activity is basically killing itself on a backbutton, or some other exit event, and that's clearly what's causing this behaviour. Of course, if we never made this a plugin in the first place, we wouldn't have such a weird disconnect between this plugin and the platform code, so there is that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #396: CB-12677: (android) added option for explicitly ...
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/396 Did you see the fix @purplecabbage did to pull this info from the Windows registry for Windows users? We're probably going to go with that solution for Windows because of the whole PATH issue. Mac OS and Linux users are able to install Gradle without a problem. There are already other issues with using or requiring Android Studio as a dependency, such as the fact that some people don't ever use the IDE --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #396: CB-12677: (android) added option for explicitly ...
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/396 We are going to make Gradle a requirement. Using Android Studio's copy of Gradle was a stop-gap solution to get builds working again, and we should really stop doing this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #310: [CB-10916] Support display name for Android
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/310 This appears to have fell by the wayside. Why hasn't this been pulled into cordova-android? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #393: Fix for Jira issue CB-12981
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/393 This somehow broke the project creation test. Can you figure out what happened with your PR that caused this to break? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #395: CB-12423: make explicit JDK 1.8 or greater is ne...
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/395 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #389: CB-11244: Studio Project Compatibility: Now with...
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/389 @filmaj Hard copied paths? SRSLY? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #389: CB-11244: Studio Project Compatibility: Now with...
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/389 @filmaj Given how old this branch is, those are the same tests that master was running until three commits ago. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #389: CB-11244: Studio Project Compatibility: Now with...
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/389 @filmaj So, I should do another merge commit just to get more tests? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #389: CB-11244: Studio Project Compatibility: Now with...
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/389 The merge commit that I did was e456175a --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #389: CB-11244: Studio Project Compatibility: Now with...
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/389 @filmaj Github says otherwise. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #391: CB-12950: E2E test tweaks + Appveyor now runs E2...
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/391 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera issue #274: CB-12593: (android) Fix potential FileProv...
Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/274 THIS IS BRILLIANT! Why is this a closed issue? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #385: CB-12835: add a Context getter in CordovaInterfa...
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/385 @filmaj Yeah, that definitely needs an update. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #362: CB-12453: Remove unnecessary double quotes from ...
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/362 @filmaj Can you look at this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request #384: CB-11244: Studio project cleanup
Github user infil00p commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/384#discussion_r124071629
--- Diff: bin/lib/create.js ---
@@ -259,41 +273,53 @@ exports.create = function(project_path, config,
options, events) {
setShellFatal(true, function() {
var project_template_dir = options.customTemplate ||
path.join(ROOT, 'bin', 'templates', 'project');
+var app_path = path.join(project_path, 'app', 'src', 'main');
--- End diff --
The plan is to support managing the old and existing structures while only
being able to create new structures for the time being. Of course, there's a
debate on how update works, and we may just toss the structure altogether. Who
knows?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #384: CB-11244: Studio project cleanup
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/384 We're going to keep working on #389, closing this old branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request #384: CB-11244: Studio project cleanup
Github user infil00p closed the pull request at: https://github.com/apache/cordova-android/pull/384 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request #389: CB-11244: Studio Project Compatibility: N...
GitHub user infil00p opened a pull request: https://github.com/apache/cordova-android/pull/389 CB-11244: Studio Project Compatibility: Now with merge commit ### Platforms affected Android ### What does this PR do? This PR is the new current working PR for the Studio Project work ### What testing has been done on this change? Tested against the CI tests, more tests need to be added. ### Checklist - [x ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/infil00p/cordova-android StudioProjectCompat Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-android/pull/389.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #389 commit d88df59c32ae7d1a55729477f5a22d9e7b4df111 Author: Joe Bowser <bows...@apache.org> Date: 2017-03-30T19:41:44Z Adding the Studio Builder to build a project based on Android Studio, and deleting Ant, since Google does not support Ant Builds anymore. Sorry guys! commit 23d8d999257f9cf1331d81489c96f00fa134b3b5 Author: Joe Bowser <bows...@apache.org> Date: 2017-03-30T20:38:18Z Moving Android Manifest finding to the Gradle and Studio builders. commit ffadf5dd51767c2f2697ad9e1ba34cf44d652145 Author: Joe Bowser <bows...@apache.org> Date: 2017-04-03T22:21:48Z Changing this so we pass lint commit 7b17abc5553ca14f69081a2175f787d4a0550f0f Author: Joe Bowser <bows...@apache.org> Date: 2017-04-04T20:38:40Z Fixing linting issues commit f790aeb8f677eb047ce6e82fceaeb814cfc9d4fc Author: Joe Bowser <bows...@apache.org> Date: 2017-04-04T22:18:46Z Setting up the create command so we actually have all the directories in the right place, and define default variables in the top level build.gradle commit b73c04f3c8424e6db57c3bb98c550cd4d976f473 Author: Joe Bowser <bows...@apache.org> Date: 2017-04-04T22:34:42Z Updating gradle version in the build file commit 8ead919faea814e86e8f665e9122a35bcd82d869 Author: Joe Bowser <bows...@apache.org> Date: 2017-04-04T22:42:58Z Managed to get the project to mostly compile, still need to re-work the build command to add the app project commit db87e0ae6a25d8a337d10b41cb46574e2cb987b0 Author: Joe Bowser <bows...@apache.org> Date: 2017-04-11T20:47:40Z Made changes so cordova/build builds with the new project. Need to work on plugin installation. commit a216f0db751778953224067f25b8e0077bb7e760 Author: Joe Bowser <bows...@apache.org> Date: 2017-01-04T19:48:18Z CB-11244: Changing directory creation, will most likely hide this behind a flag for the next release of Cordova-Android, and then make it default in the next major pending feedback commit 69260fb96a8d606549caa8880abc5e7b444c4621 Author: Joe Bowser <bows...@apache.org> Date: 2017-04-11T21:41:27Z Fix the overwriting of Fil's fix, blargh commit 69ab6a0e0d70e56c6fe0fe7529a211c51df09ab7 Author: Joe Bowser <bows...@apache.org> Date: 2017-04-18T21:29:02Z Changing the project to add the app directory as a dependency commit 8391af2e8f6d9bdab102f28c58f257b8b53d0c0f Author: Joe Bowser <bows...@apache.org> Date: 2017-04-18T21:48:56Z JsHint Fixes, deleting unused methods commit 304a8991140f3f1ed76a9816b1a4d701537f89ea Author: Joe Bowser <bows...@apache.org> Date: 2017-04-19T18:50:55Z Fixed the specification of the builders in the run command by getting build to check what was being passed from run commit e621edfba755d31915da29a6113b0be2db56735f Author: Joe Bowser <bows...@apache.org> Date: 2017-04-21T23:27:26Z Fixing the Android Studio detection and making it automatically pick the right builder, good for upgrading Cordova commit bd4ddcdeddf7a5b232023c4f53b60d2ab20e7a48 Author: Joe Bowser <bows...@apache.org> Date: 2017-04-22T00:02:27Z Updated AndroidStudio to only look for the app directory to determine studio status commit 28ebbb8f024f31a627af6b26ba23e41e7ce22f65 Author: Joe Bowser <bows...@apache.org> Date: 2017-05-31T17:23:35Z CB-11244: Setup Api.js to support multiple builders based on project structure commit fb6cb51e64a2ea05ba65195023b702fb00b378c2 Author: Joe Bowser <bows...@apache.org> Date: 2017-05-31T17:37:47Z Fixing lint errors commit 8f16df4c90bd4a9ea64f537d85db5ce6069b5c04 Author: Joe Bowser <bows...@apache
[GitHub] cordova-android pull request #384: CB-11244: Studio project cleanup
Github user infil00p commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/384#discussion_r123844605
--- Diff: bin/lib/create.js ---
@@ -125,16 +131,24 @@ function writeProjectProperties(projectPath,
target_api) {
fs.writeFileSync(dstPath, data);
}
-function prepBuildFiles(projectPath) {
+// This makes no sense, what if you're building with a different build
system?
--- End diff --
We're already doing that in the next two lines?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #386: CB-12895 : added eslint and removed jshint / ref...
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/386 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #387: CB-12605 In Windows get Android studio path from...
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/387 LGTM, pulling in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs issue #712: CB-11373 - document config.xml widget attributes an...
Github user infil00p commented on the issue: https://github.com/apache/cordova-docs/pull/712 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request #384: CB-11244: Studio project cleanup
GitHub user infil00p opened a pull request: https://github.com/apache/cordova-android/pull/384 CB-11244: Studio project cleanup ### Platforms affected Android ### What does this PR do? Modernizes Android and makes it so we can do Modern Android Development ### What testing has been done on this change? * Manual Testing with Plugman * Dev against e2e tests (upgrade still fails, help plz) * Talked to Fil regarding JUnit Test running ### Checklist - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/infil00p/cordova-android StudioProjectCleanup Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-android/pull/384.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #384 commit 6167130bac0630f8a8359ed491381caa7da45871 Author: Joe Bowser <bows...@apache.org> Date: 2017-03-30T19:41:44Z Adding the Studio Builder to build a project based on Android Studio, and deleting Ant, since Google does not support Ant Builds anymore. Sorry guys! commit 2ef15bd2172f265c44b8447a8e2f119d1590fda3 Author: Joe Bowser <bows...@apache.org> Date: 2017-03-30T20:38:18Z Moving Android Manifest finding to the Gradle and Studio builders. commit 09a4ed45ec2c959a5424c85d1e3df04f344eb664 Author: Joe Bowser <bows...@apache.org> Date: 2017-04-03T22:21:48Z Changing this so we pass lint commit 5a40dcd86ed8bd21ca611a66ee13170bed099739 Author: Joe Bowser <bows...@apache.org> Date: 2017-04-04T20:38:40Z Fixing linting issues commit 3795b65bced7c8634cade5f00bfe2d42349250c9 Author: Joe Bowser <bows...@apache.org> Date: 2017-04-04T22:18:46Z Setting up the create command so we actually have all the directories in the right place, and define default variables in the top level build.gradle commit f2396de53e250cd0ad9b8bb2020ce11eaef16ffe Author: Joe Bowser <bows...@apache.org> Date: 2017-04-04T22:34:42Z Updating gradle version in the build file commit 02c07de746b39a587613b531e3fbdcb833d442e9 Author: Joe Bowser <bows...@apache.org> Date: 2017-04-04T22:42:58Z Managed to get the project to mostly compile, still need to re-work the build command to add the app project commit c8f328fe2a9b6d05ad543b32989182bb612e9d0a Author: Joe Bowser <bows...@apache.org> Date: 2017-04-11T20:47:40Z Made changes so cordova/build builds with the new project. Need to work on plugin installation. commit 7db18f8b361369d10237f5159154dbae3f0c3f4d Author: Joe Bowser <bows...@apache.org> Date: 2017-04-11T21:41:27Z Fix the overwriting of Fil's fix, blargh commit cc2d1fd9ae59e5aca10ff5271ef637b6b6897eee Author: Joe Bowser <bows...@apache.org> Date: 2017-01-04T19:48:18Z CB-11244: Changing directory creation, will most likely hide this behind a flag for the next release of Cordova-Android, and then make it default in the next major pending feedback commit 844dc7f3df7f830cf562535ef9f5f5fc15471ca1 Author: Joe Bowser <bows...@apache.org> Date: 2017-04-18T21:29:02Z Changing the project to add the app directory as a dependency commit 2df146df4f918067eb325ca1d50639045f5003ed Author: Joe Bowser <bows...@apache.org> Date: 2017-04-18T21:48:56Z JsHint Fixes, deleting unused methods commit c1ea8ec88576586a7385dd06d5d62897f9142b4e Author: Joe Bowser <bows...@apache.org> Date: 2017-04-19T18:50:55Z Fixed the specification of the builders in the run command by getting build to check what was being passed from run commit 17416dfd1df16da9b4c0715ec6280961c7b9d91b Author: Joe Bowser <bows...@apache.org> Date: 2017-04-21T23:27:26Z Fixing the Android Studio detection and making it automatically pick the right builder, good for upgrading Cordova commit e30968e15a8aadbc6cc20d4b483f27f1c580ac15 Author: Joe Bowser <bows...@apache.org> Date: 2017-04-22T00:02:27Z Updated AndroidStudio to only look for the app directory to determine studio status commit a17a5b891f98417d149bacbf8307412fa8c03a34 Author: Joe Bowser <bows...@apache.org> Date: 2017-05-31T17:23:35Z CB-11244: Setup Api.js to support multiple builders based on project structure commit a5ca7089eaa2e8825dca9f7c2140c2f62b5d618c Author: Joe Bowser <bows...@apache.org> Date: 2017-05-31T17:37:47Z Fixing lint errors --- If your project is set up for it, you can repl
[GitHub] cordova-android issue #380: Upgrade build jdk from 6 to 7
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/380 I think this should be discussed on the list. There's upsides and downsides to this, and it could attract more developers to adopt JDK 7 and newer Java features. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #378: Start of GradleBuilder.js specs
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/378 I can't cleanly merge this, it looks like it's already in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #283: CB-10897 Refactor URI Parsing for Whitelist
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/283 This is closed as abandoned. It's sad, because asking for tests shouldn't cause anything to become abandoned. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #380: Upgrade build jdk from 6 to 7
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/380 Yeah, I'm not sure this is such a great plan. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera issue #257: CB-12593: (android) move management of Fil...
Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/257 @cjpearson After reading this, I can see this issue appearing even if we do move the management into cordova-android. This is a tooling issue that we're going to have to handle. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #374: CB-12646: Fix the parsing `android` command oupu...
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/374 The PR should not be against the 6.2.x branch, closing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request #375: CB-12657 android: fixed android 4.3 exit ...
Github user infil00p commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/375#discussion_r114163718
--- Diff: framework/src/org/apache/cordova/engine/SystemWebViewEngine.java
---
@@ -326,6 +329,12 @@ public void setPaused(boolean value) {
@Override
public void destroy() {
webView.chromeClient.destroyLastDialog();
+nativeToJsMessageQueue.reset();
--- End diff --
Why are we resetting the nativeToJsMessageQueue on destroy? We may want to
send some events before we kill the WebView.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request #375: CB-12657 android: fixed android 4.3 exit ...
Github user infil00p commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/375#discussion_r114163459
--- Diff: framework/src/org/apache/cordova/engine/SystemWebViewEngine.java
---
@@ -326,6 +329,12 @@ public void setPaused(boolean value) {
@Override
public void destroy() {
webView.chromeClient.destroyLastDialog();
+nativeToJsMessageQueue.reset();
+ViewGroup vgParent = (ViewGroup) webView.getParent();
--- End diff --
Shouldn't we remove the webView's child views BEFORE removing the WebView?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-device issue #62: CB-12623: (android) access Context through ...
Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-device/pull/62 @filmaj Not sure. I'm not sure what the reporter is trying to do here. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen issue #125: CB-12626: (android) Fix crash on Sam...
Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/125 @Lazza Which Samsung Devices would have this problem? Would a Samsung Galaxy S3 to S8 have this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-statusbar issue #77: CB-10879: (android) Enable overlaysWebVi...
Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/77 BTW: I agree with the original author about reflection not being in Android. I think that adding reflection for compile-time bugs is one of the worst things ever, like drowning puppies or kicking kittens. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-device-orientation issue #34: CB-12667 android: Added logic f...
Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-device-orientation/pull/34 @matrosov-nikita Which Samsung devices are affected? All of them? Only the Samsung Galaxy S3/4/5? If we could get more info on that, we can test for this and try and make there there's no regressions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-geolocation issue #85: Android: handle location service is of...
Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-geolocation/pull/85 Why are you returning no error message when you're sending back the ILLEGAL_ACCESS error when the permission is denied? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #215: CB-12560: (android) fix null pointer...
Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/215 @dblood OK, so what do I need to do to test this thing to verify this works? Do you have a monitor script available somewhere? Please don't check off the last box if there's no way to actually test this, it just gets our hopes up. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera issue #257: CB-12953: (android) move management of Fil...
Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/257 I can't find the issue in JIRA. At any rate, I don't think we should pull this in right now, and I think that we should probably move this into the android platform source in the future. Is there a specific use case that needs this plugin currently? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera issue #262: fix(error): changes error message for ios ...
Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/262 Based on what I'm seeing here, it really shouldn't say "Camera cancelled" because you're selecting an image from the gallery, not taking a picture. They both should say "Selection cancelled" or "No Image selected". --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #215: CB-12560: (android) fix null pointer...
Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/215 What tests have you added? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-device issue #62: CB-12623: (android) access Context through ...
Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-device/pull/62 The CordovaWebView object is not actually an Android WebView, so this actually shouldn't be done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #373: Support for SDK Tools v26, simplified target par...
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/373 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request #691: CB-12609: added android@6.2.0 release blog p...
Github user infil00p commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/691#discussion_r109232693 --- Diff: www/_posts/2017-03-31-android-release.md --- @@ -0,0 +1,38 @@ +--- +layout: post +author: +name: Steve Gill +url: https://twitter.com/stevesgill +title: "Cordova Android 6.2.0 Released!" +categories: announcements +tags: news releases +--- + +We are happy to announce that `Cordova Android 6.2.0` has been released! + +This release has fixed issues introduced by the **Android SDK Tools 25.3.1** release. **Google** dropped support for the `android` binary, so `cordova-android` has now adopted support for the `avdmanager` and `sdkmanager` binaries. We have also taken the opportunity to rewrite how we use gradle on the users system. --- End diff -- We should explicitly state here that we now require either Gradle or Android Studio to be installed, since our old configuration didn't require either of these things to be installed previously. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request #691: CB-12609: added android@6.2.0 release blog p...
Github user infil00p commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/691#discussion_r109232446 --- Diff: www/_posts/2017-03-31-android-release.md --- @@ -0,0 +1,38 @@ +--- +layout: post +author: +name: Steve Gill +url: https://twitter.com/stevesgill +title: "Cordova Android 6.2.0 Released!" +categories: announcements +tags: news releases +--- + +We are happy to announce that `Cordova Android 6.2.0` has been released! + +This release has fixed issues introduced by the **Android SDK Tools 25.3.1** release. **Google** dropped support for the `android` binary, so `cordova-android` has now adopted support for the `avdmanager` and `sdkmanager` binaries. We have also taken the opportunity to rewrite how we use gradle on the users system. + +This release also adds support for the `` element in `config.xml` which copies specified files during a `cordova prepare`. This allows providing arbitrary files such as special notification-sized icons, or API configuration JSON files. + +To upgrade: + +npm install -g cordova +cd my_project +cordova platform update android@6.2.0 + +To add it explicitly: + +cordova platform add android@6.2.0 + +This release will have to be explicitly added until the upcoming `cordova@7` release, where it will be pinned as the default android platform. + + +## What's new in Android +* [CB-12614](https://issues.apache.org/jira/browse/CB-12614) Adding headers to tests +* [CB-8978](https://issues.apache.org/jira/browse/CB-8978) Prepare copy `resource-files` from `config.xml` +* [CB-12605](https://issues.apache.org/jira/browse/CB-12605) Fix a requirements check failure on **Windows** +* [CB-12595](https://issues.apache.org/jira/browse/CB-12595) This should find an **Android Studio** installation and use the sweet gradle center found inside +* [CB-12546](https://issues.apache.org/jira/browse/CB-12546) leverage `avdmanager` if `android` warns it is no longer useful, which happens in **Android SDK Tools 25.3.1**. Explicitly set the `CWD` of the spawned emulator process to workaround a recent google android sdk bug. Rename `android_sdk_version.js` to `android_sdk.js`, to better reflect its contents. Have `create.js` copy over the `android_sdk_version` batch file. +* [CB-12524](https://issues.apache.org/jira/browse/CB-12524) Fix for missing gradle template error. This now fetches the template from inside of the **Android Studio** directory, and falls back to a locally installed Gradle instance --- End diff -- Explicitly state that Gradle or Android Studio are required in the blog post. This is a change, since we used to just require the Android SDK --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #371: CB-12574 - Bumping Version
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/371 Actually, it did. GitHub is being weird. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request #371: CB-12574 - Bumping Version
Github user infil00p closed the pull request at: https://github.com/apache/cordova-android/pull/371 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #371: CB-12574 - Bumping Version
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/371 Blargh. This didn't actually land into master. Sorry guys, this will be in the next patch release. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request #371: CB-12574 - Bumping Version
GitHub user infil00p opened a pull request: https://github.com/apache/cordova-android/pull/371 CB-12574 - Bumping Version ### Platforms affected ### What does this PR do? ### What testing has been done on this change? ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/infil00p/cordova-android master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-android/pull/371.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #371 commit 362e2b724b97d0445a9ed9dd890e8303b173db7a Author: Joe Bowser <bows...@apache.org> Date: 2017-03-15T20:19:58Z CB-12574 - Bumping Version --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #370: CB-12595: Fix Android Studio Detection (may need...
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/370 @PierBover Based on the information provided in your issue, it's very unlikely that your issue was caused by this pull request. The issue is related to compilation, not Javascript or Javascript bridge execution, which is what the log you have is currently showing. I would recommend downgrading to the latest released version of Cordova and the Android Tools and seeing if the problem persists. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #304: fix crash when calling methods on a destroyed we...
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/304 1. We need a JIRA for this 2. This has become more interesting since we need to add an Android O version of this code to handle it better, because the renderer goes away, not the whole webview now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #370: CB-12595: Fix Android Studio Detection (may need...
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/370 @filmaj I don't think it matters since we're overwriting whatever gradle-wrapper specifies with our own version of Gradle location anyway because we can't guarantee the version of Gradle (because of the Apache requirement to not bundle our own gradle-wrapper.jar). All gradle has to do is install the gradle wrapper. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #337: CB-11935 Call onPause & onResume on WebView
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/337 https://issues.apache.org/jira/browse/CB-12601 is the bug for this new issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #337: CB-11935 Call onPause & onResume on WebView
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/337 It's obviously a bug, and we should probably make sure the pause event fires before we pause the timers somehow, since it's clear there's a threading issue. That said, broken apps in the store are better than no apps in the store. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #337: CB-11935 Call onPause & onResume on WebView
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/337 Sorry, but this is more important than the pause event, this stays. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #370: CB-12595: Fix Android Studio Detection (may need...
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/370 @filmaj The reason we didn't do the same thing for Linux is because: 1. Android Studio could literally be installed anywhere on Linux. (No, seriously. The instructions for installing Canary are crazy vague) 2. Linux users know how to install Gradle on their platforms. 3. Linux users are an edge case, and they don't need the hand-holding that Windows and Mac users have come to expect. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request #370: CB-12595: Fix Android Studio Detection (m...
GitHub user infil00p reopened a pull request: https://github.com/apache/cordova-android/pull/370 CB-12595: Fix Android Studio Detection (may need refactoring) ### Platforms affected Android ### What does this PR do? Allows for the installation of multiple versions of Android Studio on a system without breaking the Cordova Build. ### What testing has been done on this change? Tested it on local machine. ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/infil00p/cordova-android CB-12595 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-android/pull/370.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #370 commit 64ad1f386469e588ffb5da9acc616c016dfc9ee7 Author: Joe Bowser <bows...@apache.org> Date: 2017-03-21T23:07:42Z CB-12595: Ugly code, but this should find an Android Studio installation and use the sweet gradle center found inside commit 89eb28c4ca264bbac3bfec26ea14fd5d14a54cc2 Author: Joe Bowser <bows...@apache.org> Date: 2017-03-21T23:14:40Z CB-12595: Just because it generates the project doesn't mean it builds. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request #370: CB-12595: Fix Android Studio Detection (m...
Github user infil00p closed the pull request at: https://github.com/apache/cordova-android/pull/370 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request #370: CB-12595: Fix Android Studio Detection (m...
GitHub user infil00p opened a pull request: https://github.com/apache/cordova-android/pull/370 CB-12595: Fix Android Studio Detection (may need refactoring) ### Platforms affected Android ### What does this PR do? Allows for the installation of multiple versions of Android Studio on a system without breaking the Cordova Build. ### What testing has been done on this change? Tested it on local machine. ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/infil00p/cordova-android CB-12595 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-android/pull/370.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #370 commit 64ad1f386469e588ffb5da9acc616c016dfc9ee7 Author: Joe Bowser <bows...@apache.org> Date: 2017-03-21T23:07:42Z CB-12595: Ugly code, but this should find an Android Studio installation and use the sweet gradle center found inside --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request #368: CB-12574 - Bumping Version
GitHub user infil00p opened a pull request: https://github.com/apache/cordova-android/pull/368 CB-12574 - Bumping Version ### Platforms affected Android ### What does this PR do? Bumps Gradle Version ### What testing has been done on this change? ### Checklist - [x ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/infil00p/cordova-android master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-android/pull/368.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #368 commit 362e2b724b97d0445a9ed9dd890e8303b173db7a Author: Joe Bowser <bows...@apache.org> Date: 2017-03-15T20:19:58Z CB-12574 - Bumping Version --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #366: CB-12546: More robust support spawning the emula...
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/366 This doesn't work in Windows, so there's still work to be done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #367: CB-12524: Working around Android SDK update by f...
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/367 OK, it passes here: https://travis-ci.org/infil00p/cordova-android, so it's time to tidy this up and merge this in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #367: CB-12524: Working around Android SDK update by f...
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/367 SoI had to delete a test that no longer will ever pass thanks to the Android SDK tools, and the other problem we're running into now is that we DO in fact require Gradle to be higher than 2.14, and it doesn't matter when we update the wrapper, due to build.grade having the android plugin instantiated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #367: CB-12524: Working around Android SDK update by f...
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/367 Tested against a Linode box with Android Tools updated to latest and Gradle Installed: (via http://exponential.io/blog/2015/03/30/install-gradle-on-ubuntu-linux/) I have no idea how to get this to work on Travis, though! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #366: CB-12546: More robust support spawning the emula...
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/366 @filmaj This needs to at least pass Appveyor before I we should really look at it. I'm sure it works, but jshint is showing a lot of quote errors. (Related: I've been burned by this more times than I can count, maybe we should get rid of this check?) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request #367: CB-12524: Working around Android SDK upda...
Github user infil00p commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/367#discussion_r105255990
--- Diff: bin/lib/check_reqs.js ---
@@ -78,21 +79,46 @@ module.exports.check_ant = function() {
});
};
+module.exports.get_gradle_wrapper = function() {
+var androidStudioPath;
+if(os.platform() == "darwin") {
--- End diff --
@dpogue Honestly, we're just installing the wrapper, so any will work. I
wanted to delete
https://github.com/apache/cordova-android/blob/master/bin/templates/cordova/lib/builders/GradleBuilder.js#L187
for a while, since it replaces everything with an old version of Gradle that
just gets updated anyway, but we might just have to keep it in and update it to
the latest Gradle supported.
FYI: My homebrew keeps fetching 2.2, and Android Studio 2.3 is packaged
with 3.2 on my Windows and Mac partitions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request #367: CB-12524: Working around Android SDK upda...
Github user infil00p commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/367#discussion_r105252250
--- Diff: bin/lib/check_reqs.js ---
@@ -78,21 +79,46 @@ module.exports.check_ant = function() {
});
};
+module.exports.get_gradle_wrapper = function() {
+var androidStudioPath;
+if(os.platform() == "darwin") {
--- End diff --
I have no idea where Android Studio is installed on a Linux box. It
literally could be anywhere! If you're not using Android Studio, you HAVE to
have Gradle installed. It's either one or the other from here on out.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #365: CB-12524: Fix the GradleBuilder so that it build...
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/365 @csantanapr The .gitignore prevents us from committing JARs. This PR didn't even work because we didn't distribute the JAR. We're not allowed to distribute a JAR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #367: CB-12524: Working around Android SDK update by f...
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/367 Ah, how did that rogue commit get in there. I'll be doing some git gardening before merging this, FYI --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request #367: CB-12524: Working around Android SDK upda...
GitHub user infil00p opened a pull request: https://github.com/apache/cordova-android/pull/367 CB-12524: Working around Android SDK update by finding Gradle in Android Studio itself, if that fails, we look for a locally installed Gradle ### Platforms affected Android ### What does this PR do? This PR allows Cordova users to be able to build Android projects again using the platform CLI tools. ### What testing has been done on this change? Testing has been done on the build scripts to make sure things work, but testing on the CLI integration still needs to be done. ### Checklist - [ x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [ x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/infil00p/cordova-android android_sdk_fixes Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-android/pull/367.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #367 commit 78c5a54e5f255aab205ecbc72047b5cce9f18a66 Author: Joe Bowser <bows...@apache.org> Date: 2017-03-06T23:03:32Z We're distributing a wrapper in the framework directory commit 9469d11669fcf6ef4342954d46722144c9f36731 Author: Joe Bowser <bows...@apache.org> Date: 2017-03-06T23:55:22Z CB-12524: Updating gradle to just grab the wrapper from the framework directory for building commit 4502e3253783425eda5cff881e48f4d58de88e3e Author: Joe Bowser <bows...@apache.org> Date: 2017-03-07T22:29:02Z CB-12524: Create script needs to copy the wrapper from the framework directory to the CordovaLib directory. This means you can compile an AAR out of any of the projects if you wanted. commit 8c01438e16ad1403e9eb54d1870bbc8371458343 Author: Joe Bowser <bows...@apache.org> Date: 2017-03-09T02:09:49Z CB-12524: This now fetches the template from inside of the Android Studio directory, and falls back to a locally installed Gradle instance commit a4fa4b79fc6a8ad8afe9249aa591c62e1742d666 Author: Bharath Hariharan <bhariha...@salesforce.com> Date: 2017-02-23T19:13:10Z Updating version This closes #364 commit f3408169735e01817bdde113547ca40375529ebb Author: Joe Bowser <bows...@gmail.com> Date: 2017-03-09T18:26:48Z CB-12524: Windows functionality for Gradle execution commit 45e3c6983470d47628e8deba23ab41498638a8a9 Author: Joe Bowser <bows...@gmail.com> Date: 2017-03-09T18:32:07Z Accidentally committed temp files in Windows --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #365: CB-12524: Fix the GradleBuilder so that it build...
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/365 Closing this PR because we can't distribute JARs, we have to find another solution. Apologies. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request #365: CB-12524: Fix the GradleBuilder so that i...
Github user infil00p closed the pull request at: https://github.com/apache/cordova-android/pull/365 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #358: CB-12424: (android) Fix encoding of multipart me...
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/358 @kalliste This test is based on the old test framework. Can you pull down the latest and take a look at this test and see if you can fit it in here? https://github.com/apache/cordova-android/blob/master/test/app/src/test/java/org/apache/cordova/unittests/NativeToJsMessageQueueTest.java --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request #365: CB-12524: Fix the GradleBuilder so that i...
GitHub user infil00p opened a pull request: https://github.com/apache/cordova-android/pull/365 CB-12524: Fix the GradleBuilder so that it builds the project with an included Gradle ### Platforms affected Android ### What does this PR do? This PR adds the Gradle Wrapper for the Cordova Framework and uses it for all projects. This has been added after the recent changes Google has made to the Android SDK tools from 25.3.1. ### What testing has been done on this change? Tested the build. ### Checklist - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [ x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/infil00p/cordova-android android_sdk_fixes Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-android/pull/365.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #365 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #357: CB-12421: (android)The CoreAndroid's loadUrl met...
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/357 I'm pretty sure this is already being done on the UI thread. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #310: [CB-10916] Support display name for Android
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/310 Looks fine, but we should wait for it all to go in together if possible. @dpogue You have commit rights, so can you make sure that this gets pulled in when the parent issue gets resolved? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #304: fix crash when calling methods on a destroyed we...
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/304 Do you have a stack trace for this? This is old, but it doesn't conflict, so I might pull it in, but it would help to see an error report or something before throwing this over the fence. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #283: CB-10897 Refactor URI Parsing for Whitelist
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/283 What's the status for this? I refactored the unit tests so we can actually have tests that back this code now, as opposed to before where it wasn't quite as straight forward. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #358: CB-12424: (android) Fix encoding of multipart me...
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/358 @kalliste Thanks for submitting the ICLA. Is it possible for you to add a Unit Test to the new Unit Testing framework for this patch? People have been complaining about this being a regression despite the fact that we have zero documentation and zero tests. (In fact the refactored bridge had absolutely no unit tests until now, which is why I haven't pulled this in yet and have been working on getting some tests up.) The test project is in tests, and it's a standard Android project using JUnit and Espresso. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
