[GitHub] cordova-plugin-statusbar issue #62: CB-10288: statusbar plugin interaction w...

Github user jonathanli2 commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/62 Just squashed the commits into a single one for the PR request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cordova-plugin-inappbrowser issue #187: CB-11136: InAppBrowser fails to clos...

Github user jonathanli2 commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/187 Would it be better to add an if condition check, and only apply the change if WKWebView is used? so that the change will not affect UIWebView's old behavior by any chance

[GitHub] cordova-plugin-splashscreen issue #105: fix bug CB-11422 ios SplashScreen pl...

Github user jonathanli2 commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/105 Close the pull request as the change in CB-10895 already handled the case by removing the extra if condition check. Please refer to bug CB-11422 for details

[GitHub] cordova-plugin-splashscreen pull request #105: fix bug CB-11422 ios SplashSc...

Github user jonathanli2 closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/105 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-statusbar issue #62: CB-10288: statusbar plugin interaction w...

Github user jonathanli2 commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/62 Actually as mentioned in jcesarmobile's comment at above, the right issue id for this pull request is CB-10288. I just edited the PR title to the "CB-10288&q

[GitHub] cordova-plugin-statusbar issue #62: CB:-9161 Support iPad multitasking in iO...

Github user jonathanli2 commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/62 Hi, Just follow jcesarmobile's suggestion and still use UIWindow's bounds in pluginInitialize method, then the status tab event gets fired as expected in my testing

[GitHub] cordova-plugin-statusbar issue #62: CB:-9161 Support iPad multitasking in iO...

Github user jonathanli2 commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/62 Hi, I believe I have signed the agreement a while ago (on November 2014) when suggested by John Wargo, but I think at that time I signed the agreement using my company's

[GitHub] cordova-plugin-statusbar issue #62: CB:-9161 Support iPad multitasking in iO...

Github user jonathanli2 commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/62 Hi, Thanks for the quick review, and really appreciate your help. I updated the pull request based on your comment, please let me know if any other changes

[GitHub] cordova-plugin-statusbar pull request #62: CB:-9161 Support iPad multitaskin...

GitHub user jonathanli2 opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/62 CB:-9161 Support iPad multitasking in iOS 9. (statusbar plugin side fix) ### Platforms affected ios ### What does this PR do? With the ipad pro

[GitHub] cordova-plugin-splashscreen pull request #105: fix bug CB-11422 ios SplashSc...

GitHub user jonathanli2 opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/105 fix bug CB-11422 ios SplashScreen plugin may make webview disabled by… ### Platforms affected ios ### What does this PR do? Fix bug CB-11422 ios