[GitHub] cordova-lib issue #219: CB-9033 : fix WatchKit support
Github user ogoguel commented on the issue: https://github.com/apache/cordova-lib/pull/219 +1 Still hoping to have that code validated :) Updated the PR that was almost one year old! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10653 Making the windows activati...
Github user ogoguel commented on the pull request: https://github.com/apache/cordova-windows/pull/173#issuecomment-216458424 @rakatyal, actually, I believe you need to clone it anyway to have it available in the trigger. My problem is more about how to serialize/marshaling such an `WebUILaunchActivatedEventArgs` parameter so it can be used in C#, but this is maybe off topic... Looking forward to have this PR merged! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10653 Making the windows activati...
Github user ogoguel commented on the pull request: https://github.com/apache/cordova-windows/pull/173#issuecomment-216383571 +1 for that feature! A quick question though :how to pass the `platform.activationContext` back as a `WebUILaunchActivatedEventArgs` object to a C# Windows Runtime Component ? Ex: ` public static void onActivated(WebUILaunchActivatedEventArgs _event)` I would assume that if it has been cloned, the object class is being lost, but the `WebUILaunchActivatedEventArgs `is not constructible. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9033 : fix WatchKit support
Github user ogoguel commented on the pull request: https://github.com/apache/cordova-lib/pull/219#issuecomment-151969906 Merged with cordova-lib/master. Some tests fail but those failure were already present in the master branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: Cb 9033
GitHub user ogoguel opened a pull request: https://github.com/apache/cordova-lib/pull/330 Cb 9033 new submission : removed unnecessary project files You can merge this pull request into a Git repository by running: $ git pull https://github.com/ogoguel/cordova-lib CB-9033 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/330.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #330 commit b1dad14ff23f8428a5d3cb789f902597e45df4d8 Author: Olivier Goguel <o...@goguel.com> Date: 2015-05-16T11:21:55Z CB-9033 : fix WatchKit support commit 85c0f62c768c2e3790e79db727c3686f3067f3b8 Author: Olivier Goguel <o...@goguel.com> Date: 2015-05-20T23:06:45Z fix test commit 53beb08e560172758c54b902bc89b44a858541b0 Author: Olivier Goguel <o...@goguel.com> Date: 2015-05-20T23:25:07Z adding target support commit 918f02b177c6621d73744faed2f6accbc9eddcb9 Author: Olivier Goguel <o...@goguel.com> Date: 2015-06-02T19:06:34Z Using SKIP_INSTALL commit f6db84ee019fb647ea5d70ac4d972f30575c0f9b Author: Olivier Goguel <o...@goguel.com> Date: 2015-06-02T19:13:58Z updated node-xcode version commit be430221dba153b30279421498048e1f597045df Author: Olivier Goguel (Betomorrow) <ogoguel_bto@macbook-pro-de-olivier-bto.local> Date: 2015-06-05T15:54:48Z using strict not equal commit ce044f54fe08501cfbf151de8ef985f69a3aa8f3 Author: Olivier Goguel <ogoguel@macbook-pro-de-olivier.local> Date: 2015-10-27T19:58:33Z removed unnecessary files --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: Cb 9033
Github user ogoguel closed the pull request at: https://github.com/apache/cordova-lib/pull/330 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9033 : fix WatchKit support
Github user ogoguel commented on the pull request: https://github.com/apache/cordova-lib/pull/219#issuecomment-151641072 Removed source files, and fixed merge issue --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9033 : fix WatchKit support
Github user ogoguel commented on the pull request: https://github.com/apache/cordova-lib/pull/219#issuecomment-151628253 Removed source files --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: CB-9616 AndroidM Runtime Permission ...
Github user ogoguel commented on the pull request: https://github.com/apache/cordova-android/pull/222#issuecomment-144527463 Good to know :) I had to implement this feature to test my plugin, and I've though it could be helpful to other people until the official release is out. Keep up the good work! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: CB-9616 AndroidM Runtime Permission ...
GitHub user ogoguel opened a pull request: https://github.com/apache/cordova-android/pull/222 CB-9616 AndroidM Runtime Permission Support Add onRequestPermissionsResult handler for plugins You can merge this pull request into a Git repository by running: $ git pull https://github.com/ogoguel/cordova-android CB-9616 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-android/pull/222.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #222 commit c0a8c61e5f245cebf1edbab871bc6055a26c4b68 Author: Olivier Goguel <o...@goguel.com> Date: 2015-09-27T22:33:32Z CB-9616 AndroidM Runtime Permission Support --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9162 - Default Variables
Github user ogoguel commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/247#discussion_r35457112 --- Diff: cordova-lib/spec-plugman/plugins/org.test.defaultvariables/plugin.xml --- @@ -0,0 +1,16 @@ +?xml version=1.0 encoding=UTF-8? + +plugin xmlns=http://cordova.apache.org/ns/plugins/1.0; +xmlns:android=http://schemas.android.com/apk/res/android; +id=org.test.defaultvariables +version=3.0.0 + +nameUse Default Variables/name + +!-- android -- +platform name=android +preference name=ENABLE_LOG default=yes / +preference name=API_KEY / +/platform --- End diff -- If you want to override the default variable, just specify it during the plugin installation : ex :` cordova plugin add plugin_id --variable ENABLE_LOG=no` This will update the `cordova/plugins/android.json`accordingly, as this is where the variables are being stored (and not in the config.xml) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9033 : fix WatchKit support
Github user ogoguel commented on the pull request: https://github.com/apache/cordova-lib/pull/219#issuecomment-118605960 Any update on that ? I'd like to avoid having to patch my cordova lib every time, and I believe I am not the only one in that case (cf. https://issues.apache.org/jira/browse/CB-9176). @TimBarham : have you been able to find someone to help with the review? Let me know how I could help you on that matter. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9162 - Default Variables
Github user ogoguel commented on the pull request: https://github.com/apache/cordova-lib/pull/247#issuecomment-112522204 Added missing test for variables parsing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9162 - Default Variables
Github user ogoguel commented on the pull request: https://github.com/apache/cordova-lib/pull/247#issuecomment-112212662 Fixed requiredVariables Fixed whitespace in plugin.xml --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9162 - Default Variables
Github user ogoguel commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/247#discussion_r32466926
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -168,10 +168,19 @@ module.exports = function plugin(command, targets,
opts) {
})
.then(function(dir) {
// Validate top-level required variables
-var pluginVariables =
pluginInfoProvider.get(dir).getPreferences(),
-missingVariables =
pluginVariables.filter(function (v) {
+var pluginVariables =
pluginInfoProvider.get(dir).getPreferences();
+var requiredVariables = [];
+for(var i in pluginVariables)
+{
+var v = pluginVariables[i];
+// discard variables with default value
+if (!v.default)
--- End diff --
Beside adding a plugin, how this line of code can be unit-tested ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9162 - Default Variables
GitHub user ogoguel opened a pull request: https://github.com/apache/cordova-lib/pull/247 CB-9162 - Default Variables You can merge this pull request into a Git repository by running: $ git pull https://github.com/ogoguel/cordova-lib variables Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/247.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #247 commit 14e225be9eabae899796e63b6c1925bc7aab7e0d Author: Olivier Goguel ogoguel@macbook-pro-de-olivier-bto.local Date: 2015-06-12T06:57:02Z CB-9162 - Default Variables --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-cli pull request: CB-9171 Support Variables with =
GitHub user ogoguel opened a pull request: https://github.com/apache/cordova-cli/pull/217 CB-9171 Support Variables with = Fixed : Plugin Variables Failed to be properly parsed when containing an = sign You can merge this pull request into a Git repository by running: $ git pull https://github.com/ogoguel/cordova-cli CB-9171 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-cli/pull/217.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #217 commit 82d57221f70c90e0c7e4293e14912d9e216719ac Author: Olivier Goguel o...@goguel.com Date: 2015-06-12T21:41:18Z CB-9171 Support Variables with = --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9033 : fix WatchKit support
Github user ogoguel commented on the pull request: https://github.com/apache/cordova-lib/pull/219#issuecomment-109339921 Using !== instead of != --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9033 : fix WatchKit support
Github user ogoguel commented on the pull request: https://github.com/apache/cordova-lib/pull/219#issuecomment-109357001 It is not better. Just trying to follow cordova-lib coding guidelines requirements ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9033 : fix WatchKit support
Github user ogoguel commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/219#discussion_r31824683
--- Diff: cordova-lib/src/plugman/platforms/ios.js ---
@@ -184,13 +192,65 @@ module.exports = {
var xcBuildConfiguration =
xcodeproj.pbxXCBuildConfigurationSection();
-var plist_file_entry = _.find(xcBuildConfiguration, function
(entry) { return entry.buildSettings entry.buildSettings.INFOPLIST_FILE; });
-var plist_file = path.join(project_dir,
plist_file_entry.buildSettings.INFOPLIST_FILE.replace(/^(.*)$/g,
'$1').replace(/\\/g, ''));
-var config_file = path.join(path.dirname(plist_file),
'config.xml');
-if (!fs.existsSync(plist_file) || !fs.existsSync(config_file)) {
+// CB-9033
+var plist_file_index;
+var plist_file_entry = _.find(xcBuildConfiguration, function
(entry,index) {
+if (entry.buildSettings entry.buildSettings.INFOPLIST_FILE
entry.buildSettings.SKIP_INSTALL != 'YES') {
--- End diff --
ok, I will change it, even though I don't believe it would make a
difference... unless there are cases I've missed.
if it is part of the cordova-lib coding requirements, it would be good to
update the jslint rules accordingly so it is catched during the test phase
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9033 : fix WatchKit support
Github user ogoguel commented on the pull request: https://github.com/apache/cordova-lib/pull/219#issuecomment-108063507 Added SKIP_INSTALL to improve plist detection Using node-xcode 0.7.0 (which includes the required modification) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9033 : fix WatchKit support
Github user ogoguel commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/219#discussion_r31520090
--- Diff: cordova-lib/src/plugman/platforms/ios.js ---
@@ -184,13 +192,76 @@ module.exports = {
var xcBuildConfiguration =
xcodeproj.pbxXCBuildConfigurationSection();
-var plist_file_entry = _.find(xcBuildConfiguration, function
(entry) { return entry.buildSettings entry.buildSettings.INFOPLIST_FILE; });
-var plist_file = path.join(project_dir,
plist_file_entry.buildSettings.INFOPLIST_FILE.replace(/^(.*)$/g,
'$1').replace(/\\/g, ''));
-var config_file = path.join(path.dirname(plist_file),
'config.xml');
-if (!fs.existsSync(plist_file) || !fs.existsSync(config_file)) {
+// CB-9033
+var plist_file_index;
+var plist_file_entry = _.find(xcBuildConfiguration, function
(entry,index) {
+if (entry.buildSettings entry.buildSettings.INFOPLIST_FILE)
{
+
+var plist_file = path.join(project_dir,
entry.buildSettings.INFOPLIST_FILE.replace(/^(.*)$/g, '$1').replace(/\\/g,
''));
+ if (!fs.existsSync(plist_file))
+return false;
+
+var config_file = path.join(path.dirname(plist_file),
'config.xml');
+ if (!fs.existsSync(config_file))
+return false;
+
+// only return project that contains both a plist and a
config.xml (especially to discard apple watch extension/app)
+plist_file_index = index;
--- End diff --
I did not know about the SKIP_INSTALL but that would be a good additional
check : thanks for the pointer.
Nevertheless, you still need to check that both the .PLIST and the
CONFIG.XML files exist eventually, so it won't totally replace the test.
I will upgrade my code anyway
Olivier
2015-06-02 11:49 GMT+02:00 Georgi Alexandrov notificati...@github.com:
In cordova-lib/src/plugman/platforms/ios.js
https://github.com/apache/cordova-lib/pull/219#discussion_r31507207:
-if (!fs.existsSync(plist_file) || !fs.existsSync(config_file))
{
+// CB-9033
+var plist_file_index;
+var plist_file_entry = _.find(xcBuildConfiguration, function
(entry,index) {
+if (entry.buildSettings
entry.buildSettings.INFOPLIST_FILE) {
+
+var plist_file = path.join(project_dir,
entry.buildSettings.INFOPLIST_FILE.replace(/^(.*)$/g, '$1').replace(/\\/g,
''));
+ if (!fs.existsSync(plist_file))
+return false;
+
+var config_file = path.join(path.dirname(plist_file),
'config.xml');
+ if (!fs.existsSync(config_file))
+return false;
+
+// only return project that contains both a plist and
a config.xml (especially to discard apple watch extension/app)
+plist_file_index = index;
Instead of checking for config.xml can we check for SKIP_INSTALL property
in BuildSettings. SKIP_INSTALL property should be missing or equals to NO
for the iPhone app target and should equals to YES for WatchKit Extension
and WatchKit App.
â
Reply to this email directly or view it on GitHub
https://github.com/apache/cordova-lib/pull/219/files#r31507207.
--
ıllıllı ɹÇ!Ê!×o ıllıllı
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9033 : fix WatchKit support
Github user ogoguel commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/219#discussion_r31519205 --- Diff: cordova-lib/package.json --- @@ -42,7 +42,7 @@ underscore: 1.7.0, unorm: 1.3.3, valid-identifier: 0.0.1, -xcode: 0.6.7 +xcode: https://github.com/ogoguel/node-xcode/tarball/17926117b388d08f05ec2db1e1ad8262f67a2a8d; --- End diff -- A pull request has been sent to node-xcode ( https://github.com/alunny/node-xcode/pull/47), but in the meantime, I was using a tarball reference to have a working version Actually, my pull request has just been merged into node-xcode master, but the version not yet updated into the npm repository : what should I put into the package.json in the meantime ? https://github.com/alunny/node-xcode.git ? Thanks for your pointer Cheers Olivier 2015-06-02 11:38 GMT+02:00 Georgi Alexandrov notificati...@github.com: In cordova-lib/package.json https://github.com/apache/cordova-lib/pull/219#discussion_r31506402: @@ -42,7 +42,7 @@ underscore: 1.7.0, unorm: 1.3.3, valid-identifier: 0.0.1, -xcode: 0.6.7 +xcode: https://github.com/ogoguel/node-xcode/tarball/17926117b388d08f05ec2db1e1ad8262f67a2a8d; You should create PR with your changes to node-xcode https://github.com/alunny/node-xcode instead of using tarball dependency â Reply to this email directly or view it on GitHub https://github.com/apache/cordova-lib/pull/219/files#r31506402. -- ıllıllı ɹÇ!Ê!×o ıllıllı --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9033 : fix WatchKit support
Github user ogoguel commented on the pull request: https://github.com/apache/cordova-lib/pull/219#issuecomment-104160107 Replace the node-xcode package to support multiple target support Now, plugman install the files/resources within the proper buildphase in the Xcode Project --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9033 : fix WatchKit support
Github user ogoguel commented on the pull request: https://github.com/apache/cordova-lib/pull/219#issuecomment-104068019 Fix Test And Make the Test More Reliable --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9033 : fix WatchKit support
GitHub user ogoguel opened a pull request: https://github.com/apache/cordova-lib/pull/219 CB-9033 : fix WatchKit support Fixing plugin support while WatchKit has been added to an iOS project by discard any list .plist file containing WKCompanionAppBundleIdentifier or WKAppBundleIdentifier, so the plugin manager properly identifies the main plist file of the project To test cordova create myApp cd myApp cordova platform add ios Goto Xcode, open the project add a new Watch Kit Target cordova plugin add cordova-plugin-console Installing cordova-plugin-console for ios Failed to install 'cordova-plugin-console':CordovaError: could not find -Info.plist file, or config.xml file. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ogoguel/cordova-lib master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/219.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #219 commit b1fab9297f95fe6e0e28701255631ca0aa47 Author: Olivier Goguel o...@goguel.com Date: 2015-05-16T11:21:55Z CB-9033 : fix WatchKit support --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
