[GitHub] cordova-windows issue #194: CB-10738 Use hardcoded Id attribute in Win10 man...
Github user sgrebnov commented on the issue: https://github.com/apache/cordova-windows/pull/194 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera issue #233: CB-11295 Add WP8.1 quirk when choosing ima...
Github user sgrebnov commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/233 :+1: LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs issue #625: CB-11685 Add tools release blog post
Github user sgrebnov commented on the issue: https://github.com/apache/cordova-docs/pull/625 :+1: lgtm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera issue #223: CB-11447 Fix Appium camera tests failures
Github user sgrebnov commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/223 Reviewed, LGTM :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows issue #187: CB-11241 Return adding BOM to www back to prepar...
Github user sgrebnov commented on the issue: https://github.com/apache/cordova-windows/pull/187 LGTM :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs issue #621: CB-11569 Add tools release blog post
Github user sgrebnov commented on the issue: https://github.com/apache/cordova-docs/pull/621 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs issue #622: CB-11552 Add windows 4.4.1 release blog post
Github user sgrebnov commented on the issue: https://github.com/apache/cordova-docs/pull/622 Reviewed :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request #622: CB-11552 Add windows 4.4.1 release blog post
Github user sgrebnov commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/622#discussion_r70650575 --- Diff: www/_posts/2016-07-13-cordova-windows-4.4.1.md --- @@ -0,0 +1,37 @@ +--- +layout: post +author: +name: Vladimir Kotikov +url: https://github.com/vladimir-kotikov +title: "Apache Cordova Windows 4.4.1" +categories: announcements +tags: news releases +--- + +We are happy to announce that `Cordova Windows 4.4.1` has been released! + +In this release we have fixed a number of issues, related to apllication resuming, splash screen functionality and others. +Also we have added an abiity to specify location of `msbuild` executable to build project. --- End diff -- Spellcheck: `abiity` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request #622: CB-11552 Add windows 4.4.1 release blog post
Github user sgrebnov commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/622#discussion_r70650375 --- Diff: www/_posts/2016-07-13-cordova-windows-4.4.1.md --- @@ -0,0 +1,37 @@ +--- +layout: post +author: +name: Vladimir Kotikov +url: https://github.com/vladimir-kotikov +title: "Apache Cordova Windows 4.4.1" +categories: announcements +tags: news releases +--- + +We are happy to announce that `Cordova Windows 4.4.1` has been released! + +In this release we have fixed a number of issues, related to apllication resuming, splash screen functionality and others. --- End diff -- Spelling: `apllication` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows issue #184: CB-11548 windows: Respect user-specified msbuild...
Github user sgrebnov commented on the issue: https://github.com/apache/cordova-windows/pull/184 Reviewed, LGTM :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request: CB-11019 Handle app name change more acc...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-ios/pull/213#issuecomment-211430445 :+1: lgtm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-paramedic pull request: Code changes for Collecting Device...
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/4#discussion_r59777381
--- Diff: lib/paramedic.js ---
@@ -105,10 +116,23 @@ ParamedicRunner.prototype.checkPlatformRequirements =
function() {
logger.normal("cordova-paramedic: checking requirements for platform "
+ this.config.getPlatformId());
var result = exec('cordova requirements ' +
this.config.getPlatformId());
-if (result.code !== 0)
+if (result.code !== 0)
throw new Error('Platform requirements check has failed!');
};
+ParamedicRunner.prototype.setPermissions = function() {
--- End diff --
Permission logic could be implemented via separate plugin with hooks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-paramedic pull request: Code changes for Collecting Device...
Github user sgrebnov commented on a diff in the pull request: https://github.com/apache/cordova-paramedic/pull/4#discussion_r59776906 --- Diff: main.js --- @@ -25,7 +25,12 @@ var USAGE = "Error missing args. \n" + "--useTunnel : (optional) use tunneling instead of local address. default is false\n" + "--config : (optional) read configuration from paramedic configuration file\n" + "--reportSavePath: (optional) path to save Junit results file\n" + -"--cleanUpAfterRun: (optional) cleans up the application after the run."; +"--cleanUpAfterRun: (optional) cleans up the application after the run\n" + +"--logPath: (optional) path to store device logs - application path will be used by default\n" + +"--logMins: (optional) Windows only - specifies number of minutes to get logs\n" + +"--appName: (optional) iOS only - specifies the name of the app to be deployed\n" + +"--simulatorsFolder: (optional) iOS only - specifies the path for the simulatorsFolder\n" + +"--tccDbPath: (optional) iOS only - specifies the path for the TCC.db file to be copied."; --- End diff -- Readme.md should be updated as well --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-paramedic pull request: Paramedic improvements
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/3#discussion_r59327252
--- Diff: lib/paramedic.js ---
@@ -0,0 +1,231 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+var exec = require('./utils').exec,
+shell = require('shelljs'),
+Server = require('./LocalServer'),
+Q = require('q'),
+tmp = require('tmp'),
+PluginsManager = require('./PluginsManager'),
+path = require('path'),
+Q = require('q'),
+fs = require('fs'),
+getReporters = require('./Reporters'),
+logger = require('./utils').logger;
+
+// Time to wait for initial device connection.
+// If device has not connected within this interval the tests are stopped.
+var INITIAL_CONNECTION_TIMEOUT = 30; // 5mins
+
+function ParamedicRunner(config, _callback) {
+this.tempFolder = null;
+this.pluginsManager = null;
+
+this.config = config;
+
+exec.setVerboseLevel(config.isVerbose());
+}
+
+ParamedicRunner.prototype.run = function() {
+var self = this;
+
+return Q().then(function() {
+self.createTempProject();
+self.prepareProjectToRunTests();
+return Server.startServer(self.config.getPorts(),
self.config.getExternalServerUrl(), self.config.getUseTunnel());
+})
+.then(function(server) {
+self.server = server;
+
+self.injectReporters();
+self.subcribeForEvents();
+
+var connectionUrl =
server.getConnectionUrl(self.config.getPlatformId());
+self.writeMedicConnectionUrl(connectionUrl);
+
+return self.runTests();
+})
+.fin(function() {
+self.cleanUpProject();
+});
+};
+
+ParamedicRunner.prototype.createTempProject = function() {
+this.tempFolder = tmp.dirSync();
+tmp.setGracefulCleanup();
+logger.info("cordova-paramedic: creating temp project at " +
this.tempFolder.name);
+exec('cordova create ' + this.tempFolder.name);
+shell.pushd(this.tempFolder.name);
+};
+
+ParamedicRunner.prototype.prepareProjectToRunTests = function() {
+this.installPlugins();
+this.setUpStartPage();
+this.installPlatform();
+this.checkPlatformRequirements();
+};
+
+ParamedicRunner.prototype.installPlugins = function() {
+logger.info("cordova-paramedic: installing plugins");
+this.pluginsManager = new PluginsManager(this.tempFolder.name,
this.storedCWD);
+this.pluginsManager.installPlugins(this.config.getPlugins());
+this.pluginsManager.installTestsForExistingPlugins();
+
this.pluginsManager.installSinglePlugin('cordova-plugin-test-framework');
+this.pluginsManager.installSinglePlugin('cordova-plugin-device');
+this.pluginsManager.installSinglePlugin(path.join(__dirname,
'../paramedic-plugin'));
+};
+
+ParamedicRunner.prototype.setUpStartPage = function() {
+logger.normal("cordova-paramedic: setting app start page to test
page");
+shell.sed('-i', 'src="index.html"', 'src="cdvtests/index.html"',
'config.xml');
+};
+
+ParamedicRunner.prototype.installPlatform = function() {
+logger.info("cordova-paramedic: adding platform : " +
this.config.getPlatform());
+exec('cordova platform add ' + this.config.getPlatform());
+};
+
+ParamedicRunner.prototype.checkPlatformRequirements = function() {
+logger.normal("cordova-paramedic: checking requirements for platform "
+ this.config.getPlatformId());
+var result = exec('cordova requirements ' +
this.config.getPlatformId());
+
+if (result.code !== 0)
+throw new Error('Platform requirements check has failed!');
+};
+
+ParamedicRunner.prototype.injectReporters = function() {
[GitHub] cordova-paramedic pull request: Paramedic improvements
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/3#discussion_r59327011
--- Diff: lib/LocalServer.js ---
@@ -0,0 +1,162 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+var Q = require('q'),
+io = require('socket.io'),
+logger = require('./utils').logger,
+exec = require('./utils').exec,
+path = require('path'),
+util = require('util'),
+portChecker = require('tcp-port-used'),
+EventEmitter = require('events').EventEmitter,
+localtunnel = require('localtunnel');
+
+
+// how many ms without a pong packet to consider the connection closed
+var CONNECTION_HEARBEAT_PING_TIMEOUT = 6,
+// how many ms before sending a new ping packet
+CONNECTION_HEARBEAT_PING_INTERVAL = 25000;
+
+function LocalServer(port, externalServerUrl) {
+this.port = port;
+this.externalServerUrl = externalServerUrl;
+}
+
+util.inherits(LocalServer, EventEmitter);
+
+LocalServer.startServer = function(ports, externalServerUrl, useTunnel) {
+logger.normal("local-server: scanning ports from " + ports.start + "
to " + ports.end);
+
+return LocalServer.getFirstAvailablePort(ports.start, ports.end)
+.then(function(port) {
+logger.normal("local-server: port " + port + " is available");
+logger.info("local-server: starting local medic server");
+
+var localServer = new LocalServer(port, externalServerUrl);
+localServer.createSocketListener();
+
+if (useTunnel) {
+return localServer.createTunnel();
+}
+
+return localServer;
+});
+};
+
+LocalServer.getFirstAvailablePort = function(startPort, endPort) {
--- End diff --
This method creates new LocalServer instance so should be static
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-paramedic pull request: Paramedic improvements
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/3#discussion_r59326850
--- Diff: lib/LocalServer.js ---
@@ -0,0 +1,162 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+var Q = require('q'),
+io = require('socket.io'),
+logger = require('./utils').logger,
+exec = require('./utils').exec,
+path = require('path'),
+util = require('util'),
+portChecker = require('tcp-port-used'),
+EventEmitter = require('events').EventEmitter,
+localtunnel = require('localtunnel');
+
+
+// how many ms without a pong packet to consider the connection closed
+var CONNECTION_HEARBEAT_PING_TIMEOUT = 6,
+// how many ms before sending a new ping packet
+CONNECTION_HEARBEAT_PING_INTERVAL = 25000;
+
+function LocalServer(port, externalServerUrl) {
+this.port = port;
+this.externalServerUrl = externalServerUrl;
+}
+
+util.inherits(LocalServer, EventEmitter);
+
+LocalServer.startServer = function(ports, externalServerUrl, useTunnel) {
+logger.normal("local-server: scanning ports from " + ports.start + "
to " + ports.end);
+
+return LocalServer.getFirstAvailablePort(ports.start, ports.end)
+.then(function(port) {
+logger.normal("local-server: port " + port + " is available");
+logger.info("local-server: starting local medic server");
+
+var localServer = new LocalServer(port, externalServerUrl);
+localServer.createSocketListener();
+
+if (useTunnel) {
+return localServer.createTunnel();
+}
+
+return localServer;
+});
+};
+
+LocalServer.getFirstAvailablePort = function(startPort, endPort) {
+// returns array range [startPort..endPort]
+var ports = Array.apply(null, Array(endPort - startPort +
1)).map(function(element, index) {
+return startPort + index;
+});
+
+return Q.promise(function(resolve, reject) {
+ports.reduce(function(promise, port){
+return promise.then(function(isPortUsed) {
+if (!isPortUsed) {
+resolve(port - 1);
+return false;
+} else {
+return portChecker.check(port);
+}
+});
+}, Q(true));
+});
+};
--- End diff --
+1, updated
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10921 Emit warning in case of plugin ...
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/420#discussion_r59195085
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -157,6 +157,7 @@ module.exports = function plugin(command, targets,
opts) {
if (missingVariables.length) {
shell.rm('-rf', pluginInfo.dir);
+events.emit('verbose', 'Removing ' +
pluginInfo.dir + ' due to installation failure');
var msg = 'Variable(s) missing (use:
--variable ' + missingVariables.join('=value --variable ') + '=value).';
--- End diff --
I think if we add the change below then we will have exactly the same
message to be traced twice. The pic above with log trace sample looks good.
> I think we should also emit a message about the variables
missing.(events.emit(msg))
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-paramedic pull request: Paramedic improvements
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/3#discussion_r59072232
--- Diff: lib/LocalServer.js ---
@@ -0,0 +1,141 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+var Q = require('q'),
+io = require('socket.io'),
+logger = require('./utils').logger,
+exec = require('./utils').exec,
+path = require('path'),
+util = require('util'),
+portChecker = require('tcp-port-used'),
+EventEmitter = require('events').EventEmitter;
+
+function LocalServer(port, externalServerUrl) {
+this.port = port;
+this.externalServerUrl = externalServerUrl;
+}
+
+util.inherits(LocalServer, EventEmitter);
+
+LocalServer.startServer = function(ports, externalServerUrl, useTunnel) {
+logger.normal("local-server: scanning ports from " + ports.start + "
to " + ports.end);
+
+return LocalServer.getFirstAvailablePort(ports.start, ports.end)
+.then(function(port) {
+logger.normal("local-server: port " + port + " is available");
+logger.info("local-server: starting local medic server");
+
+var localServer = new LocalServer(port, externalServerUrl);
+localServer.createSocketListener();
+
+if (useTunnel) {
+return Q.promise(function(resolve) {
+localServer.createTunnel().then(function(){
+resolve(localServer);
+});
+});
+}
+
+return localServer;
+});
+};
+
+LocalServer.getFirstAvailablePort = function(startPort, endPort) {
+var ports = Array.apply(null, Array(endPort - startPort +
1)).map(function(element, index) {
+return startPort + index;
+});
+
+return Q.promise(function(resolve, reject) {
+ports.reduce(function(promise, port){
+return promise.then(function(isPortUsed) {
+if (!isPortUsed) {
+resolve(port - 1);
+return false;
+} else {
+return portChecker.check(port);
+}
+});
+}, Q(true));
+});
+};
+
+LocalServer.prototype.createTunnel = function() {
+logger.info('cordova-paramedic: attempt to create local tunnel');
+var self = this;
+
+//TODO: use localtunnel module instead of shell
+return Q.Promise(function(resolve, reject) {
+exec(path.resolve(__dirname, '../node_modules/.bin/lt') + ' --port
' + self.port, null, function(output) {
+var tunneledUrl = output.split(' ')[3];
+self.tunneledUrl = tunneledUrl;
+logger.info('cordova-paramedic: using tunneled url ' +
tunneledUrl);
+resolve();
+});
+});
+};
+
+LocalServer.prototype.createSocketListener = function() {
+var listener = io.listen(this.port, {
+pingTimeout: 6, // how many ms without a pong packet to
consider the connection closed
+pingInterval: 25000 // how many ms before sending a new ping packet
--- End diff --
Updated
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-paramedic pull request: Paramedic improvements
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/3#discussion_r59005735
--- Diff: lib/LocalServer.js ---
@@ -0,0 +1,141 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+var Q = require('q'),
+io = require('socket.io'),
+logger = require('./utils').logger,
+exec = require('./utils').exec,
+path = require('path'),
+util = require('util'),
+portChecker = require('tcp-port-used'),
+EventEmitter = require('events').EventEmitter;
+
+function LocalServer(port, externalServerUrl) {
+this.port = port;
+this.externalServerUrl = externalServerUrl;
+}
+
+util.inherits(LocalServer, EventEmitter);
+
+LocalServer.startServer = function(ports, externalServerUrl, useTunnel) {
+logger.normal("local-server: scanning ports from " + ports.start + "
to " + ports.end);
+
+return LocalServer.getFirstAvailablePort(ports.start, ports.end)
+.then(function(port) {
+logger.normal("local-server: port " + port + " is available");
+logger.info("local-server: starting local medic server");
+
+var localServer = new LocalServer(port, externalServerUrl);
+localServer.createSocketListener();
+
+if (useTunnel) {
+return Q.promise(function(resolve) {
+localServer.createTunnel().then(function(){
+resolve(localServer);
+});
+});
+}
+
+return localServer;
+});
+};
+
+LocalServer.getFirstAvailablePort = function(startPort, endPort) {
+var ports = Array.apply(null, Array(endPort - startPort +
1)).map(function(element, index) {
+return startPort + index;
+});
+
+return Q.promise(function(resolve, reject) {
+ports.reduce(function(promise, port){
+return promise.then(function(isPortUsed) {
+if (!isPortUsed) {
+resolve(port - 1);
+return false;
+} else {
+return portChecker.check(port);
+}
+});
+}, Q(true));
+});
+};
+
+LocalServer.prototype.createTunnel = function() {
+logger.info('cordova-paramedic: attempt to create local tunnel');
+var self = this;
+
+//TODO: use localtunnel module instead of shell
+return Q.Promise(function(resolve, reject) {
+exec(path.resolve(__dirname, '../node_modules/.bin/lt') + ' --port
' + self.port, null, function(output) {
+var tunneledUrl = output.split(' ')[3];
+self.tunneledUrl = tunneledUrl;
+logger.info('cordova-paramedic: using tunneled url ' +
tunneledUrl);
+resolve();
+});
+});
+};
+
+LocalServer.prototype.createSocketListener = function() {
+var listener = io.listen(this.port, {
+pingTimeout: 6, // how many ms without a pong packet to
consider the connection closed
+pingInterval: 25000 // how many ms before sending a new ping packet
+});
+
+var self = this;
+
+listener.on('connection', function(socket) {
+logger.info('local-server: new socket connection');
+self.connection = socket;
+
+// server methods
+['deviceLog', 'disconnect', 'deviceInfo',
+'jasmineStarted', 'specStarted', 'specDone',
+'suiteStarted', 'suiteDone',
'jasmineDone'].forEach(function(route) {
+socket.on(route, function(data) {
+self.emit(route, data);
+});
+});
+});
+};
+
+LocalServer.prototype.getConnectionUrl = function() {
+
[GitHub] cordova-paramedic pull request: Paramedic improvements
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/3#discussion_r59003845
--- Diff: lib/LocalServer.js ---
@@ -0,0 +1,141 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+var Q = require('q'),
+io = require('socket.io'),
+logger = require('./utils').logger,
+exec = require('./utils').exec,
+path = require('path'),
+util = require('util'),
+portChecker = require('tcp-port-used'),
+EventEmitter = require('events').EventEmitter;
+
+function LocalServer(port, externalServerUrl) {
+this.port = port;
+this.externalServerUrl = externalServerUrl;
+}
+
+util.inherits(LocalServer, EventEmitter);
+
+LocalServer.startServer = function(ports, externalServerUrl, useTunnel) {
+logger.normal("local-server: scanning ports from " + ports.start + "
to " + ports.end);
+
+return LocalServer.getFirstAvailablePort(ports.start, ports.end)
+.then(function(port) {
+logger.normal("local-server: port " + port + " is available");
+logger.info("local-server: starting local medic server");
+
+var localServer = new LocalServer(port, externalServerUrl);
+localServer.createSocketListener();
+
+if (useTunnel) {
+return Q.promise(function(resolve) {
+localServer.createTunnel().then(function(){
+resolve(localServer);
+});
+});
+}
+
+return localServer;
+});
+};
+
+LocalServer.getFirstAvailablePort = function(startPort, endPort) {
+var ports = Array.apply(null, Array(endPort - startPort +
1)).map(function(element, index) {
+return startPort + index;
+});
--- End diff --
Added inline comment to make this code more readable/understandable, thx
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-paramedic pull request: Paramedic improvements
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/3#discussion_r59003645
--- Diff: lib/LocalServer.js ---
@@ -0,0 +1,141 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+var Q = require('q'),
+io = require('socket.io'),
+logger = require('./utils').logger,
+exec = require('./utils').exec,
+path = require('path'),
+util = require('util'),
+portChecker = require('tcp-port-used'),
+EventEmitter = require('events').EventEmitter;
+
+function LocalServer(port, externalServerUrl) {
+this.port = port;
+this.externalServerUrl = externalServerUrl;
+}
+
+util.inherits(LocalServer, EventEmitter);
+
+LocalServer.startServer = function(ports, externalServerUrl, useTunnel) {
+logger.normal("local-server: scanning ports from " + ports.start + "
to " + ports.end);
+
+return LocalServer.getFirstAvailablePort(ports.start, ports.end)
+.then(function(port) {
+logger.normal("local-server: port " + port + " is available");
+logger.info("local-server: starting local medic server");
+
+var localServer = new LocalServer(port, externalServerUrl);
+localServer.createSocketListener();
+
+if (useTunnel) {
+return Q.promise(function(resolve) {
+localServer.createTunnel().then(function(){
+resolve(localServer);
+});
+});
--- End diff --
Updated, thx
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-paramedic pull request: Paramedic improvements
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/3#discussion_r59002757
--- Diff: paramedic-plugin/paramedic.js ---
@@ -0,0 +1,93 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+var io = cordova.require('cordova-plugin-paramedic.socket.io');
+
+var PARAMEDIC_SERVER_DEFAULT_URL = 'http://127.0.0.1:8008';
+
+function Paramedic() {
+
+}
+
+Paramedic.prototype.initialize = function() {
+var me = this;
+var connectionUri = loadParamedicServerUrl();
+this.socket = io.connect(connectionUri);
+
+this.socket.on('connect', function () {
+console.log("Paramedic has been susccessfully connected to
server");
+if (typeof device != 'undefined') me.socket.emit('deviceInfo',
device);
+});
+
+this.overrideConsole();
+this.injectJasmineReporter();
+};
+
+
+Paramedic.prototype.overrideConsole = function () {
+
+var origConsole = window.console;
+var me = this;
+
+function createCustomLogger(type) {
+return function () {
+origConsole[type].apply(origConsole, arguments);
+
+me.socket.emit('deviceLog', { type: type, msg:
Array.prototype.slice.apply(arguments) });
+};
+}
+window.console = {
+log: createCustomLogger('log'),
+warn: createCustomLogger('warn'),
+error: createCustomLogger('error'),
+};
+console.log('Paramedic console has been installed.');
+};
+
+Paramedic.prototype.injectJasmineReporter = function () {
+var JasmineParamedicProxy =
require('cordova-plugin-paramedic.JasmineParamedicProxy');
+var jasmineProxy = new JasmineParamedicProxy(this.socket);
+var testsModule =
cordova.require("cordova-plugin-test-framework.cdvtests");
+var defineAutoTestsOriginal = testsModule.defineAutoTests;
+
+testsModule.defineAutoTests = function () {
+defineAutoTestsOriginal();
+jasmine.getEnv().addReporter(jasmineProxy);
+};
+};
+
+new Paramedic().initialize();
+
+function loadParamedicServerUrl() {
+
+try {
+// attempt to synchronously load medic config
+var xhr = new XMLHttpRequest();
+xhr.open("GET", "../medic.json", false);
+xhr.send(null);
+var cfg = JSON.parse(xhr.responseText);
+
+return cfg.logurl || PARAMEDIC_SERVER_DEFAULT_URL;
+
+} catch (ex) {}
--- End diff --
Updated, thx!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-paramedic pull request: Paramedic improvements
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/3#discussion_r59002202
--- Diff: paramedic-plugin/paramedic.js ---
@@ -0,0 +1,93 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+var io = cordova.require('cordova-plugin-paramedic.socket.io');
+
+var PARAMEDIC_SERVER_DEFAULT_URL = 'http://127.0.0.1:8008';
+
+function Paramedic() {
+
+}
+
+Paramedic.prototype.initialize = function() {
+var me = this;
+var connectionUri = loadParamedicServerUrl();
+this.socket = io.connect(connectionUri);
+
+this.socket.on('connect', function () {
+console.log("Paramedic has been susccessfully connected to
server");
+if (typeof device != 'undefined') me.socket.emit('deviceInfo',
device);
+});
+
+this.overrideConsole();
+this.injectJasmineReporter();
+};
+
+
+Paramedic.prototype.overrideConsole = function () {
+
+var origConsole = window.console;
+var me = this;
+
+function createCustomLogger(type) {
+return function () {
+origConsole[type].apply(origConsole, arguments);
+
+me.socket.emit('deviceLog', { type: type, msg:
Array.prototype.slice.apply(arguments) });
+};
+}
+window.console = {
+log: createCustomLogger('log'),
+warn: createCustomLogger('warn'),
+error: createCustomLogger('error'),
+};
+console.log('Paramedic console has been installed.');
+};
+
+Paramedic.prototype.injectJasmineReporter = function () {
+var JasmineParamedicProxy =
require('cordova-plugin-paramedic.JasmineParamedicProxy');
+var jasmineProxy = new JasmineParamedicProxy(this.socket);
+var testsModule =
cordova.require("cordova-plugin-test-framework.cdvtests");
+var defineAutoTestsOriginal = testsModule.defineAutoTests;
+
+testsModule.defineAutoTests = function () {
+defineAutoTestsOriginal();
+jasmine.getEnv().addReporter(jasmineProxy);
+};
+};
+
+new Paramedic().initialize();
+
+function loadParamedicServerUrl() {
+
+try {
+// attempt to synchronously load medic config
+var xhr = new XMLHttpRequest();
+xhr.open("GET", "../medic.json", false);
--- End diff --
Propose to leave as-is as the chance someone will want/need to change this
is very low. We should better to get rid of medic.json file usage and pass
parameters as query params.
Medic.json is mostly used here to auto start tests. I believe mobile spec
and test framework should only run tests and should know nothing about
different target usages like medic/etc. So I think we should remove medic
related functionality from test framework and add support for special query
params like `autoStartTests`, etc
After above is done we should also update paramedic to pass server url as
query param as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-paramedic pull request: Paramedic improvements
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/3#discussion_r59001110
--- Diff: lib/utils/execWrapper.js ---
@@ -0,0 +1,39 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+var shelljs = require('shelljs');
+var verbose;
+
+function exec(cmd, onFinish, onData) {
+if (onFinish instanceof Function || onFinish === null) {
+var result = shelljs.exec(cmd, {async: true, silent: !verbose},
onFinish);
+
+if (onData instanceof Function) {
+result.stdout.on('data', onData);
+}
+} else {
+return shelljs.exec(cmd, {silent: !verbose});
+}
+}
+
+exec.setVerboseLevel = function(_verbose) {
+verbose = _verbose;
+};
+
+module.exports = exec;
--- End diff --
It simplifies working with shell
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-paramedic pull request: Paramedic improvements
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/3#discussion_r59001026
--- Diff: lib/paramedic.js ---
@@ -0,0 +1,232 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+var exec = require('./utils').exec,
+shell = require('shelljs'),
+Server = require('./LocalServer'),
+Q = require('q'),
+tmp = require('tmp'),
+PluginsManager = require('./PluginsManager'),
+path = require('path'),
+Q = require('q'),
+fs = require('fs'),
+getReporters = require('./Reporters'),
+logger = require('./utils').logger;
+
+// Time to wait for initial device connection.
+// If device has not connected within this interval the tests are stopped.
+var INITIAL_CONNECTION_TIMEOUT = 30; // 5mins
+
+function ParamedicRunner(config, _callback) {
+this.tempFolder = null;
+this.pluginsManager = null;
+
+this.config = config;
+
+exec.setVerboseLevel(config.isVerbose());
+}
+
+ParamedicRunner.prototype.run = function() {
+var self = this;
+
+return Q().then(function() {
+self.createTempProject();
+self.prepareProjectToRunTests();
+return Server.startServer(self.config.getPorts(),
self.config.getExternalServerUrl(), self.config.getUseTunnel());
+})
+.then(function(server) {
+self.server = server;
+
+self.injectReporters();
+self.subcribeForEvents();
+
+var connectionUrl = server.getConnectionUrl() ||
+
server.getStandartUrlForPlatform(self.config.getPlatformId());
+self.writeMedicConnectionUrl(connectionUrl);
+
+return self.runTests();
+})
+.fin(function() {
+self.cleanUpProject();
+});
+};
+
+ParamedicRunner.prototype.createTempProject = function() {
+this.tempFolder = tmp.dirSync();
+tmp.setGracefulCleanup();
+logger.info("cordova-paramedic: creating temp project at " +
this.tempFolder.name);
+exec('cordova create ' + this.tempFolder.name);
+shell.pushd(this.tempFolder.name);
+};
+
+ParamedicRunner.prototype.prepareProjectToRunTests = function() {
+this.installPlugins();
+this.setUpStartPage();
+this.installPlatform();
+this.checkPlatformRequirements();
+};
+
+ParamedicRunner.prototype.installPlugins = function() {
+logger.info("cordova-paramedic: installing plugins");
+this.pluginsManager = new PluginsManager(this.tempFolder.name,
this.storedCWD);
+this.pluginsManager.installPlugins(this.config.getPlugins());
+this.pluginsManager.installTestsForExistingPlugins();
+
this.pluginsManager.installSinglePlugin('cordova-plugin-test-framework');
+this.pluginsManager.installSinglePlugin('cordova-plugin-device');
+this.pluginsManager.installSinglePlugin(path.join(__dirname,
'../paramedic-plugin'));
+};
+
+ParamedicRunner.prototype.setUpStartPage = function() {
+logger.normal("cordova-paramedic: setting app start page to test
page");
+shell.sed('-i', 'src="index.html"', 'src="cdvtests/index.html"',
'config.xml');
+};
+
+ParamedicRunner.prototype.installPlatform = function() {
+logger.info("cordova-paramedic: adding platform : " +
this.config.getPlatform());
+exec('cordova platform add ' + this.config.getPlatform());
+};
+
+ParamedicRunner.prototype.checkPlatformRequirements = function() {
+logger.normal("cordova-paramedic: checking requirements for platform "
+ this.config.getPlatformId());
+var result = exec('cordova requirements ' +
this.config.getPlatformId());
+
+if (result.code !== 0)
+throw new Error('Platform requirements check has failed!');
+};
+
+Param
[GitHub] cordova-paramedic pull request: Paramedic improvements
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/3#discussion_r58692210
--- Diff: lib/paramedic.js ---
@@ -0,0 +1,205 @@
+#!/usr/bin/env node
+
+var exec = require('./utils').exec,
+shell = require('shelljs'),
+Server = require('./LocalServer'),
+Q = require('q'),
+tmp = require('tmp'),
+PluginsManager = require('./PluginsManager'),
+path = require('path'),
+Q = require('q'),
+fs = require('fs'),
+getReporters = require('./Reporters'),
+logger = require('./utils').logger;
+
+function ParamedicRunner(config, _callback) {
+this.tempFolder = null;
+this.pluginsManager = null;
+
+this.config = config;
+
+exec.setVerboseLevel(config.isVerbose());
+}
+
+ParamedicRunner.prototype.run = function() {
+var self = this;
+
+return Q().then(function() {
+self.createTempProject();
+self.prepareProjectToRunTests();
+return Server.startServer(self.config.getPorts(),
self.config.getExternalServerUrl(), self.config.getUseTunnel());
+})
+.then(function(server) {
+self.server = server;
+
+self.injectReporters();
+self.subcribeForEvents();
+
+var connectionUrl = server.getConnectionUrl() ||
+
server.getStandartUrlForPlatform(self.config.getPlatformId());
+self.writeMedicConnectionUrl(connectionUrl);
+
+return self.runTests();
+})
+.fin(function() {
+self.cleanUpProject();
+});
+};
+
+ParamedicRunner.prototype.createTempProject = function() {
+this.tempFolder = tmp.dirSync();
+tmp.setGracefulCleanup();
+logger.info("cordova-paramedic: creating temp project at " +
this.tempFolder.name);
+exec('cordova create ' + this.tempFolder.name);
+shell.pushd(this.tempFolder.name);
+};
+
+ParamedicRunner.prototype.prepareProjectToRunTests = function() {
+this.installPlugins();
+this.setUpStartPage();
+this.installPlatform();
+this.checkPlatformRequirements();
+};
+
+ParamedicRunner.prototype.installPlugins = function() {
+logger.info("cordova-paramedic: installing plugins");
+this.pluginsManager = new PluginsManager(this.tempFolder.name,
this.storedCWD);
+this.pluginsManager.installPlugins(this.config.getPlugins());
+this.pluginsManager.installTestsForExistingPlugins();
+
this.pluginsManager.installSinglePlugin('cordova-plugin-test-framework');
+this.pluginsManager.installSinglePlugin('cordova-plugin-device');
+this.pluginsManager.installSinglePlugin(path.join(__dirname,
'../paramedic-plugin'));
+};
+
+ParamedicRunner.prototype.setUpStartPage = function() {
+logger.normal("cordova-paramedic: setting app start page to test
page");
+shell.sed('-i', 'src="index.html"', 'src="cdvtests/index.html"',
'config.xml');
+};
+
+ParamedicRunner.prototype.installPlatform = function() {
+logger.normal("cordova-paramedic: adding platform : " +
this.config.getPlatform());
+exec('cordova platform add ' + this.config.getPlatform());
+};
+
+ParamedicRunner.prototype.checkPlatformRequirements = function() {
+logger.normal("cordova-paramedic: checking requirements for platform "
+ this.config.getPlatformId());
+var result = exec('cordova requirements ' +
this.config.getPlatformId());
+
+if (result.code !== 0)
+throw new Error('Platform requirements check has failed!');
+};
+
+ParamedicRunner.prototype.injectReporters = function() {
+var self = this;
+var reporters = getReporters(self.config.getReportSavePath());
+
+['jasmineStarted', 'specStarted', 'specDone',
+'suiteStarted', 'suiteDone', 'jasmineDone'].forEach(function(route) {
+reporters.forEach(function(reporter) {
+if (reporter[route] instanceof Function)
+self.server.on(route, reporter[route].bind(reporter));
+});
+});
+};
+
+ParamedicRunner.prototype.subcribeForEvents = function() {
+this.server.on('deviceLog', function(data) {
+logger.verbose('device|console.' + data.type + ': ' +
data.msg[0]);
+});
+
+this.server.on('deviceInfo', function(data) {
+logger.info('cordova-paramedic: Device info: ' +
JSON.stringify(data));
+});
+};
+
+ParamedicRunner.prototype.writeMedicConnectionUrl = function(url) {
+logger.normal("cordova-paramedic: writing medic log url to project " +
url);
[GitHub] cordova-paramedic pull request: Paramedic improvements
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/3#discussion_r58692216
--- Diff: lib/LocalServer.js ---
@@ -0,0 +1,122 @@
+var Q = require('q'),
--- End diff --
Done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-paramedic pull request: Paramedic improvements
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/3#discussion_r58688217
--- Diff: paramedic-plugin/paramedic.js ---
@@ -0,0 +1,74 @@
+var io = cordova.require('cordova-plugin-paramedic.socket.io');
--- End diff --
This is cordovaRequire (paramedic.js is plugin script, not a node module )
which works slightly different.
The _require("socket.io")_ and _require("./socket.io")_ won't work in this
case.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10622 Support any MRT qualifiers ...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-windows/pull/159#issuecomment-202743738 Reviewed and verified on sample config/images :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10178 Added `target` attribute docs ...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-docs/pull/558#issuecomment-197379532 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request: CB-10399 Added Appium tests
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/101#issuecomment-197526519 @dblotsky We don't have manual tests - we have buttons demonstrating api calls (for both api classes - with and without user interaction), there are no validation logic there. There are two options how we can proceed IMO (i'm fine with both of them): 1. Made them as real tests (as you mentioned above so you can run them w/o appium). I actually support idea to be able to run tests manually if needed. Where do you think should be validation logic in this case (appium side or client app side)? Should we create separate button for each option/combination for Camera tests for example, or use switches/etc. Also manual api code writes results to divs/dom elements so we will have to bring extra complexity to tests to find/parse results from dom elements before validation. 2. Don't use those buttons at all (same reason why unit tests don't rely on calling buttons) - calling single cordova function from appium and getting callback result is simple. This may lead to more clean/readable code and tests definitions and simplify tests maintenance. Agree regarding `fn.toString()`, but there is a special function for this - you can execute function in browser context from appium. http://webdriver.io/api/protocol/execute.html --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request: CB-10399 Added Appium tests
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r56317001
--- Diff: appium-tests/helpers/contactsHelper.js ---
@@ -0,0 +1,222 @@
+/* jshint node: true */
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ *
+*/
+
+'use strict';
+
+function prepare(item) {
+if (typeof item === 'object') {
+return JSON.stringify(item);
+}
+if (typeof item === 'string') {
+return '"' + item + '"';
+}
+return undefined;
+}
+
+module.exports.getContactName = function (firstName, lastName) {
+return {
+formatted: firstName == lastName === undefined ? null : firstName
+ ' ' + lastName,
+familyName: lastName,
+givenName: firstName,
+middleName: ''
+};
+};
+
+module.exports.getAddContactCode = function (displayName, contactName,
phoneNumber) {
+var preparedDisplayName = prepare(displayName);
+console.log('preparedDisplayName is ' + preparedDisplayName);
+var preparedContactName = prepare(contactName);
+var preparedPhoneNumber = prepare(phoneNumber);
+
+var result =
+'try {\n' +
+'var results = document.getElementById("info");\n' +
+'var contact = navigator.contacts.create({ "displayName": ' +
preparedDisplayName + ', "name": ' + preparedContactName + ', "note":
"DeleteMe" });\n' +
+
+'var phoneNumbers = [1];\n' +
+'phoneNumbers[0] = new ContactField("work", ' +
preparedPhoneNumber + ', true);\n' +
+'contact.phoneNumbers = phoneNumbers;\n' +
+
+'contact.save(function() {\n' +
+'results.innerHTML = "' + (displayName || 'Nameless
contact') + ' saved.";\n' +
+'}, function(e) {\n' +
+'if (e.code === ContactError.NOT_SUPPORTED_ERROR) {\n' +
+'results.innerHTML = "Saving contacts not
supported.";\n' +
+'} else {\n' +
+'results.innerHTML = "Contact save failed: error " +
e.code;\n' +
+'}\n' +
+'});\n' +
+'} catch (e) {\n' +
+'var results = document.getElementById("info");\n' +
+'results.innerHTML = "ERROR: " + e.code;\n' +
+'}\n';
+
+return result;
+};
+
+module.exports.getGetContactsCode = function (filter) {
+var preparedFilter = prepare(filter);
+
+var result =
+'var results = document.getElementById("info");\n' +
+'var obj = new ContactFindOptions();\n' +
+'if (' + preparedFilter + ') {\n' +
+'obj.filter = ' + preparedFilter + ';\n' +
+'}\n' +
+'obj.multiple = true;\n' +
+'navigator.contacts.find(["displayName", "name", "phoneNumbers",
"emails", "urls", "note"], function(contacts) {\n' +
+'var s = "";\n' +
+'if (contacts.length === 0) {\n' +
+'s = "No contacts found";\n' +
+'} else {\n' +
+'s = "Number of contacts: " + contacts.length +
"NamePhoneEmail";\n' +
+'for (var i = 0; i < contacts.length; i++) {\n' +
+'var contact = contacts[i];\n' +
+'var contactNameTag = contact.name ? "" +
contact.name.formatted + "" : "(No Name)";\n' +
+'s = s + contactNameTag;\n' +
+'if (contact.phoneNumbers &&
contact.phoneNumbers.length > 0) {\n' +
+'s = s + contact.phoneNumbers[0].value;\n' +
+
[GitHub] cordova-plugin-contacts pull request: CB-10399 Added Appium tests
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r56311100
--- Diff: appium-tests/helpers/contactsHelper.js ---
@@ -0,0 +1,222 @@
+/* jshint node: true */
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ *
+*/
+
+'use strict';
+
+function prepare(item) {
+if (typeof item === 'object') {
+return JSON.stringify(item);
+}
+if (typeof item === 'string') {
+return '"' + item + '"';
+}
+return undefined;
+}
+
+module.exports.getContactName = function (firstName, lastName) {
+return {
+formatted: firstName == lastName === undefined ? null : firstName
+ ' ' + lastName,
+familyName: lastName,
+givenName: firstName,
+middleName: ''
+};
+};
+
+module.exports.getAddContactCode = function (displayName, contactName,
phoneNumber) {
+var preparedDisplayName = prepare(displayName);
+console.log('preparedDisplayName is ' + preparedDisplayName);
+var preparedContactName = prepare(contactName);
+var preparedPhoneNumber = prepare(phoneNumber);
+
+var result =
+'try {\n' +
+'var results = document.getElementById("info");\n' +
+'var contact = navigator.contacts.create({ "displayName": ' +
preparedDisplayName + ', "name": ' + preparedContactName + ', "note":
"DeleteMe" });\n' +
+
+'var phoneNumbers = [1];\n' +
+'phoneNumbers[0] = new ContactField("work", ' +
preparedPhoneNumber + ', true);\n' +
+'contact.phoneNumbers = phoneNumbers;\n' +
+
+'contact.save(function() {\n' +
+'results.innerHTML = "' + (displayName || 'Nameless
contact') + ' saved.";\n' +
+'}, function(e) {\n' +
+'if (e.code === ContactError.NOT_SUPPORTED_ERROR) {\n' +
+'results.innerHTML = "Saving contacts not
supported.";\n' +
+'} else {\n' +
+'results.innerHTML = "Contact save failed: error " +
e.code;\n' +
+'}\n' +
+'});\n' +
+'} catch (e) {\n' +
+'var results = document.getElementById("info");\n' +
+'results.innerHTML = "ERROR: " + e.code;\n' +
+'}\n';
+
+return result;
+};
+
+module.exports.getGetContactsCode = function (filter) {
+var preparedFilter = prepare(filter);
+
+var result =
+'var results = document.getElementById("info");\n' +
+'var obj = new ContactFindOptions();\n' +
+'if (' + preparedFilter + ') {\n' +
+'obj.filter = ' + preparedFilter + ';\n' +
+'}\n' +
+'obj.multiple = true;\n' +
+'navigator.contacts.find(["displayName", "name", "phoneNumbers",
"emails", "urls", "note"], function(contacts) {\n' +
+'var s = "";\n' +
+'if (contacts.length === 0) {\n' +
+'s = "No contacts found";\n' +
+'} else {\n' +
+'s = "Number of contacts: " + contacts.length +
"NamePhoneEmail";\n' +
+'for (var i = 0; i < contacts.length; i++) {\n' +
+'var contact = contacts[i];\n' +
+'var contactNameTag = contact.name ? "" +
contact.name.formatted + "" : "(No Name)";\n' +
+'s = s + contactNameTag;\n' +
+'if (contact.phoneNumbers &&
contact.phoneNumbers.length > 0) {\n' +
+'s = s + contact.phoneNumbers[0].value;\n' +
+
[GitHub] cordova-lib pull request: CB-10583 Protect plugin preferences from...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-lib/pull/400#issuecomment-188757069 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10622 Fix targetsize images being...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-windows/pull/148#issuecomment-184521979 Hey @andorman, the PR's source and destination branches are incorrect - you can see there are many unrelated commits/changes here. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: don't copy resource-files at plugin ...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-windows/pull/139#issuecomment-183633182 Tested and merged, @biasmv Marco - thx for the patch! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: don't copy resource-files at plugin ...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-windows/pull/139#issuecomment-182766890 I'll test new version and merge later today --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: CB-10538 cordova-plugin-...
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/149 CB-10538 cordova-plugin-inappbrowser timeout issue Switched to Apache Community home page as test page and increased timeout just in case (looks like there are some scripts on Apache home page preventing page to fully loaded in time in some cases). @alsorokin PTAL as you have stable repro. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-plugin-inappbrowser CB-10538 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-inappbrowser/pull/149.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #149 commit 6650a9ba0fa2dd172be70b59213e8839980dd01b Author: sgrebnov <v-seg...@microsoft.com> Date: 2016-02-08T09:55:47Z CB-10538 cordova-plugin-inappbrowser timeout issue There are some google scripts on Apache home page preventing page to fully loaded in time in some cases. Switched to Apache Community home page as test page and increased timeout just in case. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: CB-10395 InAppBrowser's ...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/147#issuecomment-181266293 Thx for review - updated, tested and merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: Allow for navigateTo met...
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/126#issuecomment-181525114
I think we should close this PR as this won't work on other platforms and
you can also do the following:
```
ref.executeScript({code: 'location.href="http://some-page.html;'})
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: CB-8467 provide hide met...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/101#issuecomment-181528137 lgtm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: CB-10395 InAppBrowser's ...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/147#issuecomment-180319788 pls review updated version --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10495 Adds cordova-windows 4.3.1 rel...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-docs/pull/485#issuecomment-179789660 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: CB-10395 InAppBrowser's ...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/147#issuecomment-179787521 @wolframkriesing please review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: CB-10395 InAppBrowser's ...
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/147 CB-10395 InAppBrowser's WebView not storing cookies reliable https://issues.apache.org/jira/browse/CB-10395 You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-plugin-inappbrowser CB-10395 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-inappbrowser/pull/147.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #147 commit 6e5900b8b295cd21dec9a9e2313513fa1304afae Author: Wolfram Kriesing <wolfram+git...@kriesing.de> Date: 2016-01-20T20:55:03Z CB-10395 InAppBrowser's WebView not storing cookies reliable to local device storage --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: inappbrower plugin has b...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/131#issuecomment-179780091 @gaoyuan123 - thank you for the pach, I see that this change is already in repo master, please close this PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: hack: very bad fix but j...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/71#issuecomment-179782033 @mysegfault Thank you for path - this has been fixed similar way w/ small change by the following commit, pls close this PR. https://github.com/apache/cordova-plugin-inappbrowser/commit/73ed40fe0753ac9870333784c216cdb821402989 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10505 Adds cordova-plugin-inappbrows...
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-docs/pull/486 CB-10505 Adds cordova-plugin-inappbrowser 1.2.1 release blog post You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-docs CB-10505 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/486.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #486 commit 6f4040141c2885f1dde1d3e89af70c75435b4083 Author: sgrebnov <v-seg...@microsoft.com> Date: 2016-02-04T13:08:24Z CB-10505 Adds cordova-plugin-inappbrowser 1.2.1 release blog post --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10505 Adds cordova-plugin-inappbrows...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-docs/pull/486#issuecomment-179835728 Updated, @csantanapr thx for review! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: Fix for CB-10305
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/137#issuecomment-179896028 Is it still actual? - Looks like we have dropped iOS 7.0 support - see CB-9726 Update minimum Deployment Target to iOS 8.0 (https://issues.apache.org/jira/browse/CB-9726) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: Fix for CB-10305
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/137#issuecomment-179900260 I see, merging... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10465 Pass correct options to prepare...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-lib/pull/374#issuecomment-179263903 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-medic pull request: CB-10396 Implemented Appium test runne...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-medic/pull/70#issuecomment-179332769 lgtm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: CB-7500 executeScript wi...
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/146 CB-7500 executeScript with callback kills/blurs inAppBrowser window https://issues.apache.org/jira/browse/CB-7500 You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-plugin-inappbrowser CB-7500 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-inappbrowser/pull/146.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #146 commit 2938303cb6298cc7c74d22a2faa0050bdfef292f Author: sgrebnov <v-seg...@microsoft.com> Date: 2016-02-03T19:49:19Z CB-7500 executeScript with callback kills/blurs inAppBrowser window after callback exit --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: CB-7786 android: add new...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/132#issuecomment-179030795 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10480 Remove Windows 8 template f...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-windows/pull/147#issuecomment-179031723 Reviewed changes, :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: CB-10456 InAppBrowser is...
Github user sgrebnov closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/143 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: don't copy resource-files at plugin ...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-windows/pull/139#issuecomment-176733241 I've tried this approach and it seems to work very well. The only two things I've noticed are: 1. Generated `Include` is absolute, this could be a problem for remote build tools and when you move the app or send someone else. But I think this could be easily fixed. ``` x64/foo.dll Always ``` 2. Includes to files which are outside the VS project are showed like linked folder is missing so this may confuse people  But in general this works well and should simplify working with arch-specific native dependencies a lot. File is correctly placed in generated package so there should no be any runtime issues --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: don't copy resource-files at plugin ...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-windows/pull/139#issuecomment-176740857 Here is my +1, but it will be great if someone else can take a look on this change as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: InAppBrowser bugfixing o...
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/145 InAppBrowser bugfixing on Windows: CB-10451, CB-10452, CB-10454 CB-10451 InAppBrowser: loadstart event is not triggered on Windows CB-10452 InAppBrowser: 'exit' event is not triggered on Windows CB-10454 InAppBrowser: 'loaderror' event does not have code and message on Windows You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-plugin-inappbrowser windows-improvements Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-inappbrowser/pull/145.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #145 commit 2bb462b79daabbdaaa0fda1f7eff401e19fec747 Author: sgrebnov <v-seg...@microsoft.com> Date: 2016-01-28T16:08:27Z CB-10451 InAppBrowser: loadstart event is not triggered on Windows CB-10452 InAppBrowser: 'exit' event is not triggered on Windows CB-10454 InAppBrowser: 'loaderror' event does not have code and message on Windows --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: CB-10456 InAppBrowser is...
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/143 CB-10456 InAppBrowser is not closed if I close it programmatically on Android https://issues.apache.org/jira/browse/CB-10456 This happens due to race condition: open/initialization logic is queued into ui thread, but dialog close method test for null is not, so if I do open and then close then close method test is executed before open method is completed. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-plugin-inappbrowser CB-10456 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-inappbrowser/pull/143.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #143 commit 4a2878aa5ef91f250823360f50ba9c963b52f601 Author: sgrebnov <v-seg...@microsoft.com> Date: 2016-01-28T09:35:53Z CB-10456 InAppBrowser is not closed if I close it programmatically on Android --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: CB-10138 Adds missing plugin metadat...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-android/pull/254#issuecomment-176075769 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: InAppBrowser bugfixing o...
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/145#issuecomment-176320293
setTimeout is required to support the following scenario. On ios, android
and other platforms functionality creates InAppBrowser on native side, so ln2
happens before webview is created and events are triggered. As a quick fix on
Windows I made open method async so that it works (this is what docs recommend
to use so we should support this). Since I made open async I made async other
methods so that their functionality is triggered after open.
```
ln1: var ref = cordova.InAppBrowser.open()
ln2: ref.addEventListener('startload', function() {..})
ln3: ref.close()
```
PS. Thank you for the setImmediate tip - will update the code
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: CB-6702 InAppBrowser han...
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/144 CB-6702 InAppBrowser hangs when opening more than one instance https://issues.apache.org/jira/browse/CB-6702 You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-plugin-inappbrowser CB-6702 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-inappbrowser/pull/144.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #144 commit 653f3b58617bfaa71f2a312506081361b7599a48 Author: sgrebnov <v-seg...@microsoft.com> Date: 2016-01-28T14:16:32Z CB-6702 InAppBrowser hangs when opening more than one instance --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: CB-6702 InAppBrowser han...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/144#issuecomment-176206237 This fix is similar to what @mysegfault proposed below. I've just added logic to prevent the dialog for being dismissed twice. https://github.com/apache/cordova-plugin-inappbrowser/pull/71/files --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: InAppBrowser bugfixing o...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/145#issuecomment-176253919 Use the following url to review proposed changes w/o whitespace: https://github.com/apache/cordova-plugin-inappbrowser/pull/145/files?w=1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: Fix syntax error when br...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/127#issuecomment-176041352 @alexbuijs thank you for proposed patch, but we can't remove this line as it is required for InAppBrowser to work correct when app is emulated using Ripple emulator. The problem has been fixed here: https://github.com/apache/cordova-plugin-inappbrowser/commit/2e0dc26eaa023e9d553a78c4acf25af751cc8021?w=1 Please consider closing this PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: CB-10441 Add auto tests ...
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/142 CB-10441 Add auto tests for InAppBrowser plugin https://issues.apache.org/jira/browse/CB-10441 Added the following unit tests: 1. `cordova.InAppBrowser.open` method exists and return `InAppBrowser` instance as a result 2. `loadstart` and `loadstop` events callbacks are called You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-plugin-inappbrowser CB-10441 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-inappbrowser/pull/142.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #142 commit ff705db31a6341326bbd2e56dff34908f77fccdc Author: sgrebnov <v-seg...@microsoft.com> Date: 2016-01-27T09:35:44Z CB-10441 Add auto tests for InAppBrowser plugin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file pull request: CB-10419 cordova-plugin-file 4.0...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/157#issuecomment-174944041 You can review PR w/o space changes using `?w=1` param: https://github.com/apache/cordova-plugin-file/pull/157?w=1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: CB-10428 Fix syntax erro...
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/141 CB-10428 Fix syntax error when browserifying inAppBrowser plugin https://issues.apache.org/jira/browse/CB-10428 Wrapped module in anonymous function You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-plugin-inappbrowser CB-10428 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-inappbrowser/pull/141.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #141 commit d3f56b7fd23dfdc9e283769af641007aeb2f0868 Author: sgrebnov <v-seg...@microsoft.com> Date: 2016-01-26T09:06:49Z CB-10428 Fix syntax error when browserifying inAppBrowser plugin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: CB-10428 Fix syntax erro...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/141#issuecomment-174916119 Use `?w=1` param to ignore space changes: https://github.com/apache/cordova-plugin-inappbrowser/pull/141/files?w=1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: don't copy resource-files at plugin ...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-windows/pull/139#issuecomment-175442601 Hi @biasmv - I'll take a look and respond today or tomorrow, thank you for clarification --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: CB-10421 Fixes exception when callin...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-android/pull/252#issuecomment-175033258 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-9516 Android SplashSc...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/75#issuecomment-174954242 lgtm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: don't copy resource-files at plugin ...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-windows/pull/139#issuecomment-174453773 I like the idea, but I think we will miss `target` attribute support as resource-file will be always copied to root (pls correct me if I'm wrong). In some cases you will want to use `resource-file` to specify some asset which is available for the app in runtime (image/json/xml/etc). https://cordova.apache.org/docs/en/dev/plugin_ref/spec.html#link-resource-file-and-header-file-elements Also, I believe using target attribute you will be able to get it working, for example ``` ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: don't copy resource-files at plugin ...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-windows/pull/139#issuecomment-174454890 @nikhilkh - looks like the doc describing `target` support on windows and corresponding example exist in dev version only.We should make it released. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10381 fix the bug when removing a...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-windows/pull/140#issuecomment-173476489 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-8396 Add AutoHideSpla...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/74#issuecomment-171911919 :+1: lgtm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10356 "npm install" fails for cor...
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-windows/pull/137 CB-10356 "npm install" fails for cordova-windows https://issues.apache.org/jira/browse/CB-10356 You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-windows CB-10356 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-windows/pull/137.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #137 commit af525e557a54279a8a099a45bc96a87892edc0b6 Author: sgrebnov <v-seg...@microsoft.com> Date: 2016-01-14T08:04:57Z CB-10356 "npm install" fails for cordova-windows --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10234 Better error message when W...
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-windows/pull/138 CB-10234 Better error message when Windows10 requires 'arch' flag This patch adds the following error message:  Original message is showed below:  You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-windows CB-10234 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-windows/pull/138.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #138 commit 89d284ba530dfca367bdcc2c099c797f25f1fe94 Author: sgrebnov <v-seg...@microsoft.com> Date: 2016-01-14T12:13:51Z CB-10234 Better error message when Windows10 requires 'arch' flag --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10344 Fixed icons and splashscree...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-windows/pull/136#issuecomment-171542813 looks great, thank you a lot - will merge after fixing core windows install issue. PS. Can you also take a look if we can auto test this case please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-geolocation pull request: CB-10319 android: Adding ...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/66#issuecomment-171207462 PS. Kudos to @riknoll for very good code documentation --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-geolocation pull request: CB-10319 android: Adding ...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/66#issuecomment-171206449 Manual tests should be valid, I used them while testing (but I used only real devices while testing). The code looks good so I'm going to verify it on real devices (w/ cordova-android@5.0 and pre-5.0) and merge later today --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: CB-10009 Improve InAppBr...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/129#issuecomment-170513142 Re-based on top of master and merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10303 Fixes build arguments parsi...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-windows/pull/135#issuecomment-169325776 lgtm :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10193 Add BOM to www files at bui...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-windows/pull/134#issuecomment-168987357 lgtm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-geolocation pull request: CB-10286 Don't skip autom...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/65#issuecomment-168607399 Actually, starting from Android M we now have Permissions prompt dialog so those tests can't be run in silent mode so we should skip them as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-geolocation pull request: CB-10286 Don't skip autom...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/65#issuecomment-168904893 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-geolocation pull request: Fixed enableHighAccuracy:...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/39#issuecomment-168915147 :+1: lgtm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-geolocation pull request: CB-10285 Added tests for ...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/64#issuecomment-168605696 :+1: lgtm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-geolocation pull request: CB-10286 Don't skip autom...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/65#issuecomment-168605706 :+1: lgtm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-geolocation pull request: CB-10278 geolocation watc...
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/63#discussion_r48600376
--- Diff: www/android/geolocation.js ---
@@ -38,21 +39,29 @@ module.exports = {
},
watchPosition: function(success, error, args) {
+var pluginWatchId = utils.createUUID();
+
var win = function() {
var geo =
cordova.require('cordova/modulemapper').getOriginalSymbol(window,
'navigator.geolocation');
-geo.watchPosition(success, error, {
+pluginToNativeWatchMap[pluginWatchId] =
geo.watchPosition(success, error, {
enableHighAccuracy: args[1]
});
};
exec(win, error, "Geolocation", "getPermission", []);
+
+return pluginWatchId;
},
-clearWatch: function(success, error, args) {
+clearWatch: function(pluginWatchId) {
var win = function() {
- var geo =
cordova.require('cordova/modulemapper').getOriginalSymbol(window,
'navigator.geolocation');
- geo.clearWatch(args[0]);
+var nativeWatchId = pluginToNativeWatchMap[pluginWatchId];
--- End diff --
I tested this case and incorrect value (which does not exist or undefined)
was ignored w/o any error or exception
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-geolocation pull request: CB-10277 Android: error c...
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/62#discussion_r48600533
--- Diff: www/android/geolocation.js ---
@@ -52,7 +62,20 @@ module.exports = {
var geo =
cordova.require('cordova/modulemapper').getOriginalSymbol(window,
'navigator.geolocation');
geo.clearWatch(args[0]);
}
-exec(win, error, "Geolocation", "getPermission", []);
+var fail = function() {
+if (error) {
+error(illegalAccessError);
+}
+};
+exec(win, fail, "Geolocation", "getPermission", []);
}
};
+// mimic PositionError to be compliant with W3C spec
+var illegalAccessError = {
--- End diff --
Currently PositionError is not available on Andoroid as we don't include
that file, but I think we can include it and use it - I'll update PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-statusbar pull request: CB-10118 Fixes error plugin...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/43#issuecomment-167989868 lgtm! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-statusbar pull request: CB-9513 Allow to show/hide ...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/42#issuecomment-167990042 lgtm! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-geolocation pull request: CB-10278 geolocation watc...
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-plugin-geolocation/pull/63 CB-10278 geolocation watchPosition doesn't return watchID string https://issues.apache.org/jira/browse/CB-10278 You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-plugin-geolocation CB-10278 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-geolocation/pull/63.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #63 commit e9626e5d66ba94d7eea9938a7d018592872d247d Author: sgrebnov <v-seg...@microsoft.com> Date: 2015-12-29T16:52:56Z CB-10278 geolocation watchPosition doesn't return watchID string --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-geolocation pull request: CB-10277 Error callback s...
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-plugin-geolocation/pull/62 CB-10277 Error callback should be called w/ PositionError if deny location access https://issues.apache.org/jira/browse/CB-10277 You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-plugin-geolocation CB-10277 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-geolocation/pull/62.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #62 commit 9fcdcfc88a17c10c701aa36f18a06a74e6fce831 Author: sgrebnov <v-seg...@microsoft.com> Date: 2015-12-29T09:26:25Z CB-10277 Error callback should be called w/ PositionError when location access is denied --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-geolocation pull request: Fix crash on deny permiss...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/57#issuecomment-167757946 @ochakov could you please create associated JIRA issue or post repro steps here. http://cordova.apache.org/contribute/issues.html I don't see app crash when I deny location access and can see error callback is correctly called in this case. From the code `context` is set in `execute` method so technically this should never happen or there is some tricky case (background/foreground or something) and should be investigated further to find root cause. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-geolocation pull request: CB-2845 PositionError con...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/58#issuecomment-167549762 @alsorokin please see if you can extend one of the tests you are currently working on to cover this test as well (PositionError can't be instantiated when using browser geolocation native api so there must be a test passing invalid params and testing resultant object) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-geolocation pull request: CB-2845 PositionError con...
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-plugin-geolocation/pull/58 CB-2845 PositionError constants not attached to prototype as per W3C https://issues.apache.org/jira/browse/CB-2845 You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-plugin-geolocation CB-2845 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-geolocation/pull/58.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #58 commit d0b6f8c972c41328a555b203b0a41a492d375396 Author: sgrebnov <v-seg...@microsoft.com> Date: 2015-12-28T11:31:44Z CB-2845 PositionError constants not attached to prototype as specified in W3C document https://issues.apache.org/jira/browse/CB-2845 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
