[GitHub] cordova-cli pull request #284: Update readme.md - Proposal of corrections

2017-08-09 Thread stevengill 
Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-cli/pull/284#discussion_r132319941
  
--- Diff: doc/readme.md ---
@@ -374,7 +374,7 @@ based on the following criteria (listed in order of 
precedence):
 
 ### Examples
 
-- Add `cordova-plugin-camera` and `cordova-plugin-file` to the project and 
it be be saved to `config.xml` & `package.json`. Use `../plugins` directory to 
search for the plugins.
+- Add `cordova-plugin-camera` and `cordova-plugin-file` to the project and 
save it to `config.xml` & `package.json`. Use `../plugins` directory to search 
for the plugins.
--- End diff --

The example below doesn't need the `--save` flag anymore. Somehow this 
example got missed when all of the others got updated. 

`cordova plugin add cordova-plugin-camera cordova-plugin-file --searchpath 
../plugins`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request #284: Update readme.md - Proposal of corrections

2017-08-09 Thread filmaj 
Github user filmaj commented on a diff in the pull request:

https://github.com/apache/cordova-cli/pull/284#discussion_r132287655
  
--- Diff: doc/readme.md ---
@@ -186,7 +186,7 @@ After building the Android and iOS projects, the 
Android application will contai
 
  Version control
 
-It is recommended not to check in `platforms/` and `plugins/` directories 
into version control as they are considered a build artifact. Your platforms 
and plugins will be saved in config.xml & package.json automatically. These 
platforms/plugins will be downloaded when on the machine when `cordova prepare` 
is invoked.
+It is recommended not to check in `platforms/` and `plugins/` directories 
into version control as they are considered a build artifact. Your platforms 
and plugins will be saved in config.xml & package.json automatically. These 
platforms/plugins will be downloaded to the machine when `cordova prepare` is 
invoked.
--- End diff --

I think this can be further simplified to just "... will be downloaded when 
`cordova prepare` is invoked."


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request #284: Update readme.md - Proposal of corrections

2017-08-09 Thread filmaj 
Github user filmaj commented on a diff in the pull request:

https://github.com/apache/cordova-cli/pull/284#discussion_r132287819
  
--- Diff: doc/readme.md ---
@@ -230,7 +230,7 @@ cordova {platform | platforms} [
 | | --save   | Updates the version specified in 
`config.xml` |
 | | --nofetch| Do not fetch the platform using `npm 
install` and do not store it into the apps `node_modules` directory |
 | list | | List all installed and available 
platforms |
-| check || List platforms which can be updated by 
`cordova-cli platform update` |
+| check || List platforms which can be updated 
from cordova-cli with the command `platform update` |
--- End diff --

What about "... which can be updated via `cordova-cli platform update`" ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request #284: Update readme.md - Proposal of corrections

2017-08-09 Thread filmaj 
Github user filmaj commented on a diff in the pull request:

https://github.com/apache/cordova-cli/pull/284#discussion_r132287980
  
--- Diff: doc/readme.md ---
@@ -374,7 +374,7 @@ based on the following criteria (listed in order of 
precedence):
 
 ### Examples
 
-- Add `cordova-plugin-camera` and `cordova-plugin-file` to the project and 
it be be saved to `config.xml` & `package.json`. Use `../plugins` directory to 
search for the plugins.
+- Add `cordova-plugin-camera` and `cordova-plugin-file` to the project and 
save it to `config.xml` & `package.json`. Use `../plugins` directory to search 
for the plugins.
--- End diff --

This example may actually be out of date now (with respect to the `--save` 
flag). @stevengill can you comment?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request #284: Update readme.md - Proposal of corrections

2017-08-06 Thread Straust 
GitHub user Straust reopened a pull request:

https://github.com/apache/cordova-cli/pull/284

Update readme.md - Proposal of corrections



### Platforms affected


### What does this PR do?


### What testing has been done on this change?


### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Straust/cordova-cli patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-cli/pull/284.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #284


commit 5ffdf1eed3e21de7a274224334c458e3dfbf2cf2
Author: Straust <30726083+stra...@users.noreply.github.com>
Date:   2017-08-04T12:51:56Z

Update readme.md

commit 05448984108187d27932a6d0ae861e20449bd15d
Author: Straust <30726083+stra...@users.noreply.github.com>
Date:   2017-08-04T13:38:37Z

Update readme.md

commit 0ba6464a78474d5a55fd4a1f7815ea24be5d8cf2
Author: Straust <30726083+stra...@users.noreply.github.com>
Date:   2017-08-05T16:01:59Z

Update readme.md

commit 70988871450d8056f5320e938f44af0cf76c27a5
Author: Straust <30726083+stra...@users.noreply.github.com>
Date:   2017-08-06T03:56:16Z

Update readme.md

commit 15b354a2d284e434400331acef28cdf9a030aa04
Author: Straust <30726083+stra...@users.noreply.github.com>
Date:   2017-08-06T03:58:35Z

Update readme.md




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request #284: Update readme.md - Proposal of corrections

2017-08-05 Thread Straust 
Github user Straust closed the pull request at:

https://github.com/apache/cordova-cli/pull/284


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org