[GitHub] cordova-android issue #341: CB-11999 add message, catch exception if require...

2016-10-11 Thread shazron
Github user shazron commented on the issue:

https://github.com/apache/cordova-android/pull/341
  
LGTM. Whomever pulls this in, make sure to squash, amend the commit with 
the JIRA issue number


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-android issue #341: CB-11999 add message, catch exception if require...

2016-10-11 Thread codecov-io
Github user codecov-io commented on the issue:

https://github.com/apache/cordova-android/pull/341
  
## [Current 
coverage](https://codecov.io/gh/apache/cordova-android/pull/341?src=pr) is 
35.31% (diff: 0.00%)
> Merging 
[#341](https://codecov.io/gh/apache/cordova-android/pull/341?src=pr) into 
[master](https://codecov.io/gh/apache/cordova-android/branch/master?src=pr) 
will decrease coverage by **0.34%**

```diff
@@ master   #341   diff @@
==
  Files12 12  
  Lines  1015   1025+10   
  Methods 200200  
  Messages  0  0  
  Branches168168  
==
  Hits362362  
- Misses  653663+10   
  Partials  0  0  
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update 
[2532c4a...7862a82](https://codecov.io/gh/apache/cordova-android/compare/2532c4a39e9ec96aaa573c8fa54d48507019fcc7...7862a82e95ad6ceacb0f69c0ba7b6ba84db4cc68?src=pr)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org