[GitHub] cordova-android issue #363: CB-12465: Rewrite of the Unit Tests
Github user fujunwei commented on the issue: https://github.com/apache/cordova-android/pull/363 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #363: CB-12465: Rewrite of the Unit Tests
Github user fujunwei commented on the issue: https://github.com/apache/cordova-android/pull/363 All the tests has passed after updating the latest codes, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #363: CB-12465: Rewrite of the Unit Tests
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/363 @fujunwei There's a threading/concurrency issue with Espresso and checking the WebView's URI. I'm trying to adopt Espresso to reduce the amount of code in the test, but there's no docs on how to check the URI of a WebView, which I find utterly bizzare. It'd be good to get rid of all the runOnUriThread wrappers on that method somhow. That being said, throwing a sleep does brute force the test to work for now. I don't have any devices running Android Things yet. I'm going to see about fixing that today. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #363: CB-12465: Rewrite of the Unit Tests
Github user fujunwei commented on the issue: https://github.com/apache/cordova-android/pull/363 There is a test failed on SM-G9250. > org.apache.cordova.unittests.IFrameTest > iFrameHistory[SM-G9250 - 6.0.1] FAILED at junit.framework.Assert.fail(Assert.java:48) And there are two tests failed on Android Things platform. > org.apache.cordova.unittests.BackButtonMultipageTest > testViaBackButtonOnView[iot_joule - 7.0] FAILED at android.support.test.espresso.NoActivityResumedException: No activities in stage RESUMED. Did you forget to launch the activity. (test.getActivity() or similar)? > org.apache.cordova.unittests.IFrameTest > iFrameHistory[iot_joule - 7.0] FAILED at android.support.test.espresso.NoActivityResumedException: No activities in stage RESUMED. Did you forget to launch the activity. (test.getActivity() or similar)? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #363: CB-12465: Rewrite of the Unit Tests
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/363 FYI: I'll be collapsing the commits on Friday when I merge this thing in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #363: CB-12465: Rewrite of the Unit Tests
Github user codecov-io commented on the issue: https://github.com/apache/cordova-android/pull/363 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/363?src=pr=h1) Report > Merging [#363](https://codecov.io/gh/apache/cordova-android/pull/363?src=pr=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/5591a1a4e896ed8693abd5234cb2370ead20ed5d?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #363 +/- ## === Coverage 35.58% 35.58% === Files 12 12 Lines1037 1037 Branches 173 173 === Hits 369 369 Misses668 668 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/363?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Π= absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/363?src=pr=footer). Last update [5591a1a...34bd385](https://codecov.io/gh/apache/cordova-android/compare/5591a1a4e896ed8693abd5234cb2370ead20ed5d...34bd385ef28b563f1ee07e8377909f27c5c2f37d?src=pr=footer=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #363: CB-12465: Rewrite of the Unit Tests
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/363 @fujunwei OK, yeah, this is a minor mistake. The errorUrl wasn't correct in the config.xml, the test passes and it no longer hangs. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #363: CB-12465: Rewrite of the Unit Tests
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/363 @fujunwei Well, when you debug the test, it's clear that it's not redirecting to the error page that the intent defines, and instead it's going to some other page or showing a dialog window. This isn't a huge failure (in fact, this is probably a minor or trivial priority bug, since it's still a html not found error page, which should never happen on a Cordova app), but it should actually fail. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #363: CB-12465: Rewrite of the Unit Tests
Github user fujunwei commented on the issue: https://github.com/apache/cordova-android/pull/363 Do you mean the failed test will be continue to fix? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #363: CB-12465: Rewrite of the Unit Tests
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/363 @fujunwei I don't think the test should hang, but that's technically a failure of the test and not a problem with the test itself. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #363: CB-12465: Rewrite of the Unit Tests
Github user fujunwei commented on the issue: https://github.com/apache/cordova-android/pull/363 It hangs on running unit tests with `./gradlew connectedAndroidTest`, the output logs: > org.apache.cordova.unittests E/AndroidProtocolHandler: Unable to open asset URL: file:///android_asset/www/htmlnotfound/index.html --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
