[GitHub] cordova-android issue #373: Support for SDK Tools v26, simplified target par...

2017-04-07 Thread infil00p 
Github user infil00p commented on the issue:

https://github.com/apache/cordova-android/pull/373
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android issue #373: Support for SDK Tools v26, simplified target par...

2017-04-06 Thread codecov-io 
Github user codecov-io commented on the issue:

https://github.com/apache/cordova-android/pull/373
  
# 
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/373?src=pr=h1) 
Report
> Merging 
[#373](https://codecov.io/gh/apache/cordova-android/pull/373?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/cordova-android/commit/8e0f021cade1367fc2ffb5d02653f55198da?src=pr=desc)
 will **decrease** coverage by `0.87%`.
> The diff coverage is `100%`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-android/pull/373/graphs/tree.svg?width=650=pr=q14nMf6C5a=150)](https://codecov.io/gh/apache/cordova-android/pull/373?src=pr=tree)

```diff
@@Coverage Diff @@
##   master #373  +/-   ##
==
- Coverage   42.95%   42.07%   -0.88% 
==
  Files  14   14  
  Lines1362 1338  -24 
  Branches  252  245   -7 
==
- Hits  585  563  -22 
+ Misses777  775   -2
```


| [Impacted 
Files](https://codecov.io/gh/apache/cordova-android/pull/373?src=pr=tree) | 
Coverage Δ | |
|---|---|---|
| 
[bin/templates/cordova/lib/android\_sdk.js](https://codecov.io/gh/apache/cordova-android/pull/373?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9hbmRyb2lkX3Nkay5qcw==)
 | `71.42% <100%> (-10.39%)` | :arrow_down: |
| 
[bin/templates/cordova/lib/emulator.js](https://codecov.io/gh/apache/cordova-android/pull/373?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9lbXVsYXRvci5qcw==)
 | `38.34% <100%> (-0.18%)` | :arrow_down: |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-android/pull/373?src=pr=continue).
> **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing 
data`
> Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/373?src=pr=footer).
 Last update 
[8e0f021...6340a94](https://codecov.io/gh/apache/cordova-android/pull/373?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android issue #373: Support for SDK Tools v26, simplified target par...

2017-04-06 Thread shazron 
Github user shazron commented on the issue:

https://github.com/apache/cordova-android/pull/373
  
I did local testing on the sdk tools 26.0.1 and 25.2.3 
(pre-tool-removal-mess), both built fine using CLI project creation+ build,  
and standalone project creation+build.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org