[GitHub] cordova-android issue #389: CB-11244: Studio Project Compatibility: Now with...
Github user filmaj commented on the issue: https://github.com/apache/cordova-android/pull/389 Hey @infil00p, latest master has a tiny tweak to the appveyor build file that works around some troubles appveyor is experiencing with one of their VM images. I think if you rebase this, you'll find that'll clear up the appveyor failures. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #389: CB-11244: Studio Project Compatibility: Now with...
Github user codecov-io commented on the issue: https://github.com/apache/cordova-android/pull/389 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=h1) Report > Merging [#389](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/893356abcd1b005a13bb09e7467f227b52de3ae5?src=pr=desc) will **decrease** coverage by `0.37%`. > The diff coverage is `34.17%`. [](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree) ```diff @@Coverage Diff @@ ## master #389 +/- ## == - Coverage 42.55% 42.17% -0.38% == Files 17 17 Lines1678 1707 +29 Branches 304 310 +6 == + Hits 714 720 +6 - Misses964 987 +23 ``` | [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree) | Coverage Π| | |---|---|---| | [...n/templates/cordova/lib/builders/GenericBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9HZW5lcmljQnVpbGRlci5qcw==) | `30.61% <ø> (-0.38%)` | :arrow_down: | | [bin/templates/cordova/lib/builders/builders.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9idWlsZGVycy5qcw==) | `37.5% <ø> (ø)` | :arrow_up: | | [bin/templates/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZC5qcw==) | `13.04% <0%> (-0.39%)` | :arrow_down: | | [bin/templates/cordova/lib/device.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9kZXZpY2UuanM=) | `22.44% <0%> (ø)` | :arrow_up: | | [bin/templates/cordova/lib/AndroidStudio.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9BbmRyb2lkU3R1ZGlvLmpz) | `94.73% <100%> (ø)` | :arrow_up: | | [...in/templates/cordova/lib/builders/GradleBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9HcmFkbGVCdWlsZGVyLmpz) | `20% <15.78%> (-0.43%)` | :arrow_down: | | [bin/templates/cordova/Api.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL0FwaS5qcw==) | `43.36% <25%> (-1.09%)` | :arrow_down: | | [bin/lib/create.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=tree#diff-YmluL2xpYi9jcmVhdGUuanM=) | `49.26% <45.45%> (-1.57%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Π= absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=footer). Last update [893356a...d0dab4b](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #389: CB-11244: Studio Project Compatibility: Now with...
Github user filmaj commented on the issue: https://github.com/apache/cordova-android/pull/389 Yes, seriously, because the code interpolates activity name / package name / etc. into hard-coded paths! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #389: CB-11244: Studio Project Compatibility: Now with...
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/389 @filmaj Hard copied paths? SRSLY? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #389: CB-11244: Studio Project Compatibility: Now with...
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/389 @filmaj Given how old this branch is, those are the same tests that master was running until three commits ago. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #389: CB-11244: Studio Project Compatibility: Now with...
Github user filmaj commented on the issue: https://github.com/apache/cordova-android/pull/389 Maybe? I don't know. Just beware that you have very few tests running in this PR (basically just the JS unit tests, no JS e2e nor Java native unit tests) so the green checkmark next to your PR is a bit of a false positive. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #389: CB-11244: Studio Project Compatibility: Now with...
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/389 @filmaj So, I should do another merge commit just to get more tests? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #389: CB-11244: Studio Project Compatibility: Now with...
Github user filmaj commented on the issue: https://github.com/apache/cordova-android/pull/389 Right and that is now 3 commits behind master's `HEAD` :P Just saying latest master stuff will get you better testing / feedback via CI in this PR! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #389: CB-11244: Studio Project Compatibility: Now with...
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/389 The merge commit that I did was e456175a --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #389: CB-11244: Studio Project Compatibility: Now with...
Github user filmaj commented on the issue: https://github.com/apache/cordova-android/pull/389 Just based on the last travis/appveyor run in the commits in this PR, the unit tests, end to end tests and the native unit tests are not running. I don't see master HEAD in the commit list for this branch, either: ``` * a7304b9a - (HEAD -> StudioProjectCompat, infil00p/StudioProjectCompat) Finishing the linting (2 weeks ago) * e456175a - Merge branch 'master' into StudioProjectCompat (2 weeks ago) |\ | * 55d7cf38 - CB-12895 : updated .eslintrc file in spec dir and set jasmine true and removed root is true (3 weeks ago) | * ac4ac935 - CB-12895 : added .eslintrc files to set up jasmine environment (3 weeks ago) | * d83d49d8 - CB-12895 : fixed eslint errors (3 weeks ago) | * e36158a0 - CB-12895 : added eslint and removed jshint (3 weeks ago) | * 5cc14b80 - CB-12605 In Windows get Android studio path from the registry (3 weeks ago) * | b20028c4 - (infil00p/StudioProjectCleanup, StudioProjectCleanup) The prepare step was broken, which breaks the CLI workflow. This was caused by hardcoding the Java directory, which is a very bad idea. (3 weeks ago) * | 1cda7a9d - CB-11244: Found bug in Api.js where xml/strings.xml is used instead of values/strings.xml (3 weeks ago) * | 49b76f5c - Fixing mangled commits that crept into this branch (4 weeks ago) * | c0474e81 - Bump for travis test (4 weeks ago) * | 40c97094 - OK, Going back to the old build.gradle for legacy projects (4 weeks ago) * | b67e9905 - This is probably a bad idea, but we need to split the gradle files into legacy and new style (4 weeks ago) * | c74192d5 - Adding conditional code into Gradle, this is a bit dirty since we can't explicitly test it but we'll just have to rely on jasmine (4 weeks ago) * | 33feb00e - Adding the if statement to see if we can support both structures with minimal editing, TODO: actually write tests for this somehow (4 weeks ago) * | 8f16df4c - Adding logic to upgrade both Classic and Android Studio style project structures (4 weeks ago) * | fb6cb51e - Fixing lint errors (4 weeks ago) * | 28ebbb8f - CB-11244: Setup Api.js to support multiple builders based on project structure (4 weeks ago) * | bd4ddcde - Updated AndroidStudio to only look for the app directory to determine studio status (4 weeks ago) * | e621edfb - Fixing the Android Studio detection and making it automatically pick the right builder, good for upgrading Cordova (4 weeks ago) * | 304a8991 - Fixed the specification of the builders in the run command by getting build to check what was being passed from run (4 weeks ago) * | 8391af2e - JsHint Fixes, deleting unused methods (4 weeks ago) * | 69ab6a0e - Changing the project to add the app directory as a dependency (4 weeks ago) * | a216f0db - CB-11244: Changing directory creation, will most likely hide this behind a flag for the next release of Cordova-Android, and then make it default in the next major pending feedback (4 weeks ago) * | 69260fb9 - Fix the overwriting of Fil's fix, blargh (4 weeks ago) * | db87e0ae - Made changes so cordova/build builds with the new project. Need to work on plugin installation. (4 weeks ago) * | 8ead919f - Managed to get the project to mostly compile, still need to re-work the build command to add the app project (4 weeks ago) * | b73c04f3 - Updating gradle version in the build file (4 weeks ago) * | f790aeb8 - Setting up the create command so we actually have all the directories in the right place, and define default variables in the top level build.gradle (4 weeks ago) * | 7b17abc5 - Fixing linting issues (4 weeks ago) * | ffadf5dd - Changing this so we pass lint (4 weeks ago) * | 23d8d999 - Moving Android Manifest finding to the Gradle and Studio builders. (4 weeks ago) * | d88df59c - Adding the Studio Builder to build a project based on Android Studio, and deleting Ant, since Google does not support Ant Builds anymore. Sorry guys! (4 weeks ago) |/ * 3a6e898b - CB-12762 : pointed package.json repo items to github mirrors instead of apache repos site (5 weeks ago) ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #389: CB-11244: Studio Project Compatibility: Now with...
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/389 @filmaj Github says otherwise. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #389: CB-11244: Studio Project Compatibility: Now with...
Github user filmaj commented on the issue: https://github.com/apache/cordova-android/pull/389 Heh, with me merging in #391, you might need to rebase ð At least you'll get wider test feedback on Windows with it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
