[GitHub] cordova-android issue #391: CB-12950: E2E test tweaks + Appveyor now runs E2...

2017-07-10 Thread infil00p
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/391 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-android issue #391: CB-12950: E2E test tweaks + Appveyor now runs E2...

2017-07-04 Thread alsorokin
Github user alsorokin commented on the issue: https://github.com/apache/cordova-android/pull/391 Here's a JIRA issue: https://issues.apache.org/jira/browse/CB-12960 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-android issue #391: CB-12950: E2E test tweaks + Appveyor now runs E2...

2017-06-28 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-android/pull/391 @alsorokin perfect! Yeah no worries, I can do it too. How about let's file an issue for it first and then go from there? As for this particular PR, today I will attempt to start an

[GitHub] cordova-android issue #391: CB-12950: E2E test tweaks + Appveyor now runs E2...

2017-06-28 Thread alsorokin
Github user alsorokin commented on the issue: https://github.com/apache/cordova-android/pull/391 As I've already done this for plugins and have the knowledge, I can do the same thing for iOS and Android if you like, after this is merged. --- If your project is set up for it, you can

[GitHub] cordova-android issue #391: CB-12950: E2E test tweaks + Appveyor now runs E2...

2017-06-28 Thread alsorokin
Github user alsorokin commented on the issue: https://github.com/apache/cordova-android/pull/391 Take a look at this: http://austinpray.com/ops/2015/09/20/change-travis-node-version.html So, we're basically download nvm and pass it a node version stored in the environment

[GitHub] cordova-android issue #391: CB-12950: E2E test tweaks + Appveyor now runs E2...

2017-06-27 Thread purplecabbage
Github user purplecabbage commented on the issue: https://github.com/apache/cordova-android/pull/391 Yeah that might be the same issue with iOS ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-android issue #391: CB-12950: E2E test tweaks + Appveyor now runs E2...

2017-06-27 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-android/pull/391 Might be tough as we tell travis to use the Android image preset via `language: android` so it comes pre-installed with some bits from the Android SDK... --- If your project is set up for

[GitHub] cordova-android issue #391: CB-12950: E2E test tweaks + Appveyor now runs E2...

2017-06-27 Thread purplecabbage
Github user purplecabbage commented on the issue: https://github.com/apache/cordova-android/pull/391 Yeah, iOS doesn't even care ... https://github.com/apache/cordova-ios/blob/master/.travis.yml Windows does 4+6 ( without `nvm` )