[GitHub] cordova-android issue #395: CB-12423: make explicit JDK 1.8 or greater is ne...

2017-07-14 Thread infil00p 
Github user infil00p commented on the issue:

https://github.com/apache/cordova-android/pull/395
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android issue #395: CB-12423: make explicit JDK 1.8 or greater is ne...

2017-07-14 Thread filmaj 
Github user filmaj commented on the issue:

https://github.com/apache/cordova-android/pull/395
  
You cool with this change @infil00p ? Just making sure.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android issue #395: CB-12423: make explicit JDK 1.8 or greater is ne...

2017-07-14 Thread codecov-io 
Github user codecov-io commented on the issue:

https://github.com/apache/cordova-android/pull/395
  
# 
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/395?src=pr=h1) 
Report
> Merging 
[#395](https://codecov.io/gh/apache/cordova-android/pull/395?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/cordova-android/commit/5917d4ef0bd773fb54bc5b232e5ed95d3a073f8b?src=pr=desc)
 will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-android/pull/395/graphs/tree.svg?width=650=q14nMf6C5a=150=pr)](https://codecov.io/gh/apache/cordova-android/pull/395?src=pr=tree)

```diff
@@   Coverage Diff   @@
##   master #395   +/-   ##
===
  Coverage   42.55%   42.55%   
===
  Files  17   17   
  Lines1678 1678   
  Branches  304  304   
===
  Hits  714  714   
  Misses964  964
```



--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-android/pull/395?src=pr=continue).
> **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing 
data`
> Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/395?src=pr=footer).
 Last update 
[5917d4e...76dd861](https://codecov.io/gh/apache/cordova-android/pull/395?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org