[GitHub] cordova-android issue #397: CB-13031: Fix bug with case-sensitivity of andro...
Github user codecov-io commented on the issue: https://github.com/apache/cordova-android/pull/397 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/397?src=pr=h1) Report > Merging [#397](https://codecov.io/gh/apache/cordova-android/pull/397?src=pr=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/458e47968158642e803a36b2aaed15b5a789a994?src=pr=desc) will **not change** coverage. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/cordova-android/pull/397?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #397 +/- ## === Coverage 42.55% 42.55% === Files 17 17 Lines1678 1678 Branches 304 304 === Hits 714 714 Misses964 964 ``` | [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/397?src=pr=tree) | Coverage Π| | |---|---|---| | [bin/lib/create.js](https://codecov.io/gh/apache/cordova-android/pull/397?src=pr=tree#diff-YmluL2xpYi9jcmVhdGUuanM=) | `50.82% <100%> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/397?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Π= absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/397?src=pr=footer). Last update [458e479...a3f393c](https://codecov.io/gh/apache/cordova-android/pull/397?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #397: CB-13031: Fix bug with case-sensitivity of andro...
Github user filmaj commented on the issue: https://github.com/apache/cordova-android/pull/397 Hey @matrosov-nikita, rebase w/ latest master, I should have a fix (workaround) in for appveyor troubles. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #397: CB-13031: Fix bug with case-sensitivity of andro...
Github user matrosov-nikita commented on the issue: https://github.com/apache/cordova-android/pull/397 @filmaj, thanks for the information, I'm planning to merge in once Appveyor is fixed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #397: CB-13031: Fix bug with case-sensitivity of andro...
Github user matrosov-nikita commented on the issue: https://github.com/apache/cordova-android/pull/397 @filmaj, updated. But I little doubt about folders names after prepare, this PR just skips the removal of an original package if names (manifestId and androidPkgName) differ in casing only. So, `platforms\android\src\com\example\testapp` is still in the lower case despite appropriate changes in the manifest. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #397: CB-13031: Fix bug with case-sensitivity of andro...
Github user filmaj commented on the issue: https://github.com/apache/cordova-android/pull/397 Just for the record, here's the full stack trace I get when I try these steps: ``` ~/src â cordova create testapp com.example.testapp testapp Warning: using prerelease version 7.0.2-dev (cordova-lib@7.0.1) Creating a new cordova project. ~/src â cd testapp ~/src/testapp â vim config.xml ~/src/testapp â cordova platform add android Warning: using prerelease version 7.0.2-dev (cordova-lib@7.0.1) Using cordova-fetch for cordova-android@~6.2.2 Adding android project... Creating Cordova project for the Android platform: Path: platforms/android Package: com.example.testapp Name: testapp Activity: MainActivity Android target: android-25 Subproject Path: CordovaLib Android project created with cordova-android@6.2.3 Discovered plugin "cordova-plugin-whitelist" in config.xml. Adding it to the project Installing "cordova-plugin-whitelist" for android This plugin is only applicable for versions of cordova-android greater than 4.0. If you have a previous platform version, you do *not* need this plugin since the whitelist will be built in. Adding cordova-plugin-whitelist to package.json Saved plugin info for "cordova-plugin-whitelist" to config.xml ls: no such file or directory: /Users/maj/src/testapp/platforms/android/src/com/example/Testapp/*.java Error: No Java files found that extend CordovaActivity. ``` This patch seems to fix that. However, I noticed that the output even using this patch still says: ``` Package: com.example.testapp ``` Can we update the PR to also print out the correct, overridden package name, if provided? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
