[GitHub] cordova-android issue #399: CB-12730: Compat - INTEGRATE
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/399 @filmaj Another being this article https://medium.com/exploring-android/handling-android-runtime-permissions-in-ui-tests-981f9dc11a4e --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #399: CB-12730: Compat - INTEGRATE
Github user filmaj commented on the issue: https://github.com/apache/cordova-android/pull/399 One example: [this repo](https://github.com/Egorand/android-testing-runtime-permissions)'s [main test file](https://github.com/Egorand/android-testing-runtime-permissions/blob/master/app/src/androidTest/java/me/egorand/contactssync/tests/ContactsSyncTest.java) asserts that certain text is visible (like "Allow" and "Deny") when triggering the permissions dialog (via Contacts usage), and also asserts the behaviour of returning contact data if the permission is accepted. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #399: CB-12730: Compat - INTEGRATE
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/399 We should add some instrumentation native tests for this, but I have no idea how that would work, and would have to do more research into this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #399: CB-12730: Compat - INTEGRATE
Github user filmaj commented on the issue: https://github.com/apache/cordova-android/pull/399 Well glad that cleared up the CI failures. Should we add unit, or instrumentation, native tests for this? Also ping @infil00p for review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #399: CB-12730: Compat - INTEGRATE
Github user codecov-io commented on the issue: https://github.com/apache/cordova-android/pull/399 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/399?src=pr=h1) Report > Merging [#399](https://codecov.io/gh/apache/cordova-android/pull/399?src=pr=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/2b53c98cf585a2f82f9d94f9acc210f362c48f97?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/cordova-android/pull/399?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #399 +/- ## === Coverage 42.55% 42.55% === Files 17 17 Lines1678 1678 Branches 304 304 === Hits 714 714 Misses964 964 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/399?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Π= absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/399?src=pr=footer). Last update [2b53c98...d364f46](https://codecov.io/gh/apache/cordova-android/pull/399?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #399: CB-12730: Compat - INTEGRATE
Github user macdonst commented on the issue: https://github.com/apache/cordova-android/pull/399 @filmaj rebased and pushed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android issue #399: CB-12730: Compat - INTEGRATE
Github user filmaj commented on the issue: https://github.com/apache/cordova-android/pull/399 Hey @macdonst if you rebase w/ latest master, I think we can clear up the appveyor failure we're seeing in here. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
