[GitHub] cordova-cli pull request: CB-6377 Handle spaces in paths for cmd r...

2014-04-01 Thread agrieve
Github user agrieve commented on the pull request: https://github.com/apache/cordova-cli/pull/155#issuecomment-39284881 Seems I accidentally pushed the commit in its previous state (whoops!). Just played around and found that it was actually the windowsVerbatimArguments flag

[GitHub] cordova-cli pull request: CB-6377 Handle spaces in paths for cmd r...

2014-04-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/155 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-cli pull request: CB-6377 Handle spaces in paths for cmd r...

2014-03-31 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-cli/pull/155 CB-6377 Handle spaces in paths for cmd related scripts 0. as discussed elsewhere the slice() efforts on process.platform are pointless 1. for .bat, .cmd, and .js/.vbs, we want to use

[GitHub] cordova-cli pull request: CB-6377 Handle spaces in paths for cmd r...

2014-03-31 Thread agrieve
Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/155#discussion_r11130975 --- Diff: src/superspawn.js --- @@ -60,11 +60,11 @@ exports.spawn = function(cmd, args, opts) { var spawnOpts = {}; var d = Q.defer();