Auto-Re: [GitHub] cordova-ios issue #225: CB-11352: Call setUserAgent before creating a view
[GitHub] cordova-ios issue #225: CB-11352: Call setUserAgent before creating a view
Github user oliviertassinari commented on the issue: https://github.com/apache/cordova-ios/pull/225 I have just tested this PR. It's working fine on iOS 9.3 with WKWebView. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios issue #225: CB-11352: Call setUserAgent before creating a view
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/225 The lines I quoted show the descriptions of what failed - you don't need to touch the tests, just fix your code. The tests run on the standard UIWebView, not WKWebView, and must pass before any PR is accepted. In any case, in iOS 9, there is a "customUserAgent" property for WKWebView that should be set instead: https://developer.apple.com/library/ios/documentation/WebKit/Reference/WKWebView_Ref/#//apple_ref/occ/instp/WKWebView/customUserAgent and not the cordova workaround way. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios issue #225: CB-11352: Call setUserAgent before creating a view
Github user ankon commented on the issue: https://github.com/apache/cordova-ios/pull/225 Hmm. I'm quite new to objective c, so need to understand more how to fix that. Thinking along the lines of giving the engine plugin the chance to report what the user agent would be, which WKWebView then would do by creating a temporary view. Alternatively: is there a point where the engine gets called and could safely recreate the view, some form of "yes, we're good, finalize your setup?" Does that sound reasonable? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios issue #225: CB-11352: Call setUserAgent before creating a view
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/225 2 unit-test failures. (run the workspace in the tests subfolder). 1. https://github.com/apache/cordova-ios/blob/3d3a746cf86f63908da513a7c12001ee6dac7ebb/tests/CordovaLibTests/CDVUserAgentTest.m#L108 2. https://github.com/apache/cordova-ios/blob/3d3a746cf86f63908da513a7c12001ee6dac7ebb/tests/CordovaLibTests/CDVUserAgentTest.m#L132 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
