[GitHub] cordova-ios issue #237: CB-9789: Support setting the default app locale

2016-08-17 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/237 @dpogue Please send a PR for a docs update as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-ios issue #237: CB-9789: Support setting the default app locale

2016-08-17 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-ios/pull/237 @shazron Thanks, I've rebased on master and updated the tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-ios issue #237: CB-9789: Support setting the default app locale

2016-08-16 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/237 cordova-common 1.4.1 has been bundled in master, and this PR now fails one unit-test (`npm run unit-tests`: ``` Failures: 1) prepare updateProject method should write out the

[GitHub] cordova-ios issue #237: CB-9789: Support setting the default app locale

2016-08-15 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/237 https://github.com/apache/cordova-lib/pull/466 has been merged and should be in cordova-common 1.4.1 when it is released. --- If your project is set up for it, you can reply to this email and

[GitHub] cordova-ios issue #237: CB-9789: Support setting the default app locale

2016-07-25 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-ios/pull/237 The `getAttribute` method is implemented in https://github.com/apache/cordova-lib/pull/466 (which isn't merged yet) --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-ios issue #237: CB-9789: Support setting the default app locale

2016-07-25 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-ios/pull/237 Can you create a new issue for the language thing and link it instead of CB-9789? And push only the code related to that. Are there issues open for the cleanIcons and

[GitHub] cordova-ios issue #237: CB-9789: Support setting the default app locale

2016-07-21 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-ios/pull/237 ## [Current coverage][cc-pull] is 34.72% (diff: 100%) > Merging [#237][cc-pull] into [master][cc-base-branch] will decrease coverage by **17.08%** ```diff @@