Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/237
@dpogue Please send a PR for a docs update as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dpogue commented on the issue:
https://github.com/apache/cordova-ios/pull/237
@shazron Thanks, I've rebased on master and updated the tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/237
cordova-common 1.4.1 has been bundled in master, and this PR now fails one
unit-test (`npm run unit-tests`:
```
Failures:
1) prepare updateProject method should write out the
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/237
https://github.com/apache/cordova-lib/pull/466 has been merged and should
be in cordova-common 1.4.1 when it is released.
---
If your project is set up for it, you can reply to this email and
Github user dpogue commented on the issue:
https://github.com/apache/cordova-ios/pull/237
The `getAttribute` method is implemented in
https://github.com/apache/cordova-lib/pull/466 (which isn't merged yet)
---
If your project is set up for it, you can reply to this email and have
Github user jcesarmobile commented on the issue:
https://github.com/apache/cordova-ios/pull/237
Can you create a new issue for the language thing and link it instead of
CB-9789?
And push only the code related to that.
Are there issues open for the cleanIcons and
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-ios/pull/237
## [Current coverage][cc-pull] is 34.72% (diff: 100%)
> Merging [#237][cc-pull] into [master][cc-base-branch] will decrease
coverage by **17.08%**
```diff
@@