[GitHub] cordova-ios issue #324: CB-12966: (ios) Fix bug by escaping project name in ...
Github user joshdholtz commented on the issue: https://github.com/apache/cordova-ios/pull/324 @shazron Rebased and updated coding styles ð --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios issue #324: CB-12966: (ios) Fix bug by escaping project name in ...
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/324 We had to pull in new code for the new linter using eslint. Consequently, some files have changed. Can you try rebasing, then running `npm run eslint` to make sure it's all kosher --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios issue #324: CB-12966: (ios) Fix bug by escaping project name in ...
Github user joshdholtz commented on the issue: https://github.com/apache/cordova-ios/pull/324 @shazron Rebased from master so that the tests and linter actually run and pass now. Also separated out the escaping of single quotes into its own function for better testing and added a tests for that new function. Lemme know if there is anything I need to change to make these changes fit better with the style of this project ð --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios issue #324: CB-12966: (ios) Fix bug by escaping project name in ...
Github user codecov-io commented on the issue: https://github.com/apache/cordova-ios/pull/324 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/324?src=pr=h1) Report > Merging [#324](https://codecov.io/gh/apache/cordova-ios/pull/324?src=pr=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/26beb94e2d454917db0bb024ab75e8dd9759c028?src=pr=desc) will **increase** coverage by `0.02%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/cordova-ios/pull/324?src=pr=tree) ```diff @@Coverage Diff @@ ## master #324 +/- ## == + Coverage 63.77% 63.79% +0.02% == Files 14 14 Lines1623 1624 +1 Branches 277 277 == + Hits 1035 1036 +1 Misses588 588 ``` | [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/324?src=pr=tree) | Coverage Π| | |---|---|---| | [bin/templates/scripts/cordova/lib/Podfile.js](https://codecov.io/gh/apache/cordova-ios/pull/324?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL1BvZGZpbGUuanM=) | `75.86% <100%> (+0.2%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/324?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Π= absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/324?src=pr=footer). Last update [26beb94...c66b4ba](https://codecov.io/gh/apache/cordova-ios/pull/324?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios issue #324: CB-12966: (ios) Fix bug by escaping project name in ...
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/324 Not passing the linter: ``` bin\templates\scripts\cordova\lib\Podfile.js: line 93, col 51, Mixed double and single quotes. bin\templates\scripts\cordova\lib\Podfile.js: line 93, col 59, Mixed double and single quotes. ``` Basically the style for this repo is strings are single quoted. So you would reverse your escaping in line 93 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios issue #324: CB-12966: (ios) Fix bug by escaping project name in ...
Github user joshdholtz commented on the issue: https://github.com/apache/cordova-ios/pull/324 @renatoalencar I have no idea why the tests are not passing. It seems like other tests aren't passing either. You can use this by doing something like... ``` ionic platform add https://github.com/joshdholtz/cordova-ios.git ``` or ``` cordova platform add https://github.com/joshdholtz/cordova-ios.git ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios issue #324: CB-12966: (ios) Fix bug by escaping project name in ...
Github user renatoalencar commented on the issue: https://github.com/apache/cordova-ios/pull/324 I really need this bug fix, did you understand why this is not passing in tests? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
