[GitHub] cordova-lib issue #523: CB-11346 Remove known platforms checks

2017-03-01 Thread purplecabbage
Github user purplecabbage commented on the issue:

https://github.com/apache/cordova-lib/pull/523
  
Let there be tests!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-lib issue #523: CB-11346 Remove known platforms checks

2017-02-28 Thread codecov-io
Github user codecov-io commented on the issue:

https://github.com/apache/cordova-lib/pull/523
  
# [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/523?src=pr=h1) 
Report
> Merging 
[#523](https://codecov.io/gh/apache/cordova-lib/pull/523?src=pr=desc) into 
[master](https://codecov.io/gh/apache/cordova-lib/commit/b0402b9e51bf2d97488fedd39d13348b29f81c3c?src=pr=desc)
 will **decrease** coverage by `-0.01%`.
> The diff coverage is `95.45%`.


```diff
@@Coverage Diff@@
##   master#523  +/-   ##
=
- Coverage81.9%   81.9%   -0.01% 
=
  Files  68  68  
  Lines55045503   -1 
  Branches 10901088   -2 
=
- Hits 45084507   -1 
  Misses996 996
```


| [Impacted 
Files](https://codecov.io/gh/apache/cordova-lib/pull/523?src=pr=tree) | 
Coverage Δ | |
|---|---|---|
| 
[cordova-lib/src/platforms/PlatformApiPoly.js](https://codecov.io/gh/apache/cordova-lib/compare/b0402b9e51bf2d97488fedd39d13348b29f81c3c...3dad4315bd524497088e91565bd2a7e4e1ee98fc?src=pr=tree#diff-Y29yZG92YS1saWIvc3JjL3BsYXRmb3Jtcy9QbGF0Zm9ybUFwaVBvbHkuanM=)
 | `93.75% <ø> (-0.05%)` | :x: |
| 
[cordova-lib/src/cordova/util.js](https://codecov.io/gh/apache/cordova-lib/compare/b0402b9e51bf2d97488fedd39d13348b29f81c3c...3dad4315bd524497088e91565bd2a7e4e1ee98fc?src=pr=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvdXRpbC5qcw==)
 | `97.28% <100%> (ø)` | :white_check_mark: |
| 
[cordova-lib/src/cordova/platform.js](https://codecov.io/gh/apache/cordova-lib/compare/b0402b9e51bf2d97488fedd39d13348b29f81c3c...3dad4315bd524497088e91565bd2a7e4e1ee98fc?src=pr=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvcGxhdGZvcm0uanM=)
 | `78.25% <100%> (ø)` | :white_check_mark: |
| 
[cordova-lib/src/platforms/platforms.js](https://codecov.io/gh/apache/cordova-lib/compare/b0402b9e51bf2d97488fedd39d13348b29f81c3c...3dad4315bd524497088e91565bd2a7e4e1ee98fc?src=pr=tree#diff-Y29yZG92YS1saWIvc3JjL3BsYXRmb3Jtcy9wbGF0Zm9ybXMuanM=)
 | `96.66% <92.85%> (+0.11%)` | :white_check_mark: |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-lib/pull/523?src=pr=continue).
> **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing 
data`
> Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-lib/pull/523?src=pr=footer). 
Last update 
[b0402b9...21c4565](https://codecov.io/gh/apache/cordova-lib/compare/b0402b9e51bf2d97488fedd39d13348b29f81c3c...21c4565b0760d4103ad707832fd15ab8b837ab1e?src=pr=footer=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org