[GitHub] cordova-lib issue #529: CB-11346 Remove known platforms check
Github user audreyso commented on the issue: https://github.com/apache/cordova-lib/pull/529 Ran npm test and also tested manually with a test project. Was able to add a "non core" platform name, run, and build successfully. No errors to report! :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib issue #529: CB-11346 Remove known platforms check
Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/529 Ready for review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib issue #529: CB-11346 Remove known platforms check
Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/529 Now to add tests! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib issue #529: CB-11346 Remove known platforms check
Github user codecov-io commented on the issue: https://github.com/apache/cordova-lib/pull/529 # [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/529?src=pr=h1) Report > Merging [#529](https://codecov.io/gh/apache/cordova-lib/pull/529?src=pr=desc) into [master](https://codecov.io/gh/apache/cordova-lib/commit/07001dc4e0acf89358c50791589428615198286b?src=pr=desc) will **increase** coverage by `<.01%`. > The diff coverage is `92.68%`. ```diff @@Coverage Diff@@ ## master#529 +/- ## = + Coverage81.9% 81.9% +<.01% = Files 68 68 Lines54985499 +1 Branches 10901086 -4 = + Hits 45034504 +1 Misses995 995 ``` | [Impacted Files](https://codecov.io/gh/apache/cordova-lib/pull/529?src=pr=tree) | Coverage Π| | |---|---|---| | [cordova-lib/src/platforms/PlatformApiPoly.js](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...56d0746e7d26421fc3be3b4c5d6c8254cf801088?src=pr=tree#diff-Y29yZG92YS1saWIvc3JjL3BsYXRmb3Jtcy9QbGF0Zm9ybUFwaVBvbHkuanM=) | `93.75% <ø> (-0.44%)` | :x: | | [cordova-lib/src/plugman/install.js](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...56d0746e7d26421fc3be3b4c5d6c8254cf801088?src=pr=tree#diff-Y29yZG92YS1saWIvc3JjL3BsdWdtYW4vaW5zdGFsbC5qcw==) | `87.07% <ø> (-0.09%)` | :x: | | [cordova-lib/src/cordova/util.js](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...56d0746e7d26421fc3be3b4c5d6c8254cf801088?src=pr=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvdXRpbC5qcw==) | `97.2% <100%> (ø)` | :white_check_mark: | | [cordova-lib/src/cordova/platform.js](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...56d0746e7d26421fc3be3b4c5d6c8254cf801088?src=pr=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvcGxhdGZvcm0uanM=) | `78.42% <88.88%> (+0.17%)` | :white_check_mark: | | [cordova-lib/src/platforms/platforms.js](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...56d0746e7d26421fc3be3b4c5d6c8254cf801088?src=pr=tree#diff-Y29yZG92YS1saWIvc3JjL3BsYXRmb3Jtcy9wbGF0Zm9ybXMuanM=) | `97.14% <94.73%> (+0.59%)` | :white_check_mark: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-lib/pull/529?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Π= absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/529?src=pr=footer). Last update [07001dc...56d0746](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...56d0746e7d26421fc3be3b4c5d6c8254cf801088?el=footer=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib issue #529: CB-11346 Remove known platforms check
Github user codecov-io commented on the issue: https://github.com/apache/cordova-lib/pull/529 # [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/529?src=pr=h1) Report > Merging [#529](https://codecov.io/gh/apache/cordova-lib/pull/529?src=pr=desc) into [master](https://codecov.io/gh/apache/cordova-lib/commit/07001dc4e0acf89358c50791589428615198286b?src=pr=desc) will **increase** coverage by `<.01%`. > The diff coverage is `92.68%`. ```diff @@Coverage Diff@@ ## master#529 +/- ## = + Coverage81.9% 81.9% +<.01% = Files 68 68 Lines54985499 +1 Branches 10901086 -4 = + Hits 45034504 +1 Misses995 995 ``` | [Impacted Files](https://codecov.io/gh/apache/cordova-lib/pull/529?src=pr=tree) | Coverage Π| | |---|---|---| | [cordova-lib/src/plugman/install.js](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...56d0746e7d26421fc3be3b4c5d6c8254cf801088?src=pr=tree#diff-Y29yZG92YS1saWIvc3JjL3BsdWdtYW4vaW5zdGFsbC5qcw==) | `87.07% <ø> (-0.09%)` | :x: | | [cordova-lib/src/platforms/PlatformApiPoly.js](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...56d0746e7d26421fc3be3b4c5d6c8254cf801088?src=pr=tree#diff-Y29yZG92YS1saWIvc3JjL3BsYXRmb3Jtcy9QbGF0Zm9ybUFwaVBvbHkuanM=) | `93.75% <ø> (-0.44%)` | :x: | | [cordova-lib/src/cordova/util.js](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...56d0746e7d26421fc3be3b4c5d6c8254cf801088?src=pr=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvdXRpbC5qcw==) | `97.2% <100%> (ø)` | :white_check_mark: | | [cordova-lib/src/cordova/platform.js](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...56d0746e7d26421fc3be3b4c5d6c8254cf801088?src=pr=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvcGxhdGZvcm0uanM=) | `78.42% <88.88%> (+0.17%)` | :white_check_mark: | | [cordova-lib/src/platforms/platforms.js](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...56d0746e7d26421fc3be3b4c5d6c8254cf801088?src=pr=tree#diff-Y29yZG92YS1saWIvc3JjL3BsYXRmb3Jtcy9wbGF0Zm9ybXMuanM=) | `97.14% <94.73%> (+0.59%)` | :white_check_mark: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-lib/pull/529?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Π= absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/529?src=pr=footer). Last update [07001dc...56d0746](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...56d0746e7d26421fc3be3b4c5d6c8254cf801088?el=footer=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
