Github user asfgit closed the pull request at:
https://github.com/apache/cordova-medic/pull/101
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user omefire commented on the pull request:
https://github.com/apache/cordova-medic/pull/101#issuecomment-215512291
Merging this without the suggested variable name changes, as we'll be
moving away from cordova-medic soon anyway.
---
If your project is set up for it, you can
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-medic/pull/101#issuecomment-215510394
This is a good find. Hopefully, this will fix all our issues with contacts
permissions ð
---
If your project is set up for it, you can reply to this email
Github user omefire commented on the pull request:
https://github.com/apache/cordova-medic/pull/101#issuecomment-215503182
@sarangan12 a quick search through the repo yields only 4 files with less
than 10 instances that would need to be updated.
I think it is worth the effort, :)
Github user sarangan12 commented on the pull request:
https://github.com/apache/cordova-medic/pull/101#issuecomment-215502169
@omefire Agreed. But that would involve additiional code changes which are
not related directly to this issue. You can create a seperate JIRA for it.
Also, I
Github user omefire commented on the pull request:
https://github.com/apache/cordova-medic/pull/101#issuecomment-215501596
Hmm, we've got a case of confusing naming here. I think we should rename
```argv.app``` to ```argv.appName```. That will make the intent clearer and
prevent such
GitHub user sarangan12 opened a pull request:
https://github.com/apache/cordova-medic/pull/101
CB-11168: Fix the appName in cordova-medic
The appName is just set to incorrect value. The appName must be
'org.apache.mobilespec'. But, when it is picked from command line arguments,
