[GitHub] cordova-plugin-device-motion issue #57: CB-13068: Updated README to point to...

2017-09-17 Thread stevengill
Github user stevengill commented on the issue:

https://github.com/apache/cordova-plugin-device-motion/pull/57
  
Merged this in, Added `info` tag. 

@maverickmishra can you close this issue?


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-device-motion issue #57: CB-13068: Updated README to point to...

2017-08-10 Thread filmaj
Github user filmaj commented on the issue:

https://github.com/apache/cordova-plugin-device-motion/pull/57
  
I'd also suggest we add an [`` tag to the 
plugin.xml](https://cordova.apache.org/docs/en/latest/plugin_ref/spec.html#info)
 where we can be more noisy about the deprecation status of the plugin (as it 
will be printed out during plugin install).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-device-motion issue #57: CB-13068: Updated README to point to...

2017-08-10 Thread filmaj
Github user filmaj commented on the issue:

https://github.com/apache/cordova-plugin-device-motion/pull/57
  
Isn't this at odds with @macdonst's PR open in #53 ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-device-motion issue #57: CB-13068: Updated README to point to...

2017-08-10 Thread filmaj
Github user filmaj commented on the issue:

https://github.com/apache/cordova-plugin-device-motion/pull/57
  
Yeah but it's basically the same stuff, no? I think we should combine what 
you two have done. I like that you link to the transition blog post. I like 
that Simon also updated the plugin and package json files. Thoughts @macdonst ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-device-motion issue #57: CB-13068: Updated README to point to...

2017-08-10 Thread maverickmishra
Github user maverickmishra commented on the issue:

https://github.com/apache/cordova-plugin-device-motion/pull/57
  
Yes, but I thought that issue was superseded by CB-13068. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org