[GitHub] cordova-plugin-inappbrowser pull request #172: [CB-5758] (android/iOS) Possi...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/172


---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request #172: [CB-5758] (android/iOS) Possi...

[MLaudren]

GitHub user MLaudren opened a pull request:

https://github.com/apache/cordova-plugin-inappbrowser/pull/172

[CB-5758] (android/iOS) Possibility to disable ssl verification (allow 
selfsigned certificate)

I think it's linked to this issue:
https://issues.apache.org/jira/browse/CB-5758

### Platforms affected
Android
iOS

### What does this PR do?
Add option validatessl to disable, default is enable, the ssl certificate 
validation.
This allow https pages with selfsigned certificate to be opened.

### What testing has been done on this change?
Compilation and run on android / iOS.

### Checklist
- [ ] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and 
submitted to secret...@apache.org.
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MLaudren/cordova-plugin-inappbrowser sslValid

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/172.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #172


commit 65e3a91b7622577c9904dfc091bfc5ceaad9d3f8
Author: Maxime LAUDREN 
Date:   2016-07-05T08:35:44Z

Add ssl validation choice in option.
validatessl=no/yes, default = yes

commit bf85c7db8f3f22f32d847c1dbe82fdc84c79c4ab
Author: MLaudren 
Date:   2016-07-05T08:44:46Z

Update README.md

Add new option description in readme




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org