[GitHub] cordova-plugin-splashscreen pull request #114: CB-11829: (iOS) Support for C...

[kerrishotts]

Github user kerrishotts commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-splashscreen/pull/114#discussion_r81187425
  
--- Diff: README.md ---
@@ -51,6 +51,206 @@ Report issues with this plugin on the [Apache Cordova 
issue tracker][Apache Cord
 
 __Note__: Extended splashscreen does not require the plugin on Windows (as 
opposed to Android and iOS) in case you don't use the plugin API, i.e. 
programmatic hide/show.
 
+### iOS-specific information
+
+There are two mechanisms for displaying a launch screen on iOS:
+
+1. Legacy launch images: images are sized exactly for the device's screen 
size. Does not support the iPad Pro 12.9's native resolution or 
split-screen/slide-over multitasking.
+
+2. Launch storyboard images: Images are sized based on scale, idiom, and 
size classes. Supports all devices, and can be used with 
split-screen/slide-over multitasking.
+
+Apple is moving away from legacy launch images. There is no official 
support for providing a native-resolution launch image for the iPad pro 12.9 or 
for providing launch images that work with split-screen multitasking or 
slide-over. If your app doesn't need to support these contexts, then you can 
continue to use legacy launch images for as long as you like. 
--- End diff --

fixed; thanks for catching it! :-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request #114: CB-11829: (iOS) Support for C...

[kerrishotts]

Github user kerrishotts commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-splashscreen/pull/114#discussion_r81187431
  
--- Diff: README.md ---
@@ -51,6 +51,206 @@ Report issues with this plugin on the [Apache Cordova 
issue tracker][Apache Cord
 
 __Note__: Extended splashscreen does not require the plugin on Windows (as 
opposed to Android and iOS) in case you don't use the plugin API, i.e. 
programmatic hide/show.
 
+### iOS-specific information
+
+There are two mechanisms for displaying a launch screen on iOS:
+
+1. Legacy launch images: images are sized exactly for the device's screen 
size. Does not support the iPad Pro 12.9's native resolution or 
split-screen/slide-over multitasking.
+
+2. Launch storyboard images: Images are sized based on scale, idiom, and 
size classes. Supports all devices, and can be used with 
split-screen/slide-over multitasking.
+
+Apple is moving away from legacy launch images. There is no official 
support for providing a native-resolution launch image for the iPad pro 12.9 or 
for providing launch images that work with split-screen multitasking or 
slide-over. If your app doesn't need to support these contexts, then you can 
continue to use legacy launch images for as long as you like. 
+
+The preferred method of providing launch images is to use a launch 
storyboard. For native app developers, the ideal launch storyboard is an 
unpopulated version of the app's user interface at launch. For non-native app 
developers who don't wish to learn interface builder, however, this plugin 
simulates the legacy launch image method as much as is feasible.
--- End diff --

fixed; thanks for catching it! :-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request #114: CB-11829: (iOS) Support for C...

[shazron]

Github user shazron commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-splashscreen/pull/114#discussion_r81026437
  
--- Diff: README.md ---
@@ -51,6 +51,206 @@ Report issues with this plugin on the [Apache Cordova 
issue tracker][Apache Cord
 
 __Note__: Extended splashscreen does not require the plugin on Windows (as 
opposed to Android and iOS) in case you don't use the plugin API, i.e. 
programmatic hide/show.
 
+### iOS-specific information
+
+There are two mechanisms for displaying a launch screen on iOS:
+
+1. Legacy launch images: images are sized exactly for the device's screen 
size. Does not support the iPad Pro 12.9's native resolution or 
split-screen/slide-over multitasking.
+
+2. Launch storyboard images: Images are sized based on scale, idiom, and 
size classes. Supports all devices, and can be used with 
split-screen/slide-over multitasking.
+
+Apple is moving away from legacy launch images. There is no official 
support for providing a native-resolution launch image for the iPad pro 12.9 or 
for providing launch images that work with split-screen multitasking or 
slide-over. If your app doesn't need to support these contexts, then you can 
continue to use legacy launch images for as long as you like. 
+
+The preferred method of providing launch images is to use a launch 
storyboard. For native app developers, the ideal launch storyboard is an 
unpopulated version of the app's user interface at launch. For non-native app 
developers who don't wish to learn interface builder, however, this plugin 
simulates the legacy launch image method as much as is feasible.
--- End diff --

Interface Builder (camel case)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request #114: CB-11829: (iOS) Support for C...

[shazron]

Github user shazron commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-splashscreen/pull/114#discussion_r81026399
  
--- Diff: README.md ---
@@ -51,6 +51,206 @@ Report issues with this plugin on the [Apache Cordova 
issue tracker][Apache Cord
 
 __Note__: Extended splashscreen does not require the plugin on Windows (as 
opposed to Android and iOS) in case you don't use the plugin API, i.e. 
programmatic hide/show.
 
+### iOS-specific information
+
+There are two mechanisms for displaying a launch screen on iOS:
+
+1. Legacy launch images: images are sized exactly for the device's screen 
size. Does not support the iPad Pro 12.9's native resolution or 
split-screen/slide-over multitasking.
+
+2. Launch storyboard images: Images are sized based on scale, idiom, and 
size classes. Supports all devices, and can be used with 
split-screen/slide-over multitasking.
+
+Apple is moving away from legacy launch images. There is no official 
support for providing a native-resolution launch image for the iPad pro 12.9 or 
for providing launch images that work with split-screen multitasking or 
slide-over. If your app doesn't need to support these contexts, then you can 
continue to use legacy launch images for as long as you like. 
--- End diff --

iPad Pro (camel case)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request #114: CB-11829: (iOS) Support for C...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-splashscreen/pull/114


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request #114: CB-11829: (iOS) Support for C...

[kerrishotts]

GitHub user kerrishotts opened a pull request:

https://github.com/apache/cordova-plugin-splashscreen/pull/114

CB-11829: (iOS) Support for CB-9762; docs (CB-11830)



### Platforms affected

* iOS

### What does this PR do?

Supports launch storyboards as describe in CB-9762. Add documentation for 
the feature (no other great place to put it)

### What testing has been done on this change?

* Manual testing on devices

### Checklist
- [X] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and 
submitted to secret...@apache.org.
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [X] Added automated test coverage as appropriate for this change.
- No automated testing added; appearance has to be verified manually.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kerrishotts/cordova-plugin-splashscreen 
CB-11829

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-splashscreen/pull/114.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #114


commit f8895acb741b201a9e1110ead875988b23b95a4c
Author: Kerri Shotts 
Date:   2016-09-22T20:17:33Z

CB-11829: (iOS) Support for CB-9762; docs (CB-11830)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org