[GitHub] cordova-plugin-wkwebview-engine pull request: Fixes CB-11074: WKWe...

2016-05-02 Thread kenichi-fukushima
Github user kenichi-fukushima commented on the pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/7#issuecomment-216118441 A drive-by comment: In our app, we ended up subclassing CDVWKWebViewEngine and creating another instance of WKWebView in

[GitHub] cordova-plugin-wkwebview-engine pull request: Fixes CB-11074: WKWe...

2016-04-28 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/7#issuecomment-215584737 @ephemer not just settings (which as you said will probably not a frequent scenario), but setting the other delegates. updateWithInfo will be

[GitHub] cordova-plugin-wkwebview-engine pull request: Fixes CB-11074: WKWe...

2016-04-28 Thread ephemer
Github user ephemer commented on the pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/7#issuecomment-215453411 As I commented in the base repo, this PR doesn't do what it says it does yet. @shazron is it normal to change the settings after the

[GitHub] cordova-plugin-wkwebview-engine pull request: Fixes CB-11074: WKWe...

2016-04-18 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/7#issuecomment-211493781 It still needs to be able to update it dynamically. I would refactor it to not remove the existing code, but create a new `-

[GitHub] cordova-plugin-wkwebview-engine pull request: Fixes CB-11074: WKWe...

2016-04-13 Thread akofman
GitHub user akofman opened a pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/7 Fixes CB-11074: WKWebView configuration is not considered I updated the configuration before the WKWebView initialisation in order to consider it. It implies that the