[GitHub] cordova-windows issue #207: CB-12142: Move windows-specific logic from cordo...

2016-11-17 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the issue:

https://github.com/apache/cordova-windows/pull/207
  
Looks good. Let's wait for tomorrow and merge it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-windows issue #207: CB-12142: Move windows-specific logic from cordo...

2016-11-14 Thread matrosov-nikita
Github user matrosov-nikita commented on the issue:

https://github.com/apache/cordova-windows/pull/207
  
@vladimir-kotikov @daserge, I've created a Jira issue: 
https://issues.apache.org/jira/browse/CB-12142, fixed all your comments. Also I 
think it would be better to add prefix to commit after squashing. Pls, review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org