[GitHub] cordova-windows issue #212: CB-9287 Not enough Icons and Splashscreens for W...
Github user frederikbosch commented on the issue: https://github.com/apache/cordova-windows/pull/212 Any chance that a version with this included will be released any time soon? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows issue #212: CB-9287 Not enough Icons and Splashscreens for W...
Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-windows/pull/212 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows issue #212: CB-9287 Not enough Icons and Splashscreens for W...
Github user daserge commented on the issue: https://github.com/apache/cordova-windows/pull/212 @vladimir-kotikov addressed, thanks! It is good to go? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows issue #212: CB-9287 Not enough Icons and Splashscreens for W...
Github user daserge commented on the issue: https://github.com/apache/cordova-windows/pull/212 @vladimir-kotikov could you please take a look again? I've also added a fix for [CB-12192 - No SplashScreen on Windows when content.src is subpage](https://issues.apache.org/jira/browse/CB-12192) - the issue occured while testing splashscreen API. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows issue #212: CB-9287 Not enough Icons and Splashscreens for W...
Github user daserge commented on the issue: https://github.com/apache/cordova-windows/pull/212 @vladimir-kotikov thank you for the review! I've addressed the notes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows issue #212: CB-9287 Not enough Icons and Splashscreens for W...
Github user codecov-io commented on the issue: https://github.com/apache/cordova-windows/pull/212 ## [Current coverage](https://codecov.io/gh/apache/cordova-windows/pull/212?src=pr) is 76.04% (diff: 95.69%) > Merging [#212](https://codecov.io/gh/apache/cordova-windows/pull/212?src=pr) into [master](https://codecov.io/gh/apache/cordova-windows/branch/master?src=pr) will increase coverage by **0.76%** ```diff @@ master #212 diff @@ == Files16 16 Lines 2120 2200+80 Methods 401415+14 Messages 0 0 Branches410430+20 == + Hits 1596 1673+77 - Misses 524527 +3 Partials 0 0 ``` > Powered by [Codecov](https://codecov.io?src=pr). Last update [09d582c...bd0096b](https://codecov.io/gh/apache/cordova-windows/compare/09d582c8705625bbdcd8fb97c30c02eea04d14b0...bd0096b71a3d6d65169d7d4582e50a05dc48ecb0?src=pr) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
