[GitHub] cordova-windows issue #219: Add support for WinMD and DLL combination

2016-12-21 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the issue:

https://github.com/apache/cordova-windows/pull/219
  
Documentation update: https://github.com/apache/cordova-docs/pull/671
Change to support `implementation` attribute in `cordova-common`: 
https://github.com/apache/cordova-lib/pull/513

Note - this PR has own override for `PluginInfo.getFrameworks` method to 
not depend on not-yet-released apache/cordova-lib#513 - this logic can be 
safely removed once updated `cordova-common` released


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-windows issue #219: Add support for WinMD and DLL combination

2016-12-21 Thread codecov-io
Github user codecov-io commented on the issue:

https://github.com/apache/cordova-windows/pull/219
  
## [Current 
coverage](https://codecov.io/gh/apache/cordova-windows/pull/219?src=pr) is 
77.00% (diff: 100%)
> Merging 
[#219](https://codecov.io/gh/apache/cordova-windows/pull/219?src=pr) into 
[master](https://codecov.io/gh/apache/cordova-windows/branch/master?src=pr) 
will increase coverage by **0.77%**

```diff
@@ master   #219   diff @@
==
  Files16 16  
  Lines  2204   +18   
  Methods 412415 +3   
  Messages  0  0  
  Branches433438 +5   
==
+ Hits   1680   1711+31   
+ Misses  524511-13   
  Partials  0  0  
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update 
[1cf27a9...99a7016](https://codecov.io/gh/apache/cordova-windows/compare/1cf27a9db5fa103228b803539ce5ede52e524aee...99a70164a3698b3d36a1ee958f5753df45b8983d?src=pr)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org