[GitHub] cordova-windows pull request #216: CB-11177 SplashScreen gets shifted on Win...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-windows/pull/216


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request #216: CB-11177 SplashScreen gets shifted on Win...

[vladimir-kotikov]

Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/216#discussion_r92601539
  
--- Diff: cordova-js-src/splashscreen.js ---
@@ -30,7 +30,8 @@ var schema = (isHosted || isWin10UWP && isMsAppxWeb) ? 
'ms-appx-web' : 'ms-appx'
 var fileName = isPhone ? 'splashscreenphone.png' : 'splashscreen.png';
 var splashImageSrc = schema + ':///images/' + fileName;
 
-var splashElement = null, extendedSplashImage = null, 
extendedSplashProgress = null;
+var splashElement = null, extendedSplashImage = null, 
extendedSplashProgress = null,
--- End diff --

nit: please put each definition on its own line - IMO it's be much easier 
to read


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request #216: CB-11177 SplashScreen gets shifted on Win...

[vladimir-kotikov]

Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/216#discussion_r92603101
  
--- Diff: cordova-js-src/splashscreen.js ---
@@ -148,29 +152,27 @@ function init(config, manifest) {
 extendedSplashProgress.classList.add('win-medium');
 extendedSplashProgress.classList.add('win-ring');
 
+extendedSplashImage.style.maxWidth = "100%";
+extendedSplashImage.style.maxHeight = "100%";
+extendedSplashImage.src = splashImageSrc;
+
 if (isWp81 || isWp10) {
-extendedSplashImage.style.maxWidth = "100%";
-extendedSplashImage.style.maxHeight = "100%";
-extendedSplashImage.src = splashImageSrc;
 // center horizontally
 extendedSplashImage.style.margin = "0 auto";
-extendedSplashImage.style.display = "block";
+extendedSplashImage.style.display = "inline-block";
--- End diff --

Can we move this to CSS using the same technique as for 
`extendedSplashProgress` (additional css classes based on whether we're running 
on desktop/phone)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request #216: CB-11177 SplashScreen gets shifted on Win...

[vladimir-kotikov]

Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/216#discussion_r92602532
  
--- Diff: cordova-js-src/splashscreen.js ---
@@ -148,29 +152,27 @@ function init(config, manifest) {
 extendedSplashProgress.classList.add('win-medium');
 extendedSplashProgress.classList.add('win-ring');
 
+extendedSplashImage.style.maxWidth = "100%";
--- End diff --

Could you please explain, what's the point in having `maxWidth` and 
`maxHeight`  defined twice - here and in css file?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request #216: CB-11177 SplashScreen gets shifted on Win...

[vladimir-kotikov]

Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/216#discussion_r92601889
  
--- Diff: cordova-js-src/splashscreen.js ---
@@ -148,29 +152,27 @@ function init(config, manifest) {
 extendedSplashProgress.classList.add('win-medium');
 extendedSplashProgress.classList.add('win-ring');
 
+extendedSplashImage.style.maxWidth = "100%";
+extendedSplashImage.style.maxHeight = "100%";
+extendedSplashImage.src = splashImageSrc;
+
 if (isWp81 || isWp10) {
--- End diff --

nit: Maybe change this condition to `if (isPhoneDevice) {...` where 
`isPhoneDevice = isWp81 || isWp10` - just to improve readability


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request #216: CB-11177 SplashScreen gets shifted on Win...

[daserge]

GitHub user daserge opened a pull request:

https://github.com/apache/cordova-windows/pull/216

CB-11177 SplashScreen gets shifted on Windows devices with soft navbar



### Platforms affected
Windows

### What does this PR do?
Fixes splash jump bug (affected mostly Windows 10 Mobile devices, 
especially with soft navigation bar)

### What testing has been done on this change?
Manual testing

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/daserge/cordova-windows CB-11177

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-windows/pull/216.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #216


commit 94b0c271fef8217c413c35ee401594f5f986b351
Author: daserge 
Date:   2016-12-12T18:32:37Z

CB-11177 SplashScreen gets shifted on Windows devices with soft navbar




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org