[GitHub] cordova-windows pull request #237: Cb 12636 Fix check_reqs to properly find ...

2017-07-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/237 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-windows pull request #237: Cb 12636 Fix check_reqs to properly find ...

2017-07-16 Thread alsorokin
Github user alsorokin commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/237#discussion_r127631518 --- Diff: template/cordova/lib/MSBuildTools.js --- @@ -171,6 +182,54 @@ function getAvailableUAPVersions() { }); return

[GitHub] cordova-windows pull request #237: Cb 12636 Fix check_reqs to properly find ...

2017-07-14 Thread matrosov-nikita
Github user matrosov-nikita commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/237#discussion_r127480714 --- Diff: template/cordova/lib/MSBuildTools.js --- @@ -171,6 +182,54 @@ function getAvailableUAPVersions() { });

[GitHub] cordova-windows pull request #237: Cb 12636 Fix check_reqs to properly find ...

2017-07-14 Thread matrosov-nikita
Github user matrosov-nikita commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/237#discussion_r127481484 --- Diff: template/cordova/lib/MSBuildTools.js --- @@ -171,6 +182,54 @@ function getAvailableUAPVersions() { });

[GitHub] cordova-windows pull request #237: Cb 12636 Fix check_reqs to properly find ...

2017-07-14 Thread matrosov-nikita
Github user matrosov-nikita commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/237#discussion_r127480919 --- Diff: template/cordova/lib/MSBuildTools.js --- @@ -171,6 +182,54 @@ function getAvailableUAPVersions() { });

[GitHub] cordova-windows pull request #237: Cb 12636 Fix check_reqs to properly find ...

2017-07-14 Thread matrosov-nikita
Github user matrosov-nikita commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/237#discussion_r127480213 --- Diff: template/cordova/lib/MSBuildTools.js --- @@ -171,6 +182,54 @@ function getAvailableUAPVersions() { });

[GitHub] cordova-windows pull request #237: Cb 12636 Fix check_reqs to properly find ...

2017-07-14 Thread matrosov-nikita
Github user matrosov-nikita commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/237#discussion_r127481238 --- Diff: template/cordova/lib/MSBuildTools.js --- @@ -171,6 +182,54 @@ function getAvailableUAPVersions() { });

[GitHub] cordova-windows pull request #237: Cb 12636 Fix check_reqs to properly find ...

2017-07-14 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-windows/pull/237 Cb 12636 Fix check_reqs to properly find VS 2017 ### Platforms affected this one! ### What does this PR do? Teaches `cordova-windows` to properly recognize VS 2017