Re: [proposal] Update Handler Conflict Resolution

2011-09-11 Thread Pepijn de Vos
Yes, I would imagine the update function tries to commit the result. Maybe update could itself return the new document? I think rnewson or jan said there was already some sort of timeout in place. Pepijn On Sep 11, 2011, at 4:54 AM, Randall Leeds wrote: On Fri, Sep 9, 2011 at 06:37,

Request to correct a comment typo

2011-09-11 Thread Jason Smith
I believe there is a typo in a comment which makes it difficult to grep for _update handler code. My usual searches for '_update' or '\b_update' did not match in src/couchdb because of this typo (and because this string is found in the .ini file templates). Would a committer mind reviewing this

Re: [proposal] Update Handler Conflict Resolution

2011-09-11 Thread Jason Smith
Hi, Randall. May I refer to the update() function as store() to avoid overloading the word update? var store = update; // Hopefully this clarifies the email. Also, I use ?retry=true instead of ?indempotent=true because we are talking about either 0 or 1 total document updates. _update runs

Re: Request to correct a comment typo

2011-09-11 Thread Filipe David Manana
Done. Thanks Jason. On Sun, Sep 11, 2011 at 11:50 AM, Jason Smith j...@iriscouch.com wrote: I believe there is a typo in a comment which makes it difficult to grep for _update handler code. My usual searches for '_update' or '\b_update' did not match in src/couchdb because of this typo (and

Re: [proposal] Update Handler Conflict Resolution

2011-09-11 Thread Alexander Shorin
Hi! Sorry for stupid question, but is there any reasons why _update handlers should have custom conflict resolution logic while simple document store API not? I think that better to implement some update_conflict() functions which acts like validate_doc_update one - globally for all database, one

Re: svn commit: r1168196 - in /couchdb/trunk: share/www/script/test/attachment_ranges.js src/couchdb/couch_httpd_db.erl

2011-09-11 Thread Paul Davis
or that contains more than 10 byte ranges That's an odd number. Is it specified in 2616 or something? On Sun, Sep 11, 2011 at 10:50 AM, rnew...@apache.org wrote: Author: rnewson Date: Sun Sep 11 10:50:11 2011 New Revision: 1168196 URL: http://svn.apache.org/viewvc?rev=1168196view=rev Log:

Re: svn commit: r1168196 - in /couchdb/trunk: share/www/script/test/attachment_ranges.js src/couchdb/couch_httpd_db.erl

2011-09-11 Thread Robert Newson
10 is an even number. B. On 11 September 2011 22:22, Paul Davis paul.joseph.da...@gmail.com wrote: or that contains more than 10 byte ranges That's an odd number. Is it specified in 2616 or something? On Sun, Sep 11, 2011 at 10:50 AM,  rnew...@apache.org wrote: Author: rnewson Date: Sun