GitHub user garrensmith opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/342
Loading component
At a small loading component that gets displayed when data is being
fetched.
The loading design can be improved but most importantly this is to showcase
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/330#issuecomment-87662857
@benkeen could you rebase and if tests pass, could you merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/336#issuecomment-87662698
All tests passing +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/325#issuecomment-87662977
@robertkowalski could you close this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user garrensmith opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/344
Fix tests that don't have a spinner
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/garrensmith/couchdb-fauxton fix-all-docs-tests
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/322#issuecomment-87642092
+1 this is very cool
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/338#issuecomment-87642306
+1 thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/342#issuecomment-87643395
Merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user garrensmith closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/342
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user garrensmith closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/344
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/339#issuecomment-87715444
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/335#issuecomment-86407901
Tests passed
[here](https://travis-ci.org/garrensmith/couchdb-fauxton/builds/55917893)
---
If your project is set up for it, you can reply to this email
Github user garrensmith closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/335
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/335#issuecomment-86408035
merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/324#issuecomment-86445353
Yes! Finally. All tests passing
[here](https://travis-ci.org/garrensmith/couchdb-fauxton/builds/55928223)
---
If your project is set up for it, you can
GitHub user garrensmith opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/335
Fix cause of failing tests
I accidentally introduced failing tests due to the broken view I added.
This should fix it.
You can merge this pull request into a Git repository by running
Github user garrensmith closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/334
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/334#issuecomment-86371269
Merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/334#issuecomment-86048698
Here is the actual fix
https://github.com/apache/couchdb-fauxton/pull/334/files#diff-308dc0fc971fc5a587b9f81bb7a94d1eR369
The rest is linter stuff
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/333#issuecomment-86077485
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/334#issuecomment-86070514
@robertkowalski and @kxepal I've clean up this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user garrensmith opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/334
Display view error if view is broken
If a user saves a view that doesn't work the error will be displayed on
to the user and the page will load.
This fixes COUCHDB-2646
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/326#issuecomment-84874437
+1 this is great. Could you also create a jshintrc file and we can move all
our jshint settings out of the grunt file.
I agree with @kxepal
GitHub user garrensmith opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/324
React docs list
This is the document list for views, _all_docs redone in React.js
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/324#discussion_r26831001
--- Diff: app/addons/documents/header/header.actiontypes.js ---
@@ -14,9 +14,11 @@ define([], function () {
return
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/316#issuecomment-82883621
+1. Sorry for taking so long.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/313#discussion_r26660463
--- Diff: app/addons/components/react-components.react.jsx ---
@@ -188,7 +188,20 @@ function (app, FauxtonAPI, React, Components,
beautifyHelper
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/320#issuecomment-83016275
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/313#issuecomment-83019522
Thanks for the explanation. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/318#issuecomment-82200111
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/319#issuecomment-82242635
@michellephung looks good. We just need a passing test.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/320#issuecomment-82330572
That looks better, this test will fail if you run it on its own. You need
to include `'addons/documents/base'` in the require list.
---
If your project
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/317#discussion_r26471215
--- Diff: app/addons/activetasks/components.react.jsx ---
@@ -0,0 +1,387 @@
+// Licensed under the Apache License, Version 2.0 (the License
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/317#discussion_r26471457
--- Diff: app/addons/activetasks/components.react.jsx ---
@@ -0,0 +1,387 @@
+// Licensed under the Apache License, Version 2.0 (the License
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/318#discussion_r26471014
--- Diff: Gruntfile.js ---
@@ -407,7 +407,7 @@ module.exports = function(grunt) {
shell: {
'build-jsx
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/318#discussion_r26470977
--- Diff: Gruntfile.js ---
@@ -407,7 +407,7 @@ module.exports = function(grunt) {
shell: {
'build-jsx
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/317#discussion_r26471136
--- Diff: app/addons/activetasks/components.react.jsx ---
@@ -0,0 +1,387 @@
+// Licensed under the Apache License, Version 2.0 (the License
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/317#discussion_r26471806
--- Diff: app/addons/activetasks/components.react.jsx ---
@@ -0,0 +1,387 @@
+// Licensed under the Apache License, Version 2.0 (the License
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/317#discussion_r26471294
--- Diff: app/addons/activetasks/components.react.jsx ---
@@ -0,0 +1,387 @@
+// Licensed under the Apache License, Version 2.0 (the License
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/317#discussion_r26471989
--- Diff: app/addons/activetasks/components.react.jsx ---
@@ -0,0 +1,387 @@
+// Licensed under the Apache License, Version 2.0 (the License
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/318#issuecomment-81642336
@kxepal the `rm -rf` command is not needed. If we remove that then Fauxton
will run on Windows with no special requirements.
---
If your project is set up
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/317#discussion_r26471614
--- Diff: app/addons/activetasks/components.react.jsx ---
@@ -0,0 +1,387 @@
+// Licensed under the Apache License, Version 2.0 (the License
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/316#issuecomment-81904801
I will quickly test it tomorrow and let you know.
All misspelling thanks to my iPhone
On 16 Mar 2015, at 8:11 PM, Alexander Shorin
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/314#issuecomment-78006843
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/312#discussion_r26023777
--- Diff: app/addons/databases/resources.js ---
@@ -137,6 +137,8 @@ function(app, FauxtonAPI, Documents) {
var updateSeq = this.get
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/309#issuecomment-77825997
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/312#issuecomment-77825955
This needs a test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/312#discussion_r26023750
--- Diff: app/addons/databases/resources.js ---
@@ -137,6 +137,8 @@ function(app, FauxtonAPI, Documents) {
var updateSeq = this.get
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/307#issuecomment-77826104
+1. Since you are now a committer I will let you merge this in yourself
:smile:
---
If your project is set up for it, you can reply to this email and have
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/304#issuecomment-77826241
merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/301#issuecomment-77327659
Merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user garrensmith closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/301
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/306#issuecomment-77327829
This is awesome. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/296#issuecomment-77337873
+1. Those are great tests @michellephung. Nice work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/303#discussion_r25778260
--- Diff: app/addons/documents/changes/components.react.jsx ---
@@ -268,18 +271,169 @@ define([
});
+ var
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/305#issuecomment-77193619
+1 once the tests pass.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/303#discussion_r25778926
--- Diff: app/addons/documents/tests/views-changesSpec.js ---
@@ -18,70 +18,30 @@ define([
ViewSandbox = testUtils.ViewSandbox
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/303#discussion_r25778180
--- Diff: app/addons/documents/changes/components.react.jsx ---
@@ -11,34 +11,39 @@
// the License.
define([
+ 'app
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/303#discussion_r25778845
--- Diff: app/addons/documents/tests/changes.componentsSpec.react.jsx ---
@@ -179,7 +188,185 @@ define([
assert.equal(1
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/303#discussion_r25778339
--- Diff: app/addons/documents/changes/components.react.jsx ---
@@ -268,18 +271,169 @@ define([
});
+ var
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/304#issuecomment-77170550
+1 if the tests pass
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/301#issuecomment-77155565
@benkeen thanks for reviewing. After a bit of digging around I found that
actually isn't a bug. If you set the per page to 20 docs per page. Then edit a
doc
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/303#issuecomment-77167523
@benkeen this is excellent. I also like the idea of grouping this into one
React component. If its not too much extra work could you convert it to do
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/303#discussion_r25777625
--- Diff: app/addons/documents/views-changes.js ---
@@ -18,108 +18,51 @@ define([
// Libs
addons/fauxton/components
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/300#issuecomment-77174678
+1 looks great
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/301#issuecomment-76960458
This fixes COUCHDB-2193
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/302#issuecomment-76975603
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user garrensmith opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/301
React docs pagination
This is the pagination converted to Flux and React
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/285#issuecomment-76949505
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/300#issuecomment-76949589
The next step is to remove the backbone view for ace editor and do it
completely in React.
---
If your project is set up for it, you can reply
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/296#issuecomment-76950371
This looks great. But it needs a test. Could you move your code into its
own method. Then write a few mocha tests to prove it gives the correct values
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/300#issuecomment-76948642
This looks good. But it breaks when I try and create a new view. Also the
tests are failing.
---
If your project is set up for it, you can reply
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/290#issuecomment-76948812
+1. I'm ok with this being merged in. I think the test failure is unrelated
and this is useful.
---
If your project is set up for it, you can reply
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/295#issuecomment-76722083
+1 this is awesome. We could also add the general components to something
like `Fauxton.components.StyledSelect` so we can use them anywhere.
---
If your
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/289#issuecomment-75766064
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/282#issuecomment-75525231
This can be closed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user garrensmith closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/275
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/279#issuecomment-75530600
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/275#issuecomment-75551421
Merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/265#issuecomment-7100
+1. This is great work @benkeen. Merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/277#issuecomment-7155
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/279#issuecomment-75505808
This fix needs to be applied to get the tests working
```diff
diff --git a/app/addons/documents/tests/nightwatch/bulkDelete.js
b/app/addons
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/261#issuecomment-75045866
Thanks for this @Poltergeist this is great. I've merged it in.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/265#discussion_r24885676
--- Diff: app/addons/documents/tests/changes.componentsSpec.react.jsx ---
@@ -0,0 +1,215 @@
+// Licensed under the Apache License, Version
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/265#discussion_r24885710
--- Diff: app/addons/documents/tests/changes.componentsSpec.react.jsx ---
@@ -0,0 +1,215 @@
+// Licensed under the Apache License, Version
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/265#discussion_r24885896
--- Diff: app/addons/documents/changes/components.react.jsx ---
@@ -0,0 +1,244 @@
+// Licensed under the Apache License, Version 2.0
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/265#discussion_r24885981
--- Diff: app/addons/documents/changes/components.react.jsx ---
@@ -0,0 +1,244 @@
+// Licensed under the Apache License, Version 2.0
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/265#discussion_r24886051
--- Diff: app/addons/documents/changes/components.react.jsx ---
@@ -0,0 +1,244 @@
+// Licensed under the Apache License, Version 2.0
GitHub user garrensmith opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/275
Reactify AllDocNumbers
Convert AllDocNumbers to the react flow
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/garrensmith/couchdb
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/268#issuecomment-74833001
@robertkowalski this is looking good. Just one bug. If I edit a map
function, then save. Then click the '' to go back to the all docs page I get
the confirm
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/265#issuecomment-74832238
@benkeen this is looking better. Two components just need to be more self
contained. I also picked up some bugs while testing.
* Once I add
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/275#issuecomment-74903890
@benkeen thanks for the feedback I'm made the fixes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/270#issuecomment-74854854
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/268#issuecomment-74864461
+1 once travis is green. Nice work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/274#issuecomment-74854682
@benkeen can you add a test. All fixes must include a test.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/268#discussion_r24805595
--- Diff: app/addons/documents/index-editor/components.react.jsx ---
@@ -24,19 +24,21 @@ function(app, FauxtonAPI, React, Stores, Actions
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/268#issuecomment-74644869
Small issue. A view with `_sum` as the reduce still shows the custom reduce:
