[GitHub] couchdb-couch-log-lager pull request: Get lager event handlers fro...

2016-03-20 Thread jaydoane
Github user jaydoane commented on a diff in the pull request: https://github.com/apache/couchdb-couch-log-lager/pull/2#discussion_r56443141 --- Diff: src/couch_log_lager.erl --- @@ -64,10 +64,9 @@ emergency(Fmt, Args) -> -spec set_level(atom()) -> ok.

[GitHub] couchdb-couch-log-lager pull request: Get lager event handlers fro...

2016-03-19 Thread jaydoane
Github user jaydoane commented on the pull request: https://github.com/apache/couchdb-couch-log-lager/pull/2#issuecomment-197741520 Commit message now wrapped --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] couchdb-couch-log-lager pull request: Get lager event handlers fro...

2016-03-19 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-couch-log-lager/pull/2#issuecomment-197727400 One moment: commit message should be wrapped by 79/80 characters per line. And then +1 (: Thanks! --- If your project is set up for it, you can

[GitHub] couchdb-couch-log-lager pull request: Get lager event handlers fro...

2016-03-19 Thread eiri
Github user eiri commented on a diff in the pull request: https://github.com/apache/couchdb-couch-log-lager/pull/2#discussion_r56441052 --- Diff: src/couch_log_lager.erl --- @@ -64,10 +64,9 @@ emergency(Fmt, Args) -> -spec set_level(atom()) -> ok. set_level(Level)

[GitHub] couchdb-couch-log-lager pull request: Get lager event handlers fro...

2016-03-19 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-couch-log-lager/pull/2#issuecomment-197785419 Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] couchdb-couch-log-lager pull request: Get lager event handlers fro...

2016-03-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/couchdb-couch-log-lager/pull/2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] couchdb-couch-log-lager pull request: Get lager event handlers fro...

2016-03-19 Thread eiri
Github user eiri commented on the pull request: https://github.com/apache/couchdb-couch-log-lager/pull/2#issuecomment-197638745 lgtm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] couchdb-couch-log-lager pull request: Get lager event handlers fro...

2016-03-18 Thread jaydoane
GitHub user jaydoane opened a pull request: https://github.com/apache/couchdb-couch-log-lager/pull/2 Get lager event handlers from gen_event The existing mechanism for getting lager_event's handlers incorrectly uses the data structure returned by application:get_env, which returns