[GitHub] couchdb-fauxton pull request: Option to show only editor in CodeEd...

2015-05-25 Thread garrensmith
Github user garrensmith commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/432#issuecomment-105182709 @benkeen a quick unit test for this would be great. Once you have a test +1 --- If your project is set up for it, you can reply to this email and have your

[GitHub] couchdb-fauxton pull request: Option to show only editor in CodeEd...

2015-05-25 Thread benkeen
Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/432#issuecomment-105249664 No problem, added. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] couchdb-fauxton pull request: Option to show only editor in CodeEd...

2015-05-25 Thread garrensmith
Github user garrensmith commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/432#issuecomment-105250009 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] couchdb-fauxton pull request: Option to show only editor in CodeEd...

2015-05-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/432 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] couchdb-fauxton pull request: Option to show only editor in CodeEd...

2015-05-22 Thread robertkowalski
Github user robertkowalski commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/432#issuecomment-104783084 unit-test missing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] couchdb-fauxton pull request: Option to show only editor in CodeEd...

2015-05-22 Thread benkeen
GitHub user benkeen opened a pull request: https://github.com/apache/couchdb-fauxton/pull/432 Option to show only editor in CodeEditor component This adds a `showEditorOnly` option to the CodeEditor / component. It prevents the extra title, beautify markup and wrapper div being

[GitHub] couchdb-fauxton pull request: Option to show only editor in CodeEd...

2015-05-22 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/432#issuecomment-104786104 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] couchdb-fauxton pull request: Option to show only editor in CodeEd...

2015-05-22 Thread benkeen
Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/432#issuecomment-104784391 Yeah I know, but sometimes things are sooo small I must question the need for the unit test. :( --- If your project is set up for it, you can reply to

[GitHub] couchdb-fauxton pull request: Option to show only editor in CodeEd...

2015-05-22 Thread benkeen
Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/432#issuecomment-104785407 @robertkowalski, why do I expect your response to be: I find your lack of faith disturbing.? --- If your project is set up for it, you can reply to this email