[GitHub] couchdb pull request: 1870 add language option to mapreduce editor

2014-05-12 Thread BigBlueHat
Github user BigBlueHat closed the pull request at: https://github.com/apache/couchdb/pull/137 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] couchdb pull request: 1870 add language option to mapreduce editor

2014-05-12 Thread BigBlueHat
Github user BigBlueHat commented on the pull request: https://github.com/apache/couchdb/pull/137#issuecomment-42826645 Cool by me. Thanks, @garrensmith --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] couchdb pull request: 1870 add language option to mapreduce editor

2014-05-12 Thread garrensmith
Github user garrensmith commented on the pull request: https://github.com/apache/couchdb/pull/137#issuecomment-42811759 @BigBlueHat I think we should close this PR but keep the branch. It needs a fair amount of work before it can be merged. As shown in (COUCHDB-1870)[https://issues.ap

[GitHub] couchdb pull request: 1870 add language option to mapreduce editor

2014-03-21 Thread garrensmith
Github user garrensmith commented on the pull request: https://github.com/apache/couchdb/pull/137#issuecomment-38260382 Refactoring the ViewEditor is a great idea, unfortunately @BigBlueHat this PR is not ready to be merged into master. Two things need to be done to make it usable. I'

[GitHub] couchdb pull request: 1870 add language option to mapreduce editor

2014-03-20 Thread BigBlueHat
Github user BigBlueHat commented on the pull request: https://github.com/apache/couchdb/pull/137#issuecomment-38221861 @garrensmith it's closer, I think. :) I'm working on fixing the "saving coffeescript into a javascript ddoc" thing...but it's taking some heavy refactoring...

[GitHub] couchdb pull request: 1870 add language option to mapreduce editor

2014-03-14 Thread garrensmith
Github user garrensmith commented on a diff in the pull request: https://github.com/apache/couchdb/pull/137#discussion_r10615703 --- Diff: src/fauxton/app/addons/documents/views.js --- @@ -1598,6 +1633,11 @@ function(app, FauxtonAPI, Components, Documents, Databases, pouchdb, resiz

[GitHub] couchdb pull request: 1870 add language option to mapreduce editor

2014-03-14 Thread garrensmith
Github user garrensmith commented on a diff in the pull request: https://github.com/apache/couchdb/pull/137#discussion_r10615649 --- Diff: src/fauxton/app/addons/documents/views.js --- @@ -1324,9 +1353,13 @@ function(app, FauxtonAPI, Components, Documents, Databases, pouchdb, resiz

[GitHub] couchdb pull request: 1870 add language option to mapreduce editor

2014-03-14 Thread garrensmith
Github user garrensmith commented on a diff in the pull request: https://github.com/apache/couchdb/pull/137#discussion_r10615562 --- Diff: src/fauxton/app/addons/config/resources.js --- @@ -63,6 +63,7 @@ function (app, FauxtonAPI) { parse: function (resp) { retur

[GitHub] couchdb pull request: 1870 add language option to mapreduce editor

2014-03-14 Thread garrensmith
Github user garrensmith commented on the pull request: https://github.com/apache/couchdb/pull/137#issuecomment-37666090 hey @BigBlueHat, so far looking good. The only issue I'm getting is that you can save a coffeescript view to a design doc thats javascript. I think we have to do som

[GitHub] couchdb pull request: 1870 add language option to mapreduce editor

2014-03-14 Thread garrensmith
Github user garrensmith commented on a diff in the pull request: https://github.com/apache/couchdb/pull/137#discussion_r10613508 --- Diff: src/fauxton/app/addons/documents/views.js --- @@ -1324,9 +1353,13 @@ function(app, FauxtonAPI, Components, Documents, Databases, pouchdb, resiz

[GitHub] couchdb pull request: 1870 add language option to mapreduce editor

2014-03-14 Thread BigBlueHat
Github user BigBlueHat commented on the pull request: https://github.com/apache/couchdb/pull/137#issuecomment-37662986 @garrensmith @kxepal @deathbearbrown I can squash this before we merge it of course, but this should properly provide javascript + one (or eventually more) la

couchdb pull request: 1870 add language option to mapreduce editor

2014-01-21 Thread BigBlueHat
GitHub user BigBlueHat opened a pull request: https://github.com/apache/couchdb/pull/137 1870 add language option to mapreduce editor This should close the deceptively simple sounding [COUCHDB-1870](https://issues.apache.org/jira/browse/COUCHDB-1870). It includes a new ACE