Re: git commit: Fix SpiderMonkey version detection

2012-01-22 Thread Filipe David Manana
Paul, after this change I'm no longer able to build master (haven't tried other branches however). configure can't find js/jsapi.h, this is because my jsapi.h doesn't live inside a js directory. Ubuntu 10.10 jsapi.h full path: /usr/include/xulrunner-1.9.2.24/jsapi.h flags passed to configure:

Re: git commit: Fix SpiderMonkey version detection

2012-01-22 Thread Bob Dionne
same issue here, jsapi.h isn't in a js directory. MBA running Lion On Jan 22, 2012, at 1:15 PM, Filipe David Manana wrote: Paul, after this change I'm no longer able to build master (haven't tried other branches however). configure can't find js/jsapi.h, this is because my jsapi.h doesn't

Re: git commit: Fix SpiderMonkey version detection

2012-01-22 Thread Dave Cottlehuber
On 22 January 2012 19:15, Filipe David Manana fdman...@apache.org wrote: Paul, after this change I'm no longer able to build master (haven't tried other branches however). Ditto. configure can't find js/jsapi.h, this is because my jsapi.h doesn't live inside a js directory. Ubuntu 10.10

Re: git commit: Fix SpiderMonkey version detection

2012-01-22 Thread Paul Davis
Dave pasted me part of his. I realized that I moved the header check above the spot where we assign the JS_CPPFLAGS which was dumb of me. Pushed a fix in 572b561adbf852e08c7397519070f299d0b401e4 to master. Soon as I have confirmation it's correct I'll backport to 1.2.x and 1.1.x On Sun, Jan 22,

Re: git commit: Fix SpiderMonkey version detection

2012-01-22 Thread Paul Davis
Dave confirmed. Backported to 1.1.x and 1.2.x. Sorry for the dumb mistake on that one. On Sun, Jan 22, 2012 at 2:47 PM, Paul Davis paul.joseph.da...@gmail.com wrote: Dave pasted me part of his. I realized that I moved the header check above the spot where we assign the JS_CPPFLAGS which was