[ 
https://issues.apache.org/jira/browse/RAT-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16340241#comment-16340241
 ] 

Matthias Bläsing commented on RAT-242:
--------------------------------------

I had another look at it and the unittests currently run correctly. I suggest 
to close this for now and reopen/contact me if it surfaces again. For the 
record things that could go wrong:
 * the JVM could deny access to the system properties and thus the needed 
latin1 encoding can't be set for the invocation of the test (should raise an 
exception)
 * parallel test runs (threaded in the same VM) would also expose the unittests 
to race conditions (the default encoding is set VM wide)
 * different VM implementations could use different fields/caching strategies 
for the default file encoding (I'd expect an exception then)
 * JVM might not make the field accessible (relevant for JDK 9), should also 
raise an exception

I hoped to get some more insight, but from the look all should be good.

> Encoding of XML report
> ----------------------
>
>                 Key: RAT-242
>                 URL: https://issues.apache.org/jira/browse/RAT-242
>             Project: Apache Rat
>          Issue Type: Bug
>          Components: reports
>    Affects Versions: 0.12
>         Environment: ubuntu
>            Reporter: Eric Barboni
>            Priority: Major
>         Attachments: rat-242.patch
>
>
> Hi, we encounter an issue with encoding of a xml rat report. 
> We try to parse an xml rat report generated on an iso-8859-1 file system. The 
> xml has no encoding element in the prolog. If you open it with fileinpustream 
> it may fail.
> last comment in this pull request 
> (https://github.com/apache/incubator-netbeans/pull/70)  by Matthias Bläsing  
> suggest forcing to UTF-8.
> encoding  may also be an option in the report task
> Regards



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to