[ 
https://issues.apache.org/jira/browse/RAT-177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14136135#comment-14136135
 ] 

Philipp Ottlinger commented on RAT-177:
---------------------------------------

[~s...@apache.org] converted Arrays into lists and simplified code to 
addElements and merge defaults with configured matchers. Is that what you 
intended?
[r1625380|http://svn.apache.org/r1625380]

> final arrays should be private
> ------------------------------
>
>                 Key: RAT-177
>                 URL: https://issues.apache.org/jira/browse/RAT-177
>             Project: Apache Rat
>          Issue Type: Bug
>    Affects Versions: 0.11
>            Reporter: Sebb
>            Assignee: Philipp Ottlinger
>
> There are quite a few public string arrays in the guessers and the file 
> Defaults.java
> These are intended to be constants, but elements of a final array are not 
> themselves final.
> The arrays should be made private, and suitable accessors provided, depending 
> on how the entries are used.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to